about last years commits for JMS

2012-06-21 Thread Jacopo Cappellato
Jacques, could you please help me to understand all the changes you did around JMS? I see some issues (e.g. the value of ServiceDispatcher.enableJMS is ignored) and reviewing the history of commits I have seen that you have committed changes, then fixed them (partially reverting?) but all in al

Re: svn commit: r1352768 - in /ofbiz/trunk/applications/accounting: data/AccountingSecurityPermissionSeedData.xml src/org/ofbiz/accounting/payment/PaymentGatewayServices.java webapp/accounting/payment

2012-06-21 Thread Hans Bakker
Thanks for spotting this, corrected in r 1352774 The reason for these changes is that ACCOUNTING_ADMIN really can do everything in the accounting manager and that not many different permissions are required. Regards, Hans On 06/22/2012 11:43 AM, Jacopo Cappellato wrote: On Jun 22, 2012, at

Re: svn commit: r1352769 - in /ofbiz/trunk/applications/accounting: data/AccountingSecurityGroupDemoData.xml data/AccountingSecurityPermissionSeedData.xml widget/AccountingMenus.xml

2012-06-21 Thread Hans Bakker
Yes these were intentional because they are now covered by the account_admin permission. On 06/22/2012 11:46 AM, Jacopo Cappellato wrote: Hans, I did only a cursory review but I don't understand the reason for the removal of the rntries below... was it intentional? Regards, Jacopo On Jun 2

Re: svn commit: r1352769 - in /ofbiz/trunk/applications/accounting: data/AccountingSecurityGroupDemoData.xml data/AccountingSecurityPermissionSeedData.xml widget/AccountingMenus.xml

2012-06-21 Thread Jacopo Cappellato
Hans, I did only a cursory review but I don't understand the reason for the removal of the rntries below... was it intentional? Regards, Jacopo On Jun 22, 2012, at 6:12 AM, hans...@apache.org wrote: > Modified: > ofbiz/trunk/applications/accounting/data/AccountingSecurityGroupDemoData.xml >

Re: svn commit: r1352768 - in /ofbiz/trunk/applications/accounting: data/AccountingSecurityPermissionSeedData.xml src/org/ofbiz/accounting/payment/PaymentGatewayServices.java webapp/accounting/payment

2012-06-21 Thread Jacopo Cappellato
On Jun 22, 2012, at 6:04 AM, hans...@apache.org wrote: > // security check > -if (!security.hasEntityPermission("MANUAL", "_PAYMENT", userLogin)) { > +if (!security.hasEntityPermission("MANUAL", "_PAYMENT", userLogin) > && !security.hasEntityPermission("MANUAL", "_PAYMENT

buildbot success in ASF Buildbot on ofbiz-trunk

2012-06-21 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/3215 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: scheduler Build Sourc

buildbot failure in ASF Buildbot on ofbiz-trunk

2012-06-21 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/3214 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: scheduler Build Source S

[jira] [Commented] (OFBIZ-4906) More german translations

2012-06-21 Thread Martin Kaiser (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398492#comment-13398492 ] Martin Kaiser commented on OFBIZ-4906: -- Yes, this could be an improvement. But I thi

[jira] [Comment Edited] (OFBIZ-4906) More german translations

2012-06-21 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398450#comment-13398450 ] Adrian Crum edited comment on OFBIZ-4906 at 6/21/12 2:48 PM: -

[jira] [Commented] (OFBIZ-4906) More german translations

2012-06-21 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398450#comment-13398450 ] Adrian Crum commented on OFBIZ-4906: To make what I'm proposing clearer, I can use a s

[jira] [Commented] (OFBIZ-4906) More german translations

2012-06-21 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398445#comment-13398445 ] Adrian Crum commented on OFBIZ-4906: That type of difference is worth discussing. Some

[jira] [Commented] (OFBIZ-4906) More german translations

2012-06-21 Thread Martin Kaiser (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398437#comment-13398437 ] Martin Kaiser commented on OFBIZ-4906: -- I contributed the files with the translations

[jira] [Assigned] (OFBIZ-4906) More german translations

2012-06-21 Thread Christian Geisert (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Geisert reassigned OFBIZ-4906: Assignee: Christian Geisert > More german translations > --

buildbot success in ASF Buildbot on ofbiz-trunk

2012-06-21 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/3212 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: scheduler Build Sourc

buildbot failure in ASF Buildbot on ofbiz-trunk

2012-06-21 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/3211 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: scheduler Build Source S

Re: security groups are not seed reader type data.

2012-06-21 Thread Hans Bakker
Implemented as discussed with revision: r1352431 | hansbak | 2012-06-21 14:21:49 +0700 (Thu, 21 Jun 2012) | 2 lines split up securitypermissions as seed data and securitygroups as demo data with a single exception: the creation of a super security group which has general access to the system a