[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401187#comment-13401187 ] Jacopo Cappellato commented on OFBIZ-4289: -- I suspect that it worked because of t

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Hans Bakker
Ok sounds pretty reasonable, let me see what i can do in my free time Regards, Hans On 06/26/2012 12:08 PM, Jacopo Cappellato wrote: Yes, Scott explained very well the concept: ACCOUNTING_CREATE will give grants to create all records in Accounting; PAY_INFO_CREATE will give grants only to

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Jacopo Cappellato
Yes, Scott explained very well the concept: ACCOUNTING_CREATE will give grants to create all records in Accounting; PAY_INFO_CREATE will give grants only to create payments. Jacopo On Jun 26, 2012, at 5:38 AM, Scott Gray wrote: > If I had to guess I would think your proposition would be rever

[jira] [Commented] (OFBIZ-4915) Lookup Form not working with Arabic characters

2012-06-25 Thread Paul Foxworthy (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401169#comment-13401169 ] Paul Foxworthy commented on OFBIZ-4915: --- Hi Taher, ConstructLookup and related func

Re: Controllers redirections do 302

2012-06-25 Thread Scott Gray
Right, so they recommend using 301 for a permanent redirect but like I said, the bulk of our redirects (as far as I am aware) are used for Post Redirects which 301 isn't appropriate for. Regards Scott On 26/06/2012, at 2:15 AM, Jacques Le Roux wrote: > http://support.google.com/webmasters/bin/

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Scott Gray
If I had to guess I would think your proposition would be reversed: PAY_INFO should grant limited access to ACCOUNTING functionality. On 26/06/2012, at 12:01 PM, Hans Bakker wrote: > Yes Jacopo, I know all that, but the question is as I wrote: > > The question here is do you really want to allow

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Hans Bakker
Yes Jacopo, I know all that, but the question is as I wrote: The question here is do you really want to allow access for ACCOUNTING_CREATE to have the same access as PAY_INFO_CREATE ? Perhaps the intention here was that, by creating a separate action PAY_INFO the ACCOUNTING_CREATE should not h

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Jacopo Cappellato
Hi Hans, I think that the intended meaning is the following: ACCOUNTING_: global permission to all parts of the Accounting application when performing the ACCOUNTING_ADMIN: global permission to all parts of the Accounting application when performing all the actions So for example: ACCOUNTING

Re: svn commit: r1353686 - in /ofbiz/trunk/framework: service/src/org/ofbiz/service/ServiceDispatcher.java webapp/src/org/ofbiz/webapp/control/ContextFilter.java widget/src/org/ofbiz/widget/tree/Model

2012-06-25 Thread Jacopo Cappellato
Ooops, it was not intentional (not for this commit), sorry for this (I am reverting that). Thanks Jacopo On Jun 25, 2012, at 9:33 PM, Jacques Le Roux wrote: > Hi Jacopo, > > Is it intentionally that the 1st hunk was committed or did it slip in? > > Jacques > > From: >> Author: jacopoc >> D

[jira] [Comment Edited] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400479#comment-13400479 ] Jacques Le Roux edited comment on OFBIZ-4289 at 6/25/12 7:47 PM: ---

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400817#comment-13400817 ] Jacques Le Roux commented on OFBIZ-4289: Sure I will wait maybe more, no hurry the

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Hans Bakker
Hi Jacopo, thanks for reviewing this commit, my compliments for your work in this area. The question here is do you really want to allow access for ACCOUNTING_CREATE to have the same access as PAY_INFO_CREATE ? Perhaps the intention here was that, by creating a separate action PAY_INFO the

Re: svn commit: r1353686 - in /ofbiz/trunk/framework: service/src/org/ofbiz/service/ServiceDispatcher.java webapp/src/org/ofbiz/webapp/control/ContextFilter.java widget/src/org/ofbiz/widget/tree/Model

2012-06-25 Thread Jacques Le Roux
Hi Jacopo, Is it intentionally that the 1st hunk was committed or did it slip in? Jacques From: Author: jacopoc Date: Mon Jun 25 18:00:01 2012 New Revision: 1353686 URL: http://svn.apache.org/viewvc?rev=1353686&view=rev Log: Fixed a few wrong attribute names: authorization --> authz Modifie

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400810#comment-13400810 ] Jacopo Cappellato commented on OFBIZ-4289: -- Please feel free to back port (maybe

Re: svn commit: r1353681 - in /ofbiz/trunk: applications/accounting/webapp/accounting/WEB-INF/ applications/content/webapp/content/WEB-INF/ applications/humanres/webapp/humanres/WEB-INF/ applications/

2012-06-25 Thread Jacques Le Roux
This looks good to me, hoping that nobody really needs CoreEvents.changeDelegator(), but yes OOTB it's ok with me... Jacques From: "Jacopo Cappellato" To the committers/developers involved in the development of multitenant support: please review this commit and test it in the multitenant envi

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400800#comment-13400800 ] Jacques Le Roux commented on OFBIZ-4289: Before closing I'd like to backport (mayb

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400797#comment-13400797 ] Jacques Le Roux commented on OFBIZ-4289: Jacopo, I reviewed and it's ok with me,

Proposal for a GUI/Web debug mode

2012-06-25 Thread Brian Cunningham
Hi Dev group, I'm very new to OFBiz, so I may be covering old ground. If not, I'd like to propose a debug mode for the UI of OFBiz along the lines of that in OLAT. If you've never seen it, take a look at: http://demo.olat.org/demo/dmz/ - click the word "System Administrator" in the dropdown to

[jira] [Assigned] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-4289: Assignee: Jacques Le Roux (was: Jacopo Cappellato) It should be fixed in rev. 1353

Fwd: svn commit: r1353681 - in /ofbiz/trunk: applications/accounting/webapp/accounting/WEB-INF/ applications/content/webapp/content/WEB-INF/ applications/humanres/webapp/humanres/WEB-INF/ applications

2012-06-25 Thread Jacopo Cappellato
To the committers/developers involved in the development of multitenant support: please review this commit and test it in the multitenant environment and confirm it works fine, thanks. I have seen a lot of bad code around the implementation of multitenancy and this is actually a first pass in th

[jira] [Assigned] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-4289: Assignee: Jacopo Cappellato (was: Jacques Le Roux) > Login out on a cluster ha

Re: svn commit: r646349 - in /ofbiz/trunk/framework: appserver/ appserver/src/org/ofbiz/appservers/ appserver/templates/wasce2/ base/src/base/org/ofbiz/base/util/string/ webapp/src/org/ofbiz/webapp/co

2012-06-25 Thread Jacques Le Roux
From: "Jacopo Cappellato" Hi all, this is part of my review of framework code to make it cleaner. I see a series of questionable changes in this commit, do you agree? Jacques, before I start my review please let me know if you want to do a first pass on it. I can certainly have a fresh look

Re: FYI: ms & mx vs Xms & Xmx

2012-06-25 Thread Jacques Le Roux
Thanks Sharad, The 2nd I already posted earlier, nothing about the subject in these links, right? Anyway it's no biggie... Don't use html format by default for your mails. It increases the SpamAssasin score and this could be the reason some of your mails are rejected... Jacques - Origina

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400590#comment-13400590 ] Jacques Le Roux commented on OFBIZ-4289: One last note though: what I put in my la

Re: svn commit: r646349 - in /ofbiz/trunk/framework: appserver/ appserver/src/org/ofbiz/appservers/ appserver/templates/wasce2/ base/src/base/org/ofbiz/base/util/string/ webapp/src/org/ofbiz/webapp/co

2012-06-25 Thread Jacopo Cappellato
Another commit (somewhat related) that will need to be reviewed is Author: jleroux Date: Tue Apr 29 15:35:32 2008 New Revision: 652177 URL: http://svn.apache.org/viewvc?rev=652177&view=rev Log: This add the possiblity to run RMI services under WASCE or Geronimo. There is only one small drawback :

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400555#comment-13400555 ] Jacques Le Roux commented on OFBIZ-4289: I agree Jacopo > Login o

Re: svn commit: r646349 - in /ofbiz/trunk/framework: appserver/ appserver/src/org/ofbiz/appservers/ appserver/templates/wasce2/ base/src/base/org/ofbiz/base/util/string/ webapp/src/org/ofbiz/webapp/co

2012-06-25 Thread Jacopo Cappellato
Hi all, this is part of my review of framework code to make it cleaner. I see a series of questionable changes in this commit, do you agree? Jacques, before I start my review please let me know if you want to do a first pass on it. Thanks, Jacopo On Apr 9, 2008, at 3:51 PM, jler...@apache.org

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400525#comment-13400525 ] Jacopo Cappellato commented on OFBIZ-4289: -- In short, this fix really covers a sm

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400510#comment-13400510 ] Jacques Le Roux commented on OFBIZ-4289: Yes, I tried to fix an issue I crossed be

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Jacopo Cappellato
Hi Hans, I understand the issue you are fixing in this commit (and at least another one of last week) but I disagree with the approach. We should never add permission checks on the *_ADMIN permissions: we should instead always use one of the fine grained _CREATE, _UPDATE, _DELETE; the _ADMIN pe

Re: Controllers redirections do 302

2012-06-25 Thread Jacques Le Roux
http://support.google.com/webmasters/bin/answer.py?hl=en&answer=93633 http://support.google.com/webmasters/bin/answer.py?hl=en&answer=40132 http://searchengineland.com/images/301-302-explained.gif HTH Jacques From: "Scott Gray" I think most of our redirects OOTB are used as a Post/Redirect/Ge

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400486#comment-13400486 ] Jacopo Cappellato commented on OFBIZ-4289: -- The way I see it is that the map in t

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400479#comment-13400479 ] Jacques Le Roux commented on OFBIZ-4289: I get this also (in a customised instance

[jira] [Updated] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4289: --- Attachment: ofbiz.log > Login out on a cluster handled by DeltaManager causes a NPE > ---

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400409#comment-13400409 ] Jacopo Cappellato commented on OFBIZ-4289: -- No, the error is actually: 2012-06-

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400405#comment-13400405 ] Jacopo Cappellato commented on OFBIZ-4289: -- With reference to the error in the lo

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400380#comment-13400380 ] Jacopo Cappellato commented on OFBIZ-4289: -- I tested it and I see errors in the l

[jira] [Updated] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4289: --- Attachment: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch Jac

Re: Controllers redirections do 302

2012-06-25 Thread Scott Gray
I think most of our redirects OOTB are used as a Post/Redirect/Get pattern for which 303 is best on HTTP 1.1 or 302 on HTTP 1.0 http://en.wikipedia.org/wiki/Post/Redirect/Get Do you have a reference for your SEO best practices? Or alternatively do you have an example of where a 301 redirect woul

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400358#comment-13400358 ] Jacopo Cappellato commented on OFBIZ-4289: -- Jacques... there are still issues and

[jira] [Updated] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

2012-06-25 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4289: --- Attachment: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch Jac