Re: Should not catch Exception in EntityUtilProperties.getSystemPropertyValue()

2017-03-01 Thread Rishi Solanki
Thank you Wei, Jacques for your reply. What I was proposing to change method of WidgetWorker.getDelegator() method. I see whenever any form render the fields and requires delegator then it always tries to get delegator from WidgetWorker's mentioned method. Please refer MacroFormRenederer class as

Re: Should not catch Exception in EntityUtilProperties.getSystemPropertyValue()

2017-03-01 Thread Wei Zhang
I think we need to do 3 things. 1. Catch GenericEntityException in EntityUtilProperties.getSystemPropertyValue() 2. Create a new Delegator if it is null in EntityUtilProperties.getSystemPropertyValue() 3. Find out how to get a delegator instance in framework/widget/templates/HtmlFormMacroLibrary.f

Re: Should not catch Exception in EntityUtilProperties.getSystemPropertyValue()

2017-03-01 Thread Jacques Le Roux
Thanks Rishi, Yes, good idea! What do you suggest we use for delegatorName? I guess "default"? Also for OFBIZ-9230 it should be rather -- Index:

Re: Git for commiters

2017-03-01 Thread Jacques Le Roux
Thanks Scott, Seems you are the only person to still use it. I guess it's better to let it as is for now. Jacques Le 01/03/2017 à 04:45, Scott Gray a écrit : I couldn't say sorry, I set it up once 5+ years ago and I've never had to set it up again since. The instructions don't look clear to

Ecommerce links from applications

2017-03-01 Thread Jacques Le Roux
Hi, While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply entrenched in some applications components. This can at least be tested with product and catalog webapp. Get to catalog/control/EditProduct?productId=GZ-1000 Click on the "Product Page" button => ecommerce There a