Check for only QOH while doing reservations

Hello, While checking around code around inventory reservations, I was surprised to see that *reserveProductInventory *service only checks for QOH quantity greater than one apart from that when *reserveFromInventoryItemInline *is called, it checks for ATP confirming system to behave as required.

Re: svn commit: r1815412 - in /ofbiz: ofbiz-framework/trunk/NOTICE ofbiz-framework/trunk/themes/rainbowstone/README.md tools/rat-excludes.txt

Another option could be to replace this font by another one from Category A, like Google "Noto Sans" or what not But I don't know why Julien picked this font. There might be reasons to use it... Jacques Le 06/04/2018 à 08:03, Jacques Le Roux a écrit : It's actually a category b (how did we

Re: svn commit: r1815412 - in /ofbiz: ofbiz-framework/trunk/NOTICE ofbiz-framework/trunk/themes/rainbowstone/README.md tools/rat-excludes.txt

It's actually a category b (how did we miss it? :-o). I have closed LEGAL-380 as duplicate of LEGAL-112 Following advice at http://www.apache.org/legal/resolved.html#category-b

Re: svn commit: r1815412 - in /ofbiz: ofbiz-framework/trunk/NOTICE ofbiz-framework/trunk/themes/rainbowstone/README.md tools/rat-excludes.txt

https://issues.apache.org/jira/browse/LEGAL-380 Jacques Le 05/04/2018 à 10:16, Jacopo Cappellato a écrit : On Thu, Apr 5, 2018 at 9:42 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Yes, will you do the move? Yes, I will take care of it Jacopo

Question on entity definition for ProductCategoryAttribute

Hi everyone, while I was working onJira Issue OFBIZ-10327 and 10328 I stumbled across the entity definition for ProductCategoryAttribute  (in /ofbiz/applications/datamodel/entitydef/product

Re: why some fields are set to enable-audit-log true by default?

Le 05/04/2018 à 13:25, Jacques Le Roux a écrit : Le 05/04/2018 à 11:49, Taher Alkhateeb a écrit : Hmm, I see no problem in example being a plugin. Just because it's a plugin doesn't mean it lost its value or purpose (to give people examples). So sounds good by me to add such fields to the exampl

Re: why some fields are set to enable-audit-log true by default?

Le 05/04/2018 à 11:49, Taher Alkhateeb a écrit : Hmm, I see no problem in example being a plugin. Just because it's a plugin doesn't mean it lost its value or purpose (to give people examples). So sounds good by me to add such fields to the example component. Just that people using OFBiz without

Re: Deprecate properties in favour of SystemProperties

I made some clear propositions in my first answer to this thread. Essentially, I'm against deprecating file based properties and be in favor of a general fallback solution (SystemProperty -> .properties) for all properties *except* properties which cannot be read from the database (system star

Re: why some fields are set to enable-audit-log true by default?

Hmm, I see no problem in example being a plugin. Just because it's a plugin doesn't mean it lost its value or purpose (to give people examples). So sounds good by me to add such fields to the example component. In fact, I would suggest that not only add them, but show the users how to view the res

Re: why some fields are set to enable-audit-log true by default?

I'm not sure about Example component, it's now a plugin... Maybe having an example in Entity component for the test is enough? Also there is the auto-completion from XSD But anyway not against Example component Jacques Le 05/04/2018 à 11:36, Rishi Solanki a écrit : +1 for removal. +1 to Sco

Re: Deprecate properties in favour of SystemProperties

If my understanding is correct from Scott's suggestion, then this entails substantial work as we need to: - Identify "everything else" which is not a system configuration property. Maybe some examples - Find, and fix code related to properties which should not exist in both db and files (remove fa

Re: why some fields are set to enable-audit-log true by default?

+1 for removal. +1 to Scott for having an example in the system ... Example entities seems right place as mentioned. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Apr 5, 2018 at 5:38 AM,

Re: Deprecate properties in favour of SystemProperties

Thanks Scott, This is indeed essentially it. I'll get into details in a new thread. Notably about how to load data. Jacques Le 05/04/2018 à 10:39, Scott Gray a écrit : My understanding is that Jacques is essentially proposing that: - Properties should either exist in the db or in files but no

Re: Deprecate properties in favour of SystemProperties

My understanding is that Jacques is essentially proposing that: - Properties should either exist in the db or in files but not both - System configuration properties should go in files (I assume everything that isn't applicable to multi-tenanting) - Everything else should go to the db If propertie

Re: svn commit: r1815412 - in /ofbiz: ofbiz-framework/trunk/NOTICE ofbiz-framework/trunk/themes/rainbowstone/README.md tools/rat-excludes.txt

On Thu, Apr 5, 2018 at 9:42 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Yes, will you do the move? Yes, I will take care of it Jacopo

Re: Deprecate properties in favour of SystemProperties

To clarify, I'll do a recollection of all in a new Thread where I'll summarize. There are indeed several aspects. Jacques Le 05/04/2018 à 09:26, Taher Alkhateeb a écrit : There is no need to copy paste! I already read the jira and expressed my confusion which is still the case. Your text is l

Re: svn commit: r1815412 - in /ofbiz: ofbiz-framework/trunk/NOTICE ofbiz-framework/trunk/themes/rainbowstone/README.md tools/rat-excludes.txt

Yes, will you do the move? Jacques Le 05/04/2018 à 08:52, Jacopo Cappellato a écrit : To summarize: 1) we will move the text from NOTICE to LICENSE, because it is currently misplaced 2) you will ask legal if the "SIL OPEN FONT" LICENSE Version 1.1 can be considered a category-A license Jacop

Re: Deprecate properties in favour of SystemProperties

There is no need to copy paste! I already read the jira and expressed my confusion which is still the case. Your text is long and talks about many things and does not provide a concrete proposal or a patch. What do you want to do? Rename system properties? Move properties? What are they? Create te