Re: Update our HTTP headers

2018-05-23 Thread Jacques Le Roux
Committed at r1832128 Jacques Le 18/05/2018 à 15:47, Jacques Le Roux a écrit : Hi, At https://issues.apache.org/jira/browse/OFBIZ-6766 I have attached a minor OFBIZ-6766-UtilHttp.java.patch for updating our HTTP headers I think it's OK to commit, but before I'd like to know if we really wan

Re: Update our HTTP headers

2018-05-23 Thread Jacques Le Roux
It's not related to IE, finally we have not problems with x-ua-compatible Private is well explained in the 2 1st links. Jacques Le 23/05/2018 à 15:07, Taher Alkhateeb a écrit : There are at least 4 links and many comments in the JIRA, I'm not sure which one are you referring to. Anyway, it sou

Re: Improve look of ecommerce main ftl when checking out

2018-05-23 Thread Jacques Le Roux
It's not empty there is even an image, do you see it as empty :-o ? The idea is to get ideas on how to change that. BTW I have just added one Jacques Le 23/05/2018 à 15:10, Taher Alkhateeb a écrit : Why share an empty JIRA on the ML? On Wed, May 23, 2018 at 1:06 PM, Jacques Le Roux wrote:

Re: Improve look of ecommerce main ftl when checking out

2018-05-23 Thread Taher Alkhateeb
Why share an empty JIRA on the ML? On Wed, May 23, 2018 at 1:06 PM, Jacques Le Roux wrote: > Le 14/05/2018 à 10:59, Jacques Le Roux a écrit : >> >> Though defined as a list in plugins/ecommerce/template/cart/MiniCart.ftl >> the >> >> View Cart >> Check out >> Quick Checkout >> One

Re: Update our HTTP headers

2018-05-23 Thread Taher Alkhateeb
There are at least 4 links and many comments in the JIRA, I'm not sure which one are you referring to. Anyway, it sounds correct because it is utilized from the function "setResponseBrowserProxyNoCache(...)" So I think it looks fine. Good job with the research. IE continues to cause so much headac

Re: Improve look of ecommerce main ftl when checking out

2018-05-23 Thread Jacques Le Roux
Le 14/05/2018 à 10:59, Jacques Le Roux a écrit : Though defined as a list in plugins/ecommerce/template/cart/MiniCart.ftl the     View Cart     Check out     Quick Checkout     One Page Checkout block is not vertical but horizontal. I think we should change that to mare it more legible I crea

Re: Update our HTTP headers

2018-05-23 Thread Jacques Le Roux
Le 21/05/2018 à 20:13, Taher Alkhateeb a écrit : HTTP headers setting is a complex topic with lots of details. I think we need a comprehensive source and a discussion on best practices, Does not the special page I created in the wiki help? maybe we should make some of the headers configurable

Re: svn commit: r1828857 - in /ofbiz/ofbiz-framework/trunk/docs/asciidoc: documentation_guidelines.adoc resource/ resource/article.adoc resource/source.java

2018-05-23 Thread Jacques Le Roux
Done at revision 1832091. Jacques Le 19/05/2018 à 18:39, Jacques Le Roux a écrit : Hi Michael, Any chances? Do you want me to do it? Jacques Le 08/05/2018 à 14:31, Jacques Le Roux a écrit : Hi Michael, source.java needs either a ASL2 header (I guess not) or to be in https://svn.apache.o