Hi Mathieu,
inline...
It's a good approach to let fellow committers review such work before
it gets committed to the codebase.
I agree in theory, but given the poor state of the codebase I feel that
requiring that every single change is delayed for 2/3 days or more to
let people review it is n
Hello Taher,
Taher Alkhateeb writes:
> I was involved in some of the biggest changes in the framework
> (gradle, unit tests, start component, core framework, etc ...) and
> every time it involved a good deep discussion on the mailing list
> trying to reach consensus before implementation.
>
> So
Hi James,
I did not mean that there is a need for CSRF token with GET request. Only that it's easier to implement it to all requests than having to search the
difference.
Jacques
Le 08/12/2019 à 13:07, James Yong a écrit :
Hi all,
Thanks for the feedback.
Will start with CSRF Token imple
Michael Brohl writes:
> I was in fact asking for the discussion and review process to the
> changes already introduced and committed in the mentioned Jira.
OK
> It's a good approach to let fellow committers review such work before
> it gets committed to the codebase.
I agree in theory, but giv
Hello Mathieu, Michael, All
I was involved in some of the biggest changes in the framework
(gradle, unit tests, start component, core framework, etc ...) and
every time it involved a good deep discussion on the mailing list
trying to reach consensus before implementation.
So I recommend always tr
Hi Mathieu,
I was in fact asking for the discussion and review process to the
changes already introduced and committed in the mentioned Jira.
It's a good approach to let fellow committers review such work before it
gets committed to the codebase.
This change will affect existing productive
Nicolas Malin writes:
> Effectively, good point to make more attention on the future.
>
> I'm not sure that I can amend this commit without make a push force
> after, so I prefer to keep this error instead generate more
> inconvenient.
Indeed that was my suggestion to follow this convention in y
Effectively, good point to make more attention on the future.
I'm not sure that I can amend this commit without make a push force
after, so I prefer to keep this error instead generate more inconvenient.
thanks also Jacques for the following issue :)
Nicolas
On 08/12/2019 09:58, Jacques Le R
Hello Michael,
Michael Brohl writes:
> can you please point me to the discussion where this important change
> was discussed before it was introduced?
>
> I only find the Jira https://issues.apache.org/jira/browse/OFBIZ-11296
> which was closed only hours after it was created.
If you speak abou
Hi all,
Thanks for the feedback.
Will start with CSRF Token implementation for POST request.
Please see OFBIZ-11306 which has a patch for POC.
Hi Jacques,
Can explain the need for CSRF token with GET request?
Regards,
James
On 2019/11/27 09:47:04, Jacques Le Roux wrote:
> Hi James,
>
Hi Mathieu,
can you please point me to the discussion where this important change
was discussed before it was introduced?
I only find the Jira https://issues.apache.org/jira/browse/OFBIZ-11296
which was closed only hours after it was created.
I was a bit off lately, maybe I missed something
Le 07/12/2019 à 16:06, Mathieu Lirzin a écrit :
Hello Nico,
nma...@apache.org writes:
commit 071a74238b4d53fb95ffd214e0e68e55840a28e3
Author: Nicolas Malin
AuthorDate: Fri Dec 6 21:29:01 2019 +0100
Fixed: Fix missing else during previous refactoring
(OFBIZ-11253)
When you rend
12 matches
Mail list logo
