Re: @deprecated No replacement

2020-05-22 Thread Pierre Smits
+1 forellen removing refs Op za 23 mei 2020 08:27 schreef Devanshu Vyas : > +1 to remove references. > > Thanks & Regards, > Devanshu Vyas. > > > On Sat, May 23, 2020 at 11:54 AM Mridul Pathak < > mridul.pat...@hotwaxsystems.com> wrote: > > > +1 to remove references. > > > > Thanks. > > -- > > Mr

Re: @deprecated No replacement

2020-05-22 Thread Devanshu Vyas
+1 to remove references. Thanks & Regards, Devanshu Vyas. On Sat, May 23, 2020 at 11:54 AM Mridul Pathak < mridul.pat...@hotwaxsystems.com> wrote: > +1 to remove references. > > Thanks. > -- > Mridul Pathak > > > > On 22-May-2020, at 1:03 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wr

Re: @deprecated No replacement

2020-05-22 Thread Mridul Pathak
+1 to remove references. Thanks. -- Mridul Pathak > On 22-May-2020, at 1:03 PM, Jacques Le Roux > wrote: > > Hi, > > We have 5, 8 years old, , "@deprecated No replacement" references in Java > code: > https://ofbiz.markmail.org/search/?q=%22%40deprecated+No+replacement%22 > > It seems they

Re: Modify OFBiz commit message template

2020-05-22 Thread Mridul Pathak
+1 Thanks. -- Mridul Pathak > On 20-May-2020, at 2:31 PM, Jacques Le Roux > wrote: > > Hi, > > With Git IMO it's convenient (more information) to have the Jira number in > the title, eg: https://markmail.org/message/cyslglyoh5gf7l7t > > If nobody disagree I'd like to modify > > https://cw

Re: Modify OFBiz commit message template

2020-05-22 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, May 20, 2020 at 2:33 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > With Git IMO it's convenient (more information) to have the Jira number in > the title, eg: https://markmail.org/message/cyslglyoh5gf7l7

Re: Github PR template

2020-05-22 Thread Jacques Le Roux
I created https://issues.apache.org/jira/browse/OFBIZ-11722 for that Jacques Le 13/05/2020 à 12:13, Jacques Le Roux a écrit : Hi Deepak, Agreed, we had this discussion earlier: https://markmail.org/message/3l6dwx4vkknmovew We just miss a sub-task under https://issues.apache.org/jira/browse/O

Re: Modify OFBiz commit message template

2020-05-22 Thread Jacques Le Roux
I created https://issues.apache.org/jira/browse/OFBIZ-11298 for that Le 22/05/2020 à 08:58, Jacques Le Roux a écrit : Thanks All, I'll do that in 5 days, simple, efficient in Git. Jacques Le 20/05/2020 à 16:43, James Yong a écrit : +1 to [Implemented | Improved | Fixed | Completed| Doc

Re: Modify OFBiz commit message template

2020-05-22 Thread Jacques Le Roux
See the thread Le 22/05/2020 à 11:01, Pierre Smits a écrit : I meant this one: https://ofbiz.markmail.org/message/zllitqewumbefwd2?q=Github+PR+request+list:org%2Eapache%2Eofbiz%2Edev+order:date-backward&page=1 Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz

Re: @deprecated No replacement

2020-05-22 Thread Suraj Khurana
+1 to remove the "@deprecated No replacement" references. -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, May 22, 2020 at 1:03 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > We have 5, 8 years old, , "@deprecated No replacement" references in Java > code:

Re: Modify OFBiz commit message template

2020-05-22 Thread Pierre Smits
I meant this one: https://ofbiz.markmail.org/message/zllitqewumbefwd2?q=Github+PR+request+list:org%2Eapache%2Eofbiz%2Edev+order:date-backward&page=1 Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Tr

Re: Modify OFBiz commit message template

2020-05-22 Thread Jacques Le Roux
You mean the sonarcloud[bot]  thread? Le 22/05/2020 à 09:34, Pierre Smits a écrit : A few days ago a thread was also started regarding the PR. Is that now void? Or will it be handled in the same breath? Op vr 22 mei 2020 09:08 schreef Jacques Le Roux < jacques.le.r...@les7arts.com>: Thanks A

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-05-22 Thread Jacques Le Roux
Hi All, This is a checkstyle issue. It's not clear to me why it happened. Because there is only a Freemarker template change in 1388, weird! Also I begin to wonder if the community really cares about checkstyle issues... Opinions? Jacques Le 21/05/2020 à 17:06, build...@apache.org a écrit :

Re: buildbot failure in on ofbizTrunkFrameworkRat

2020-05-22 Thread Jacques Le Roux
I created https://issues.apache.org/jira/browse/INFRA-20297 for that Jacques Le 20/05/2020 à 11:34, build...@apache.org a écrit : The Buildbot has detected a new failure on builder ofbizTrunkFrameworkRat while building ofbiz-framework. Full details are available at: https://ci.apache.org/

Re: Modify OFBiz commit message template

2020-05-22 Thread Pierre Smits
A few days ago a thread was also started regarding the PR. Is that now void? Or will it be handled in the same breath? Op vr 22 mei 2020 09:08 schreef Jacques Le Roux < jacques.le.r...@les7arts.com>: > Thanks All, > > I'll do that in 5 days, simple, efficient in Git. > > Jacques > > Le 20/05/202

@deprecated No replacement

2020-05-22 Thread Jacques Le Roux
Hi, We have 5, 8 years old, , "@deprecated No replacement" references in Java code: https://ofbiz.markmail.org/search/?q=%22%40deprecated+No+replacement%22 It seems they are all related to Minilang.  I think we should either remove the concerned methods. Or rather, easier, remove the "@depreca

Re: Modify OFBiz commit message template

2020-05-22 Thread Jacques Le Roux
Thanks All, I'll do that in 5 days, simple, efficient in Git. Jacques Le 20/05/2020 à 16:43, James Yong a écrit : +1 to [Implemented | Improved | Fixed | Completed| Documented | Reverted]: [Jira title | Free text] [(OFBIZ-)] [More detailed explanation of what has been done and what