Unused location="${parameters.quoteDecoratorLocation}"

2020-06-05 Thread James Yong
Hi all, There are decorator screens with location ${parameters.quoteDecoratorLocation} i.e. But quoteDecoratorLocation variable isn't set anywhere in the project. Suggest to remove the location when value is "${parameters.quoteDecoratorLocation}". Regards, James

Re: linting issues on ‘trunk’, ‘gradlew check’ fails.

2020-06-05 Thread James Yong
Hi all, +1 to INFRA-20314. Committer should install a checkstyle plugin in the IDE pointing to our checkstyle.xml. This helps to highlight Lint errors so that style issues can be corrected early. Regards, James On 2020/06/05 17:30:18, Jacques Le Roux wrote: > Hi All, > > Since then we also

Re: linting issues on ‘trunk’, ‘gradlew check’ fails.

2020-06-05 Thread Jacques Le Roux
Hi All, Since then we also created INFRA-20314 At OFBIZ-11304 Aditya suggested something else. To use a Gradle plugin to add pre-commit hook. I tested it, it does not prevent a committer to push changes even if they increase the number of check style issues. I'd like to know what the communi

Re: EntityBatchIterator for large data set queries

2020-06-05 Thread Pawan Verma
Thanks, Pritam and Scott for the discussion. I've created Jira OFBIZ-11789 for this improvement and also created a PR with the proposed changes. I request everyone to review the PR and suggest your thought on this. Thanks! -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *En