Re: A little bit of Lombok

2020-08-26 Thread Shi Jinghai
Just my 2 cents. -1 for using Lombok plugin in OFBiz. I had some not good experiences with this plugin in Apereo CAS 5.3.x. 发送自 Windows 10 版邮件应用 发件人: Daniel Watford 发送时间: 2020年7月28日 20:44 收件人: dev@ofbiz.apache.org

Re: A little bit of Lombok

2020-08-26 Thread Jacques Le Roux
Thanks Daniel, From what I see in your patch, and the completing information you gave us below (thank!), I don't see much troubles (if any) to adopt Lombok, so +1 from my side Jacques Le 26/08/2020 à 10:56, Daniel Watford a écrit : Hello, A pull request [1] has been created for OFBIZ-11900

Re: A little bit of Lombok

2020-08-26 Thread Daniel Watford
Hello, A pull request [1] has been created for OFBIZ-11900 which makes use of some Lombok annotations. It is very close to the WIP branch posted in my original message to this thread. Jacques has taken a quick look but quite rightly reminded me that we didn't really conclude the Lombok discussion