Re: [OPTIONS] Java 11 and Java JDK origin

2021-02-03 Thread Suraj Khurana
Hi, +1 for jdk11. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Feb 4, 2021 at 2:30 AM Eugen Stan wrote: > +1 for jdk11. > > We can focus on jdk17 once it's out. > The transition will probably require some work. > > jdk17 is attractive though in terms of language features

Re: [OPTIONS] Java 11 and Java JDK origin

2021-02-03 Thread Eugen Stan
+1 for jdk11. We can focus on jdk17 once it's out. The transition will probably require some work. jdk17 is attractive though in terms of language features and enhancements. We could use multiple JDK's to build OFBiz . I can set this up in Jenkins or github actions with the community consent /

Re: Checkstyle pre-push hook not used when merging PR's

2021-02-03 Thread Michael Brohl
I just found that the error count in my local repository was higher because of integrated plugins so it seems the codebase is clean. To my understanding, the described gap with the missing hooks on local repositories still exists. Michael Am 03.02.21 um 17:59 schrieb Michael Brohl: Hi all,

Re: [OPTIONS] Java 11 and Java JDK origin

2021-02-03 Thread Girish Vasmatkar
I'm also inclined to go with jdk11. Best, Girish On Wed, Feb 3, 2021 at 9:58 PM Jacques Le Roux wrote: > Hi Michael, > > +1 for 11 > > Jacques > > Le 03/02/2021 à 17:20, Michael Brohl a écrit : > > Hi all, > > > > there was the idea to make the official switch to jdk11 within the next > new bra

Checkstyle pre-push hook not used when merging PR's

2021-02-03 Thread Michael Brohl
Hi all, I just noticed the following behaviour while trying to commit my work for https://issues.apache.org/jira/browse/OFBIZ-12165 . I only changed the Tomcat/Catalina version in the build.gradle file and got the following error from the checkstyle plugin: Execution failed for task ':check

Re: [OPTIONS] Java 11 and Java JDK origin

2021-02-03 Thread Jacques Le Roux
Hi Michael, +1 for 11 Jacques Le 03/02/2021 à 17:20, Michael Brohl a écrit : Hi all, there was the idea to make the official switch to jdk11 within the next new branch which possibly will be 21.x . jdk11 will be available at least until October 2024. jdk17 (LTS) will be available from Sept

Re: [OPTIONS] Java 11 and Java JDK origin

2021-02-03 Thread Michael Brohl
Hi all, there was the idea to make the official switch to jdk11 within the next new branch which possibly will be 21.x . jdk11 will be available at least until October 2024. jdk17 (LTS) will be available from September 2021 and be available until 2025 (four years). I think we should decide

Re: Blacklist and whitelist replacements

2021-02-03 Thread Jacques Le Roux
Thanks Michael, Benjamin, I'll already handle the easy cases and let "master" for now. I'll maybe do a cursory review to see if there are no problematic contexts. If course any help is welcome... TIA Jacques Le 01/02/2021 à 14:15, Michael Brohl a écrit : Do people really get offended or scar

Re: Welcome Akash Jain as new PMC member

2021-02-03 Thread Mridul Pathak
Welcome aboard Akash!! Many Congratulations!! Regards. Mridul Pathak On Thu, Jan 28, 2021 at 10:10 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Akash Jain to become member of the committee and > we are glad to announce he has accepted the nomination. > >

Re: Welcome Girish Vasmatkar as new PMC member

2021-02-03 Thread Mridul Pathak
Welcome aboard Girish!! Many Congratulations!! Regards. Mridul Pathak On Thu, Jan 28, 2021 at 10:10 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Girish Vasmatkar to become member of the > committee and we are glad to announce he has accepted the nominatio