[
https://issues.apache.org/jira/browse/OFBIZ-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005812#comment-15005812
]
Jacques Le Roux commented on OFBIZ-6477:
----------------------------------------
Hi Pierre,
I see no reasons to most of the changes in your patch, like
{code}
<xs:annotation>
- <xs:documentation>Can have multiple pipe separated values,
but don't use spaces.</xs:documentation>
+ <xs:documentation>
+ Can have multiple pipe separated values, but don't use
spaces.
+ </xs:documentation>
{code}
I prefer the current version, because
# one line in this case is OK,
# you did not indent the documentation sentence (which is not the reason I
reject those changes, one line OK is);
# and this introduces a lot of unwanted changes which uselessly blur the review!
Please simplify your patch with only functional changes
> Some XSDs needs to be cleaned-up
> --------------------------------
>
> Key: OFBIZ-6477
> URL: https://issues.apache.org/jira/browse/OFBIZ-6477
> Project: OFBiz
> Issue Type: Improvement
> Components: content, humanres, marketing, specialpurpose/projectmgr,
> specialpurpose/scrum
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: Pierre Smits
> Priority: Minor
> Attachments: OFBIZ-6477-dtd.patch
>
>
> While testing OFBIZ-6454 I found these unrelated errors in the log
> {code}
> [java] 2015-06-08 09:50:40,958 |http-bio-8443-exec-3 |UtilXml
> |E| XmlFileLoader: File
> file:/C:/projectsASF/ofbiz/applications/marketing/widget/sfa/forms/OpportunityForms.xml
> process
> error. Line: 68. Error message: cvc-complex-type.4: Attribute 'value-field'
> must appear on element 'entity-one'.
> [java] 2015-06-08 09:50:42,129 |http-bio-8443-exec-3 |UtilXml
> |E| XmlFileLoader: File
> file:/C:/projectsASF/ofbiz/specialpurpose/scrum/widget/scrumForms.xml process
> error. Line: 261.
> Error message: cvc-complex-type.4: Attribute 'value-field' must appear on
> element 'entity-one'.
> [java] 2015-06-08 09:50:49,052 |http-bio-8443-exec-3 |UtilXml
> |E| XmlFileLoader: File
> file:/C:/projectsASF/ofbiz/specialpurpose/projectmgr/widget/forms/ProjectForms.xml
> process erro
> r. Line: 855. Error message: cvc-complex-type.2.4.a: Invalid content was
> found starting with element 'auto-parameters-entity'. One of '{parameter,
> image}' is expected.
> [java] 2015-06-08 09:50:49,052 |http-bio-8443-exec-3 |UtilXml
> |E| XmlFileLoader: File
> file:/C:/projectsASF/ofbiz/specialpurpose/projectmgr/widget/forms/ProjectForms.xml
> process erro
> r. Line: 862. Error message: cvc-complex-type.2.4.a: Invalid content was
> found starting with element 'auto-parameters-entity'. One of '{parameter,
> image}' is expected.
> [java] 2015-06-08 09:50:49,052 |http-bio-8443-exec-3 |UtilXml
> |E| XmlFileLoader: File
> file:/C:/projectsASF/ofbiz/specialpurpose/projectmgr/widget/forms/ProjectForms.xml
> process erro
> r. Line: 870. Error message: cvc-complex-type.2.4.a: Invalid content was
> found starting with element 'auto-parameters-entity'. One of '{parameter,
> image}' is expected.
> [java] 2015-06-08 09:50:49,052 |http-bio-8443-exec-3 |UtilXml
> |E| XmlFileLoader: File
> file:/C:/projectsASF/ofbiz/specialpurpose/projectmgr/widget/forms/ProjectForms.xml
> process erro
> r. Line: 878. Error message: cvc-complex-type.2.4.a: Invalid content was
> found starting with element 'auto-parameters-entity'. One of '{parameter,
> image}' is expected.
> [java] 2015-06-08 09:50:49,152 |http-bio-8443-exec-3 |UtilXml
> |E| XmlFileLoader: File
> file:/C:/projectsASF/ofbiz/specialpurpose/projectmgr/widget/forms/TimeSheetForms.xml
> process er
> ror. Line: 209. Error message: cvc-complex-type.4: Attribute 'value-field'
> must appear on element 'entity-one'.
> [java] 2015-06-08 09:50:49,916 |http-bio-8443-exec-3 |UtilXml
> |E| XmlFileLoader: File
> file:/C:/projectsASF/ofbiz/applications/content/widget/content/ContentForms.xml
> process error.
> Line: 234. Error message: cvc-complex-type.4: Attribute 'value-field' must
> appear on element 'entity-one'.
> [java] 2015-06-08 09:50:50,159 |http-bio-8443-exec-3 |UtilXml
> |E| XmlFileLoader: File
> file:/C:/projectsASF/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
> proce
> ss error. Line: 220. Error message: cvc-complex-type.4: Attribute
> 'value-field' must appear on element 'entity-one'.
> [java] 2015-06-08 09:50:50,982 |http-bio-8443-exec-3 |UtilXml
> |E| XmlFileLoader: File
> file:/C:/projectsASF/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
> process er
> ror. Line: 27. Error message: cvc-complex-type.4: Attribute 'value-field'
> must appear on element 'entity-one'.
> [java] 2015-06-08 09:50:51,049 |http-bio-8443-exec-3 |UtilXml
> |E| XmlFileLoader: File
> file:/C:/projectsASF/ofbiz/applications/humanres/widget/forms/PartyQualForms.xml
> process error.
> Line: 96. Error message: cvc-complex-type.2.4.a: Invalid content was found
> starting with element 'auto-parameters-service'. One of '{parameter, image}'
> is expected.
> [java] 2015-06-08 09:50:51,087 |http-bio-8443-exec-3 |UtilXml
> |E| XmlFileLoader: File
> file:/C:/projectsASF/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
> process error.
> Line: 65. Error message: cvc-complex-type.4: Attribute 'value-field' must
> appear on element 'entity-one'.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
