[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319049#comment-15319049
]
Taher Alkhateeb commented on OFBIZ-6783:
Committed all changes in r1747288. This c
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318293#comment-15318293
]
Jacques Le Roux commented on OFBIZ-6783:
* for the port, I mean to make it more ob
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318225#comment-15318225
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacques,
I always feel extra assured
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318126#comment-15318126
]
Jacques Le Roux commented on OFBIZ-6783:
Hi Taher,
I just reviewed. For the 1st t
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316627#comment-15316627
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacopo,
Makes perfect sense. I will d
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316559#comment-15316559
]
Jacopo Cappellato commented on OFBIZ-6783:
--
Hi [~taher],
I am reviewing your las
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315834#comment-15315834
]
Gil Portenseigne commented on OFBIZ-6783:
-
Hi Taher,
Reading your code is very ple
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315734#comment-15315734
]
Jacques Le Roux commented on OFBIZ-6783:
I created OFBIZ-7192 for that
> Refactor
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315616#comment-15315616
]
Jacques Le Roux commented on OFBIZ-6783:
I did not look (yet) at the code, but you
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307303#comment-15307303
]
Taher Alkhateeb commented on OFBIZ-6783:
Okay fixed everything and committed in r1
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307297#comment-15307297
]
Jacopo Cappellato commented on OFBIZ-6783:
--
You are indeed right Taher! I didn't
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307283#comment-15307283
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacopo,
The patch you provided breaks
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307272#comment-15307272
]
Taher Alkhateeb commented on OFBIZ-6783:
Nice catch Jacopo, I always forget to do
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300267#comment-15300267
]
Jacques Le Roux commented on OFBIZ-6783:
Also note that my commit r1745451 has an
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300278#comment-15300278
]
Taher Alkhateeb commented on OFBIZ-6783:
I agree totally, things should be fixed,
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300258#comment-15300258
]
Jacques Le Roux commented on OFBIZ-6783:
Ha I never used this syntax, only the ant
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300171#comment-15300171
]
Taher Alkhateeb commented on OFBIZ-6783:
I'm a bit lost now.
First, the test case
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300118#comment-15300118
]
Jacques Le Roux commented on OFBIZ-6783:
OK I was wrong, at least in an up to date
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300103#comment-15300103
]
Jacques Le Roux commented on OFBIZ-6783:
Mmm wait, I confused, it's not the same k
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300090#comment-15300090
]
Jacques Le Roux commented on OFBIZ-6783:
This (kinda) pre-existed to your changes,
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300064#comment-15300064
]
Jacques Le Roux commented on OFBIZ-6783:
Forget this report, it's only in a WC wit
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299782#comment-15299782
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi jacques,
Is this behavior non existen
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299771#comment-15299771
]
Jacques Le Roux commented on OFBIZ-6783:
This of course in a clean up to date WC
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299683#comment-15299683
]
Jacques Le Roux commented on OFBIZ-6783:
Maybe not a big deal, but at the end of r
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298099#comment-15298099
]
Taher Alkhateeb commented on OFBIZ-6783:
Thank you Jacopo and Gil for your valuabl
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297855#comment-15297855
]
Gil Portenseigne commented on OFBIZ-6783:
-
I just did the same on ubuntu with java
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297747#comment-15297747
]
Jacopo Cappellato commented on OFBIZ-6783:
--
I have tested your last patch on a Ma
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294984#comment-15294984
]
Taher Alkhateeb commented on OFBIZ-6783:
Note:
For testing purposes and for best
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290893#comment-15290893
]
Jacques Le Roux commented on OFBIZ-6783:
Thks!
> Refactor the start component
> -
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290813#comment-15290813
]
Taher Alkhateeb commented on OFBIZ-6783:
done in r1744547.
> Refactor the start c
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290794#comment-15290794
]
Jacques Le Roux commented on OFBIZ-6783:
This would need an extra Jira, but also s
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290791#comment-15290791
]
Jacques Le Roux commented on OFBIZ-6783:
Cool, could we not have also
{code}
--tes
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290729#comment-15290729
]
Taher Alkhateeb commented on OFBIZ-6783:
Ok, committed in r1744537. The screen wid
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290687#comment-15290687
]
Jacques Le Roux commented on OFBIZ-6783:
A wider screen would help readability, bu
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290672#comment-15290672
]
Jacques Le Roux commented on OFBIZ-6783:
Thanks!
> Refactor the start component
>
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290671#comment-15290671
]
Taher Alkhateeb commented on OFBIZ-6783:
Yeah I see why you got confused by that.
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290667#comment-15290667
]
Jacques Le Roux commented on OFBIZ-6783:
Indeed, this happens also with
bq. java
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290663#comment-15290663
]
Jacques Le Roux commented on OFBIZ-6783:
Actually I was abused by this line in hel
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290661#comment-15290661
]
Taher Alkhateeb commented on OFBIZ-6783:
Also another commit in r1744528 to clarif
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290652#comment-15290652
]
Taher Alkhateeb commented on OFBIZ-6783:
Hmmm, definitely worth investigating. It
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290647#comment-15290647
]
Jacques Le Roux commented on OFBIZ-6783:
And a Ctrl+C gave me that
{code}
2016-05-
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290645#comment-15290645
]
Jacques Le Roux commented on OFBIZ-6783:
Ah indeed, anyway same with
bq. java -j
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290646#comment-15290646
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacques,
Thank you for reverting, I h
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290634#comment-15290634
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacques, I guess need to further finet
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290628#comment-15290628
]
Jacques Le Roux commented on OFBIZ-6783:
OK, I will simply revert and let you hand
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290599#comment-15290599
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacques,
This code does not look good
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290486#comment-15290486
]
Jacques Le Roux commented on OFBIZ-6783:
At revision: 1744515, I Improved the visi
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286382#comment-15286382
]
Jacques Le Roux commented on OFBIZ-6783:
Thanks for the review, fixed!
> Refactor
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286263#comment-15286263
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacques,
It's still not fully updated
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286217#comment-15286217
]
Jacques Le Roux commented on OFBIZ-6783:
Done with wiki update
> Refactor the sta
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285042#comment-15285042
]
Taher Alkhateeb commented on OFBIZ-6783:
Ding ding ding
Ladies and Gentlemen boys
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284728#comment-15284728
]
Jacques Le Roux commented on OFBIZ-6783:
OK, my bad I kept the old StartupCommand.
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284638#comment-15284638
]
Taher Alkhateeb commented on OFBIZ-6783:
oh oh oh I think I know what you mean now
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284626#comment-15284626
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacques,
When I run the following com
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284621#comment-15284621
]
Jacques Le Roux commented on OFBIZ-6783:
Sorry Tather,
Still the same issue with
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284404#comment-15284404
]
Jacques Le Roux commented on OFBIZ-6783:
Please remove this part from your patch
{
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284346#comment-15284346
]
Taher Alkhateeb commented on OFBIZ-6783:
oops, please ignore, reattaching
> Refac
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284344#comment-15284344
]
Taher Alkhateeb commented on OFBIZ-6783:
I also want to note that there is more va
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284343#comment-15284343
]
Taher Alkhateeb commented on OFBIZ-6783:
Fixed it in my latest patch. Please check
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284335#comment-15284335
]
Jacques Le Roux commented on OFBIZ-6783:
After applying the last patch and an "ant
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284265#comment-15284265
]
Pierre Smits commented on OFBIZ-6783:
-
Maybe we should consider moving the cobertura i
61 matches
Mail list logo