[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice

2016-07-15 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380473#comment-15380473 ] Taher Alkhateeb commented on OFBIZ-7749: Fantastic Michael. if all tests pass then

[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice

2016-07-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379998#comment-15379998 ] Jacques Le Roux commented on OFBIZ-7749: Hi Pierre, if you agree please close. Of

[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice

2016-07-15 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379974#comment-15379974 ] Taher Alkhateeb commented on OFBIZ-7749: Hi Pierre, In reply to your comments: T

[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice

2016-07-15 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379913#comment-15379913 ] Pierre Smits commented on OFBIZ-7749: - Yes I did - 5 days ago - and I couldn't find th

[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice

2016-07-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379877#comment-15379877 ] Jacques Le Roux commented on OFBIZ-7749: For readers, see my comment above... > i

[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice

2016-07-10 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369876#comment-15369876 ] Jacques Le Roux commented on OFBIZ-7749: Ah, I read the description too fast. I th

[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice

2016-07-10 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369868#comment-15369868 ] Jacques Le Roux commented on OFBIZ-7749: Pierre, Did you review the code? What do

[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice

2016-07-10 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369867#comment-15369867 ] Pierre Smits commented on OFBIZ-7749: - Taher created the duplicate code. Before jumpin

[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice

2016-07-10 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369586#comment-15369586 ] Jacques Le Roux commented on OFBIZ-7749: Taher created a reusable parametrized blo

[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice

2016-07-10 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369490#comment-15369490 ] Pierre Smits commented on OFBIZ-7749: - If the code for iterateOverActiveComponents is

[jira] [Commented] (OFBIZ-7749) iterateOverActiveComponents exists twice

2016-07-10 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369460#comment-15369460 ] Taher Alkhateeb commented on OFBIZ-7749: Yes we need both, one for declaring subpr