OrderChangeHelper.orderStatusChanges and OrderServices.setOrderStatus has duplicate code ----------------------------------------------------------------------------------------
Key: OFBIZ-4497 URL: https://issues.apache.org/jira/browse/OFBIZ-4497 Project: OFBiz Issue Type: Bug Reporter: Kiran Gawde Priority: Minor Both OrderChangeHelper.orderStatusChanges calls changeOrderStatus(OrderServices.setOrderStatus) and then calls the changeOrderItemStatus. OrderServices.setOrderStatus also calls the changeOrderItemStatus (which may call changeOrderStatus as well). I think, OrderChangeHelper.orderStatusChanges should be updated so that it doesn't call changeOrderItemStatus. Also, OrderServices.setOrderStatus uses hardcoded statuses. Where as OrderChangeHelper.approveOrder looks them up from store. Most places, it is hardcoded (e.g: secas.xml). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira