[ 
https://issues.apache.org/jira/browse/OFBIZ-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468083
 ] 

Al Byers commented on OFBIZ-665:
--------------------------------

I coded this up and it seems to do what I expected.

I realized that I needed to make sure that I preserve the value of the original 
service's requiredNewTransaction if one is not included in the call-service 
element. Same with transaction-timeout.

This means I need to get the ModelService to get those values. This will add 
some overhead, unless I can find a way to obtain a ServiceDispatcher at this 
point instead of a WebappDispatcher then I could run the 
ServiceDispatcher.runSync(name, cloned, map) which I would assume is more 
efficient.

> Mini-lang call-service element needs require-new-transaction attr
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-665
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-665
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Al Byers
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> I can't see why not. It is in the GenericDispatcher.runSync method. As I 
> understand the code, it lets the developer override the value set in the 
> services.xml file. There are cases where you have several service calls 
> within a simple-method and it would be nice to be able to roll them back, but 
> without this addition that would not be possible, right?
> And might as well add transaction-timeout, as well. If it defaults to 0, then 
> in ServiceDispatcher it looks like it will not set the existing 
> transactionTimeout value.
> I can make this change, but would to see if there are any objections, first.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to