Pierre,
When you review a commit you need to better read the commit comment.
https://github.com/apache/ofbiz-framework/commit/8a9596be849f6709cb17c24a598c4862e8df867c
clearly states:
<>
HTH
Jacques
Le 02/02/2022 à 18:00, Pierre Smits a écrit :
Hi Jacques,
With this commit 8a9596be849f6
Actually that was my bad to commit my local changes that helped me to get ahead.
I should have kept them local until you resolved the issue. BTW I did not
change R22.
Please do as you prefer:
* don't wait for using SDK 11, fix the issue in both using your local code w/o
reverting
* revert on
I'll not apologize either for following guidelines and practices
established, having the consensus.
Op do 3 feb. 2022 09:47 schreef Jacques Le Roux <
jacques.le.r...@les7arts.com>:
> And again (again, again, again) all depend on context. Here it's quite
> obvious that there are no labels changes,
No worries Jacques, I revert my local fix commit, you gone faster than me.
What can I do for help, to escape any collision with you ?
Nicolas
On 03/02/2022 10:02, Jacques Le Roux wrote:
> Le 03/02/2022 à 09:54, jler...@apache.org a écrit :
>> Improved: no functional change, adds a BuildBot
Le 03/02/2022 à 09:54, jler...@apache.org a écrit :
Improved: no functional change, adds a BuildBot badge (INFRA-22807)
It works locally (once you have installed Ruby, asciidoctor and
asciidoctor-diagram). CHecking that it's also OK on BuildBot, let's see
result
athttps
And again (again, again, again) all depend on context. Here it's quite obvious
that there are no labels changes, only tabs replaced by spaces.
I though agree that it should have been another commit, just that I missed that
because I automate (too?) much things.
I'll not apologize :p
Le 03/02/
I did not confirm that.
My response was targeted to the wrong assumptions that the changes were
only removes/same additions and the result of an unclean state of the
working copy.
It is generally better to separate formatting / cleanup from real
changes, which I did not mention here. For pul
Good to see that the two of you confirm that cleanup can be combined with
other improvements .
Op do 3 feb. 2022 07:15 schreef Jacques Le Roux <
jacques.le.r...@les7arts.com>:
> Yep, thanks Michael,
>
> Jacques
>
> Le 02/02/2022 à 23:33, Michael Brohl a écrit :
> > If I see it right, he has corre
Yep, thanks Michael,
Jacques
Le 02/02/2022 à 23:33, Michael Brohl a écrit :
If I see it right, he has corrected wrong indentations. Nothing wrong with
that...
Michael
Am 02.02.22 um 18:00 schrieb Pierre Smits:
Hi Jacques,
With this commit 8a9596be849f6709cb17c24a598c4862e8df867c you delet
If I see it right, he has corrected wrong indentations. Nothing wrong
with that...
Michael
Am 02.02.22 um 18:00 schrieb Pierre Smits:
Hi Jacques,
With this commit 8a9596be849f6709cb17c24a598c4862e8df867c you deleted and
reinserted a lot of german translations (without any changes in the
tran
Hi Jacques,
With this commit 8a9596be849f6709cb17c24a598c4862e8df867c you deleted and
reinserted a lot of german translations (without any changes in the
translation at first glance).
Were these necessary, or an unfortunate combination of circumstances
leading to you not working with a clean dev
Hi Michael,
Makes sense, I'll try to remember for next time
Jacques
Le 24/03/2020 à 21:14, Michael Brohl a écrit :
Hi Jacques,
the commit message is confusing, especially when you just read the headline in
the commit history. Why not simply write
"Improved: adds /uploads/ to runtime/.gitign
Hi Jacques,
the commit message is confusing, especially when you just read the
headline in the commit history. Why not simply write
"Improved: adds /uploads/ to runtime/.gitignore" ?
Thanks,
Michael
Am 24.03.20 um 18:31 schrieb jler...@apache.org:
This is an automated email from the ASF d
I have finally decided to backport this (low) security issue.
It's easy to do so, better to be safe than sorry.
Jacques
Le 20/03/2020 à 10:51, jler...@apache.org a écrit :
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository
Hi Michael,
The idea is you search it in a text editor or IDE. You can't look for
javadoc.options nor javadoc.options.links
Jacques
Le 25/02/2020 à 08:46, Michael Brohl a écrit :
Hi Jacques,
I think the comment was correct, more precise would have been
javadoc.options.links though.
Regards
Hi Jacques,
I think the comment was correct, more precise would have been
javadoc.options.links though.
Regards,
Michael Brohl
ecomify GmbH - www.ecomify.de
Am 24.02.20 um 21:50 schrieb jler...@apache.org:
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed
Ouch my fault, thanks Jacques for this fix
Nicolas
On 04/02/2020 09:45, jler...@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> jleroux pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>
>
> The fo
17 matches
Mail list logo
