Re: Common-theme next step

2017-09-26 Thread Swapnil Mane
Thank you Jacques! Done - https://issues.apache.org/jira/browse/OFBIZ-9794 - Best Regards, Swapnil M Mane On Tue, Sep 26, 2017 at 8:40 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Swapnil, > > Could you please open a Jira for your case? > > I'll double check mine and will add

Re: Common-theme next step

2017-09-26 Thread Jacques Le Roux
Hi Swapnil, Could you please open a Jira for your case? I'll double check mine and will add it also Thanks Jacques Le 26/09/2017 à 10:46, Swapnil Mane a écrit : Yes Jacques, thanks for looking into this. - Best Regards, Swapnil M Mane On Tue, Sep 26, 2017 at 2:08 PM, Jacques Le Roux < ja

Re: Common-theme next step

2017-09-26 Thread Jacques Le Roux
Le 26/09/2017 à 10:38, Jacques Le Roux a écrit : 2017-09-26 10:03:40,283 |jsse-nio-8443-exec-6 |ScreenFactory |I| Got 2 screens in 0.005s from: file:/C:/projectsASF/ofbiz/plugins/ecommerce/widget/ShoppingListScreens.xml 2017-09-26 10:03:40,578 |jsse-nio-8443-exec-6 |ScriptUtil

Re: Common-theme next step

2017-09-26 Thread Swapnil Mane
Yes Jacques, thanks for looking into this. - Best Regards, Swapnil M Mane On Tue, Sep 26, 2017 at 2:08 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Swapnil, All, > > This is a real problem, I just crossed it also with > > 2017-09-26 10:03:34,730 |jsse-nio-8443-exec-6 > |Servi

Re: Common-theme next step

2017-09-26 Thread Jacques Le Roux
Hi Swapnil, All, This is a real problem, I just crossed it also with 2017-09-26 10:03:34,730 |jsse-nio-8443-exec-6 |ServiceDispatcher |T| [[ASync service failed...- total:0.004,since last(ASync service sta...):0.004]] - 'ecommerce / sendOrderConfirmation' 2017-09-26 10:03:34,730 |j

Re: Common-theme next step

2017-09-23 Thread Swapnil Mane
Thanks Jacques for your timings and suggestion. @SuppressWarnings("serial") doesn't work for me. = Console Log start = 2017-09-23 14:38:25,610 |jsse-nio-8443-exec-8 |ServiceDispatcher |T| [[ASync service started...- total:0.0,since last(Begin):0.0]] - 'manufacturing /

Re: Common-theme next step

2017-09-23 Thread Jacques Le Roux
Hi Swapnil, Did you try? @SuppressWarnings("serial") public final class VisualTheme implements Serializable { Jacques Le 23/09/2017 à 08:29, Swapnil Mane a écrit : Thank you Nicolas and team for this great work. Highly appreciated!! I am facing some Exception related to VisualTheme while ru

Re: Common-theme next step

2017-09-22 Thread Swapnil Mane
Thank you Nicolas and team for this great work. Highly appreciated!! I am facing some Exception related to VisualTheme while running the MRP. https://demo-trunk.ofbiz.apache.org/manufacturing/control/RunMrp I guess it is related to theme work we have done, please let me know, if I am missing anyt

Re: Common-theme next step

2017-09-10 Thread Michael Brohl
Thank you, Nicolas, for the great effort you put on this. I'll hope to soon reactivate my work on the bootstrap theme, using the new structure, and see how it will work out. I'll have some more qualified feedback (and propably questions ;-) ) then... Thanks, Michael Am 25.08.17 um 12:15 sc

Re: Common-theme next step

2017-08-25 Thread Nicolas Malin
:) thanks Deepak for your support you fill my weaknesses. Nicolas Le 25/08/2017 à 20:31, Deepak Dixit a écrit : Thanks Nicolas for your effort. I confirm that above reported warning has been fixed. I found some more console warning related to xml schema validation, those has been fixed at r# 18

Re: Common-theme next step

2017-08-25 Thread Deepak Dixit
Thanks Nicolas for your effort. I confirm that above reported warning has been fixed. I found some more console warning related to xml schema validation, those has been fixed at r# 1806206, 1806209, 1806211 Also updated the site xsd at r#1806208 and r#1806210 Thanks & Regards -- Deepak Dixit www

Re: Common-theme next step

2017-08-25 Thread Nicolas Malin
Le 25/08/2017 à 14:34, Nicolas Malin a écrit : Yes I detected it during my work, but I supposed to push the theme dtd on the website will be solve it. Else I will complete my knowledge with this mistake :) Ok it's a mistake, idea help me to resolve this issue because I not understand all. Commi

Re: Common-theme next step

2017-08-25 Thread Taher Alkhateeb
I wanted to thank you again for this work Nicolas. Hopefully with a little more time and refinement we can purge all "web" stuff outside the framework and make it a pure DSL infrastructure independent of the output technology. This also opens the door for selecting front end technology stacks witho

Re: Common-theme next step

2017-08-25 Thread Nicolas Malin
Hello Le 25/08/2017 à 12:54, Deepak Dixit a écrit : Thanks Nicolas, Nice work. Thanks Deepak, in line I noticed some console warning while data load {quote} 2017-08-25 16:14:37,945 |main |UtilXml |E| XmlFileLoader: File file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/blu

Re: Common-theme next step

2017-08-25 Thread Deepak Dixit
Thanks Nicolas, Nice work. I noticed some console warning while data load {quote} 2017-08-25 16:14:37,945 |main |UtilXml |E| XmlFileLoader: File file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight/widget/Theme.xml process error. Line: 20. Error message: TargetNamespace.2

Re: Common-theme next step

2017-08-25 Thread Nicolas Malin
I loaded all my local :) Le 25/08/2017 à 00:03, Nicolas Malin a écrit : I started to load common-theme on trunk, at this time to resume : r1806075, r1806076 : I loaded engine and documentation r1806084 : I moved all images folder to common-theme r1806091, r1806093: I moved all ftl template from

Re: Common-theme next step

2017-08-24 Thread Nicolas Malin
I started to load common-theme on trunk, at this time to resume : r1806075, r1806076 : I loaded engine and documentation r1806084 : I moved all images folder to common-theme r1806091, r1806093: I moved all ftl template from common to common-theme and all macro ftl libraries. I hope to break no

Re: Common-theme next step

2017-08-22 Thread Nicolas Malin
Hi Taher, If you have few time to have a look on these three class : https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelTheme.java https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java

Re: Common-theme next step

2017-08-21 Thread Taher Alkhateeb
Hi Nicolas, If it helps you, I suggest to isolate files / code where you are not very comfortable and put them in a separate patch (not the full patch) with an explanation of what you've done and where you feel a little hesitant or uneasy. I think if you make us focus with you on very specific pie

Re: Common-theme next step

2017-08-21 Thread Jacques Le Roux
Thanks Nicolas, Looking forward Jacques Le 21/08/2017 à 09:55, Nicolas Malin a écrit : Thanks, I will commit on trunk after a second review of my code because i was concentrated to increase the flexibility with macro and screen but not manage correctly the VisualTheme concept. So I will ta

Re: Common-theme next step

2017-08-21 Thread Nicolas Malin
Thanks, I will commit on trunk after a second review of my code because i was concentrated to increase the flexibility with macro and screen but not manage correctly the VisualTheme concept. So I will take care about this, complete the documentation and commit on trunk. Nicolas Le 19/08/2

Re: Common-theme next step

2017-08-19 Thread Taher Alkhateeb
Like Michael, I also prefer to include the work into the code base and test it over there. It seems like you put a lot of effort into this code so thank you! I like the fact that you brought all the artifacts into the theme along with the FTL macros. This is a good first step, and I believe continu

Re: Common-theme next step

2017-08-17 Thread Jacques Le Roux
That sounds great, Thanks Nicolas! Jacques Le 17/08/2017 à 22:00, Nicolas Malin a écrit : Hello, I started the documentation here https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md It's a begging, I hope improve it quickly Nicolas Le 16/08/2017 à 13:49, Nicolas

Re: Common-theme next step

2017-08-17 Thread Nicolas Malin
Hello, I started the documentation here https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md It's a begging, I hope improve it quickly Nicolas Le 16/08/2017 à 13:49, Nicolas Malin a écrit : Hello; To continue the common-theme subject, I haven't see negative return

Re: Common-theme next step

2017-08-17 Thread Nicolas Malin
Hi Michael, Le 17/08/2017 à 10:44, Michael Brohl a écrit : Hi Nicolas, thank you very much for your ongoing work on this topic, I greatly appreciate it :-) :) thanks, you escape me from the loneliness I'm looking forward to have a deeper look into your solutions but have to wait until my r

Re: common-theme questions, was: Re: Common-theme next step

2017-08-17 Thread Nicolas Malin
Hello Michael Nice questions :) in line Le 17/08/2017 à 11:06, Michael Brohl a écrit : Hi Nicolas, During my work on the bootstrap theme [1] (which got stuck due to other tasks) I stumbled upon some problems which possibly get solved by your approach or we can consider a solution for it duri

common-theme questions, was: Re: Common-theme next step

2017-08-17 Thread Michael Brohl
Hi Nicolas, During my work on the bootstrap theme [1] (which got stuck due to other tasks) I stumbled upon some problems which possibly get solved by your approach or we can consider a solution for it during the work. In detail, I'm referring to [2] where you had the same problem I'm facing:

Re: Common-theme next step

2017-08-17 Thread Michael Brohl
Hi Nicolas, thank you very much for your ongoing work on this topic, I greatly appreciate it :-) I'm looking forward to have a deeper look into your solutions but have to wait until my return on end of August. The concept, as I understand it, provides an extendable mechanism to build themes

Common-theme next step

2017-08-16 Thread Nicolas Malin
Hello; To continue the common-theme subject, I haven't see negative return to the issue Create a common theme (OFBIZ-9138) [1] and on threads on the same subject [2] and the additional theme xml definition [3], I suggest to create a documentation on the wiki how work the "theme engine" and co