Adrian Crum-2 wrote:
>
> --- On Wed, 11/26/08, David E Jones <[EMAIL PROTECTED]> wrote:
>> Do you have any specific bits of messy code in mind? I
>> don't mean to imply that I don't believe this might
>> help, but how does moving the code from one class to another
>> clean up the code?
>
> I d
From: "David E Jones" <[EMAIL PROTECTED]>
On Nov 27, 2008, at 10:52 AM, Adrian Crum wrote:
3. Convert the existing artifact gathering code to a
screen widget visitor. That would get the artifact gathering
code out of the model widgets and put it where it belongs.
It would probably simplify t
helf
and come back to it again later.
-Adrian
--- On Thu, 11/27/08, David E Jones <[EMAIL PROTECTED]> wrote:
From: David E Jones <[EMAIL PROTECTED]>
Subject: Re: Discussion: Screen Widget Java Code Cleanup
To: dev@ofbiz.apache.org
Date: Thursday, November 27, 2008, 12:54 PM
On N
Okay, we have a design philosophy difference. I'll put this back on the shelf
and come back to it again later.
-Adrian
--- On Thu, 11/27/08, David E Jones <[EMAIL PROTECTED]> wrote:
> From: David E Jones <[EMAIL PROTECTED]>
> Subject: Re: Discussion: Screen Widget Java
On Nov 27, 2008, at 10:52 AM, Adrian Crum wrote:
--- On Wed, 11/26/08, David E Jones <[EMAIL PROTECTED]>
wrote:
Do you have any specific bits of messy code in mind? I
don't mean to imply that I don't believe this might
help, but how does moving the code from one class to another
clean up the
--- On Wed, 11/26/08, David E Jones <[EMAIL PROTECTED]> wrote:
> Do you have any specific bits of messy code in mind? I
> don't mean to imply that I don't believe this might
> help, but how does moving the code from one class to another
> clean up the code?
I didn't want to go into specifics becau
i <[EMAIL PROTECTED]>
> Subject: Re: Discussion: Screen Widget Java Code Cleanup
> To: dev@ofbiz.apache.org
> Date: Wednesday, November 26, 2008, 11:51 PM
> My understand is that the value of visitor is: have simple
> data structures and code/attach what is done on the data
> s
My understand is that the value of visitor is: have simple data
structures and code/attach what is done on the data structure using
visitors.
This may seem odd given that one should have operations close to data
structure but it turns out very useful esp. if there are classes of
operations do
On Nov 26, 2008, at 9:05 PM, Adrian Crum wrote:
I would like to work on cleaning up the screen widget Java code.
Here are some of my ideas:
1. The screen widget model classes are trying to be too many things.
As a result, they contain some messy and scary code. I'd like to see
the model
http://en.wikipedia.org/wiki/Visitor_pattern
--- On Wed, 11/26/08, BJ Freeman <[EMAIL PROTECTED]> wrote:
> From: BJ Freeman <[EMAIL PROTECTED]>
> Subject: Re: Discussion: Screen Widget Java Code Cleanup
> To: dev@ofbiz.apache.org
> Date: Wednesday, November 26, 2008, 6:
where can I find out about the visitor model
Adrian Crum sent the following on 11/26/2008 6:05 PM:
> I would like to work on cleaning up the screen widget Java code. Here are
> some of my ideas:
>
> 1. The screen widget model classes are trying to be too many things. As a
> result, they contain
I would like to work on cleaning up the screen widget Java code. Here are some
of my ideas:
1. The screen widget model classes are trying to be too many things. As a
result, they contain some messy and scary code. I'd like to see the model
widget become more of a data structure, and move the re
12 matches
Mail list logo
