This has been committed at rev:1767764. I have also verified application by
accessing different screens of components.
Please let me know if you find any issue regarding this change.
--
Thanks & Regards
---
Arun Patidar
Manager,Enterprise Software Development
HotWax Mediawww.hotwaxsystems.com
Thank you very much Jacques.
Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
On Wed, Nov 2, 2016 at 4:55 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> Hi Rishi,
>
> No need to do it by hand. I did
Hi Rishi,
No need to do it by hand. I did it with regexp S/R in Eclipse and have updated
the patch at OFBIZ-8652, please check
Thanks
Jacques
Le 02/11/2016 à 09:18, Rishi Solanki a écrit :
Yes we have noticed some semicolons, and it seems we need to replace them
manually. Because in all gro
Yes we have noticed some semicolons, and it seems we need to replace them
manually. Because in all groovy files we have seen the semicolon in the
lincense text as well.
Thank you for your help Jacques :-)
Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-
Hi Rishi,
It's not the first time we change a *simple thing* in all the source. I can
live with that, you seem well organised :)
BTW after appling the patch at OFBIZ-8652 I still find 57 trailing semicolons :)
Thanks
Jacques
Le 01/11/2016 à 07:35, Rishi Solanki a écrit :
Jacques,
Yes we w
Jacques,
Yes we would like to commit it as whole, but before commit for the same we
have plan to test each component after applying the changes. Like browse to
most pages and general work flows. We will post the updates on ticket
something like;
Test the party component;
Pages/Work Flow tested: F
Hi Rishi,
Will you commit as a whole?
Jacques
Le 28/10/2016 à 12:07, Rishi Solanki a écrit :
Started effort under - https://issues.apache.org/jira/browse/OFBIZ-8652
Thanks to Rohit Kaushal for taking care of this. It will take 4-5 days for
testing.
Thanks!
Rishi Solanki
Manager, Enterpris
Started effort under - https://issues.apache.org/jira/browse/OFBIZ-8652
Thanks to Rohit Kaushal for taking care of this. It will take 4-5 days for
testing.
Thanks!
Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
Personally I will go this way: I will add or changes lines without putting
semicolons.
I'm in favour of bulk changing files, but I'd prefer by component or webapp to
ease reviews.
Jacques
Le 16/09/2016 à 15:36, Rishi Solanki a écrit :
I was saying #2 as per the comment from Taher
Quic
I was saying #2 as per the comment from Taher
Quick Reference:
One reply from Taher ... in the same thread.
==
Okay, given the priorities and work we have at the moment, I suggest we
keep semicolons and use it as the standard unless someone volunteers to
make a full switch. WDYT?
==
I guess you mean 2) by file, then it's OK with me. Though I'd no be against having semicolon inconsistency in Groovy files, which was my initial
question. So no strong opinion about 2 here.
Jacques
Le 16/09/2016 à 11:31, Rishi Solanki a écrit :
To summarize the overall conversation;
1) We hav
To summarize the overall conversation;
1) We have decided to bulk remove semicolons from groovy.
2) Until #1 is not complete, we would keep adding semicolon for consistency.
Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxs
Actually I was wrong on this. Thanks to Jacopo I noticed that both Subclipse and Tortoise allow you to select a range of revisions when you look for
annotations.
So it's no longer an issue for me and we can bulk remove trailing semicolons
in Groovy files if we want.
Sorry for the confusion
J
I don't particularly care one way or another if groovy files have a
semi-colon at the end. I don't even care about consistency because it is
such a minor thing.
I say remove them if they're on a line you happen to be editing, otherwise
just leave them be.
Regarding the annotations, there's plent
Le 13/09/2016 à 21:28, Jacques Le Roux a écrit :
OK found that the same than in Subclipse also exists in TortoiseSVN
But you need to use a command line (weird for a GUI), eg (from TortoiseSVN root
folder)
Actually wrong, simply pick a file in Windows file explorer using TortoiseSVN
context
OK found that the same than in Subclipse also exists in TortoiseSVN
But you need to use a command line (weird for a GUI), eg (from TortoiseSVN root
folder)
TortoiseProc.exe /command:blame
/path:"C:\projectASF-Mars\ofbiz\applications\product\src\main\java\org\apache\ofbiz\product\catalog\Catalo
Le 13/09/2016 à 17:06, Rishi Solanki a écrit :
Agreed on the fact that its an pain to backport the bug fixes to releases.
Especially when we have to change something manually and it has been done
with many files in last few months i.e bulk changes with all files of xType.
I'm not sure, but what
BTW thinking about it, don't you have something similar in IntellIJ?
I found an (old) image there
https://markphip.blogspot.fr/2006/12/subclipse-live-annotations.html
Jacques
Le 13/09/2016 à 20:16, Jacques Le Roux a écrit :
Thanks Jacopo,
I found how to use it in TortoiseSVN (it starts from
Thanks Jacopo,
I found how to use it in TortoiseSVN (it starts from the log view)
It's complementary to what Subclipse gives and so interesting but not
comparable.
You don't have this global view Subclipse offers with each annotation by line
from start (r1) to HEAD.
Very useful with colored an
Some examples:
svn blame README.md
after review you run
svn blame README.md -r 1:1757044
and then
svn blame README.md -r 1:1757042
and so on to get back in history... nothing is lost, annotations are always
there.
Jacopo
PS: I think there is some trick to do the same with TortoiseSVN but I
Le 13/09/2016 à 16:45, Jacopo Cappellato a écrit :
On Tue, Sep 13, 2016 at 4:36 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
...
Before applying a such change, I'd really like to know if everybody is
aware of what that means when it comes to svn annotations. I repeat: we
will then
Agreed on the fact that its an pain to backport the bug fixes to releases.
Especially when we have to change something manually and it has been done
with many files in last few months i.e bulk changes with all files of xType.
I'm not sure, but what is the good time to do such changes (may be just
Sorry, I started this thread by asking this question:
>While committing r1760406 I wondered if I should really put semicolons at end
of Groovy files lines.
>We know it's useless in Groovy. Should we continue to put them, and if yes for
which reasons?
The question switched to "should we remove
On Tue, Sep 13, 2016 at 4:36 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> ...
> Before applying a such change, I'd really like to know if everybody is
> aware of what that means when it comes to svn annotations. I repeat: we
> will then lose all the svn annotations history in all t
Thanks, Rishi!
Am 13.09.16 um 15:10 schrieb Rishi Solanki:
+1 Taher, until we will have complete switch to pure groovy we should keep
the semicolon as practice.
+1 Michael, for migrating to pure Groovy.
We would try to assign dev for it and log Jira ticket accordingly.
Rishi Solanki
Manager, E
+1 Taher, until we will have complete switch to pure groovy we should keep
the semicolon as practice.
+1 Michael, for migrating to pure Groovy.
We would try to assign dev for it and log Jira ticket accordingly.
Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct
+1
Michael
Am 13.09.16 um 14:58 schrieb Taher Alkhateeb:
Okay, given the priorities and work we have at the moment, I suggest we
keep semicolons and use it as the standard unless someone volunteers to
make a full switch. WDYT?
On Tue, Sep 13, 2016 at 3:52 PM, Jacopo Cappellato <
jacopo.cappell
Okay, given the priorities and work we have at the moment, I suggest we
keep semicolons and use it as the standard unless someone volunteers to
make a full switch. WDYT?
On Tue, Sep 13, 2016 at 3:52 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:
> I agree with Rishi's remarks
Good point, I hadn't thought of that!
So if we find a volunteer I would be for 1. (migrating to pure Groovy).
Michael
Am 13.09.16 um 14:52 schrieb Jacopo Cappellato:
I agree with Rishi's remarks: also, if we follow this approach then
functional changes will be buried in a bunch of non-function
I agree with Rishi's remarks: also, if we follow this approach then
functional changes will be buried in a bunch of non-functional changes.
This could work if the two are committed into two separate commits.
Jacopo
On Tue, Sep 13, 2016 at 2:45 PM, Rishi Solanki
wrote:
> Fix as you edit, this is
Fix as you edit, this is something like we are working on X functionality
and to achieve that functionality if we want to edit an groovy file, then
we will also remove/add semicolon to it.
If I'm understanding it correctly, then -1 for it. As we have to ask
explicitly to every contributor/committe
Yup +1 for option 3, fix as you edit
On Sep 13, 2016 1:16 PM, "Jacques Le Roux"
wrote:
> Le 13/09/2016 à 11:56, Michael Brohl a écrit :
>
>> Same here. I'm not even sure if we really have clean groovy in the
>> project, I assume it is mixed up with Java code in some areas.
>>
>> But I agree to h
Le 13/09/2016 à 11:56, Michael Brohl a écrit :
Same here. I'm not even sure if we really have clean groovy in the project, I
assume it is mixed up with Java code in some areas.
But I agree to have a consistent style and we should use the Groovy language as it shoul be used (even if I would have
Same here. I'm not even sure if we really have clean groovy in the
project, I assume it is mixed up with Java code in some areas.
But I agree to have a consistent style and we should use the Groovy
language as it shoul be used (even if I would have get used to it and
like a a defined code lin
Le 13/09/2016 à 11:34, Scott Gray a écrit :
I don't want to remove existing ones (easy done in one shoot with a S/R
regexp) because it would remove the precious svn annotations (when you want
to look for reasons in the past)
Hi Jacques,
What are these precious svn annotations used for? Maybe
>
> I don't want to remove existing ones (easy done in one shoot with a S/R
> regexp) because it would remove the precious svn annotations (when you want
> to look for reasons in the past)
Hi Jacques,
What are these precious svn annotations used for? Maybe I'm out of the
loop since I use git-sv
Le 13/09/2016 à 08:40, Jacques Le Roux a écrit :
Thank you Rishi for the link to https://cwiki.apache.org/confluence/display/OFBIZ/Tips+and+Tricks+while+working+with+Groovy I did not remember of
it. I changed the title to make the URL easier to read
Jacques
BTW the Beanshell references shoul
I was talking about consistency from now on; I was not suggesting to bulk
change everything.
Jacopo
On Tue, Sep 13, 2016 at 8:40 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> Hi,
>
> Wait, I did not ask to remove them. I simply asked "Should we continue to
> put them, and if yes f
Okay I missed the historical context.
Like Jacopo I also do not have a strong opinion, if it is easier and faster
to keep them, then keep them. The important thing is to take a direction
and stay with it.
On Sep 13, 2016 9:40 AM, "Jacques Le Roux"
wrote:
Hi,
Wait, I did not ask to remove them.
Other link to keep in mind is about groovy DSL where no semicolumn are
present in code samples :
https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic
If there is no performance consequences with not using semicolumn, i'm
ok with it.
Gil
Le 13/09/2016 à 08:40
Hi,
Wait, I did not ask to remove them. I simply asked "Should we continue to put them,
and if yes for which reasons? "
I don't want to remove existing ones (easy done in one shoot with a S/R regexp) because it would remove the precious svn annotations (when you want to
look for reasons in the
Jacopo,
I could recall after your reply, the semicolon kept in the groovy files for
consistency only no other reason. Also, if we decide to remove it, then
only thing we should consider if somewhere semicolon used as separator.
Thanks!
--
Rishi
Rishi Solanki
Manager, Enterprise Software Develop
I don't have a strong opinion. But it would be nice to agreed upon one
style and then implement consistently.
Jacopo
On Mon, Sep 12, 2016 at 6:56 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> Hi
>
> While committing r1760406 I wondered if I should really put semicolons at
> end o
I remember the conversion of bsh to groovy was big one, and at that time in
a conversation decided to keep the semicolon as is. For code consistency
and for java based user of OFBiz. Even bsh/groovy help java based users to
develop/understand OFBiz better.
I tried but could not find the reference
Agreed, I think it is better to remove semicolons for groovy files. In fact
our gradle scripts do not have semicolons. Perhaps people put them there
out of habit.
On Sep 12, 2016 7:56 PM, "Jacques Le Roux"
wrote:
> Hi
>
> While committing r1760406 I wondered if I should really put semicolons at
Hi
While committing r1760406 I wondered if I should really put semicolons at end
of Groovy files lines.
We know it's useless in Groovy. Should we continue to put them, and if yes for
which reasons?
Thanks
Jacques
46 matches
Mail list logo