Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-20 Thread Nicolas Malin
Hi, I agree with Scott, I check your code and I see no reason to don't commit it Nicolas Le 20/06/2017 à 07:47, Scott Gray a écrit : Hi Taher, The jira summary of changes sounds like a re-organization without any (intentional) changes in functionality. Personally I would just go ahead and

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-20 Thread Jacques Le Roux
Hi Taher, I'll try to have a look today. Jacques Le 19/06/2017 à 23:13, Taher Alkhateeb a écrit : Hey Folks. I know everyone's probably preoccupied. It would be great to get some feedback on OFBIZ-9392 though given how critical this piece of code is. I'd feel much better about committing after

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-19 Thread Scott Gray
Hi Taher, The jira summary of changes sounds like a re-organization without any (intentional) changes in functionality. Personally I would just go ahead and commit it. Regards Scott On 20 June 2017 at 09:13, Taher Alkhateeb wrote: > Hey Folks. I know everyone's probably preoccupied. It would

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-19 Thread Taher Alkhateeb
Hey Folks. I know everyone's probably preoccupied. It would be great to get some feedback on OFBIZ-9392 though given how critical this piece of code is. I'd feel much better about committing after a few reviews. On Thu, Jun 15, 2017 at 9:22 PM, Taher Alkhateeb wrote: > Hi Michael, > > I think mo

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-15 Thread Taher Alkhateeb
Hi Michael, I think most of our documentation is outdated. So your best bet is [1]. I look forward to your feedback. @Scott you seem to have good experience with clustering, It would be really great if we can have your eyes on the code or some testing of the functionality. [1] https://tomcat.apa

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-14 Thread Michael Brohl
Hi Taher, Am 14.06.17 um 19:56 schrieb Taher Alkhateeb: Okay, after a little bit of investigation I think I got what caused the crashes on my machine: - I removed "cluster.registerManager(manager);" from the code base because it was commented out in the original code base That explains why I d

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-14 Thread Taher Alkhateeb
Okay, after a little bit of investigation I think I got what caused the crashes on my machine: - I removed "cluster.registerManager(manager);" from the code base because it was commented out in the original code base - I commented out "" from ofbiz-component.xml because it was conflicting with my l

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-12 Thread Taher Alkhateeb
So the good thing is that the refactoring exercise surfaced this issue. Based on feedback from Scott and Michael I suspect that the issue might be perhaps minor such as a missing configuration or dependency that's causing all these errors. I'll try to dig out the root cause and your help would be

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-12 Thread Scott Gray
The project I'm currently on is actively using clustering (session replication) and I know for certain this isn't the only project nor are we the only vendor to use it. I'm using an older version of OFBiz though so I can't confirm if the latest codebase has it working. It can be tricky to set up

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-12 Thread Michael Brohl
No, I cannot find it. But there's no error in reference to a missing manager class so I guess it's not a problem. If I can solve the address problem, I'll see further. Thanks and good night, Michael Am 13.06.17 um 01:51 schrieb Taher Alkhateeb: All dependencies are stored in the gradle cach

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-12 Thread Taher Alkhateeb
All dependencies are stored in the gradle cache and referenced in the generated ofbiz.jar. So I guess it's somewhere in the cache. Can't you find it there? On Jun 13, 2017 2:49 AM, "Michael Brohl" wrote: Where would you expect the jar file to be stored? I'll try to track down the errors. I was

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-12 Thread Michael Brohl
Where would you expect the jar file to be stored? I'll try to track down the errors. I was able to reduce the error messages by adding -Djava.net.preferIPv4Stack=true to the jvm arguments in build.gradle def jvmArguments = ['-Xms128M', '-Xmx1024M', "-Djava.net.preferIPv4Stack=true"] (see

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-12 Thread Taher Alkhateeb
A compile dependency is also a runtime dependency in gradle (as opposed to compileOnly). So if it is defined in gradle then it is available in runtime. On Jun 13, 2017 1:57 AM, "Michael Brohl" wrote: Quick checked the cluster config and see that the cluster configuration depends on org.apache.c

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-12 Thread Michael Brohl
Quick checked the cluster config and see that the cluster configuration depends on org.apache.catalina.ha.session.DeltaManager, whose package is configured in Gradle as a compile dependency (org.apache.tomcat:tomcat-catalina-ha:8.5.15). Do you have this package/jar available at runtime? I can

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-12 Thread Taher Alkhateeb
Hi Michael, Hmmm, I didn't know that it is actively used. Essentially, you get exceptions / crashes when you uncomment the clustering section in catalina's ofbiz-component.xml. Also, I could be wrong, but I thought instead of using Tomcat's clustering, you instead cluster your infrastructure

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-12 Thread Michael Brohl
Hi Taher, clustering support is an important feature for enterprise installations and it worked in the past. It should be fixed if it is broken. What makes you think that clustering is broken? How did you test it? What is not working exactly? I recently updated the Tomcat version, could thi

Re: Help in reviewing my refactoring of CatalinaContainer

2017-06-12 Thread Taher Alkhateeb
Hi Everyone, In reference to [1] and the refactoring work, and after multiple different tests, I came to realize that Tomcat clustering implementation is broken (both before and after the refactoring). The reasons are complex but they essentially have to do with setting up the right parameters for

Help in reviewing my refactoring of CatalinaContainer

2017-06-08 Thread Taher Alkhateeb
Hey folks, It was very painful and slow, but I finally got a working almost full-rewrite of the CatalinaContainer. I need help with testing, reviews, and code improvements. Details are found in [1]. There are no functional changes, just a rewrite. I appreciate all the help and feedback. [1] http