Re: Possible auth issue in the createPartyAndUserLogin service

2007-02-09 Thread Jacopo Cappellato
Great, I've committed it in rev. 505482 Thanks, Jacopo David E. Jones wrote: I don't think there will be any problem from such a side effect. It's good that you brought it up, but I'd be really surprised if there was code anywhere that depended on this quirk, as it is a bit funny in the f

Re: Possible auth issue in the createPartyAndUserLogin service

2007-02-09 Thread David E. Jones
I don't think there will be any problem from such a side effect. It's good that you brought it up, but I'd be really surprised if there was code anywhere that depended on this quirk, as it is a bit funny in the first place, and most services (well, simple-methods anyway) don't do a lot wi

Re: Possible auth issue in the createPartyAndUserLogin service

2007-02-07 Thread Jacopo Cappellato
David, I can actually commit the patch #2 without problem; I'm just worried about the side effects (if any) that this could cause on the existing code. For example, I don't know if the set-service-fields operation is copying also the user login from one map to another one; if this is happenin

Re: Possible auth issue in the createPartyAndUserLogin service

2007-02-07 Thread David E. Jones
Sorry for the delay on this Jacopo. Looking at this I actually like the fix in #2, ie changing the simple- method operations because what they do doesn't make sense. In other words, if you add a userLogin yourself you wouldn't expect the system to blow it away. If you agree feel free to c

Re: Possible auth issue in the createPartyAndUserLogin service

2007-02-07 Thread Jacopo Cappellato
Ah, forgot to mention that I'd vote for solution #1. Jacopo Jacopo Cappellato wrote: Should we take some action about this subject? I know that probably my explanations were not clear enough, so I'm proposing the two ways of fixing what I think it's an outstanding issue; I hope that, review

Re: Possible auth issue in the createPartyAndUserLogin service

2007-02-07 Thread Jacopo Cappellato
Should we take some action about this subject? I know that probably my explanations were not clear enough, so I'm proposing the two ways of fixing what I think it's an outstanding issue; I hope that, reviewing the (extremely simple) fixes I'm proposing will be easier to understand the issue I'

Re: Possible auth issue in the createPartyAndUserLogin service

2007-01-26 Thread Jacopo Cappellato
David, I really did not describe it very well, sorry. I don't think there is a problem with the createUserLogin service definition or implementation. The issue (maybe) could be the way the framework handles the minilang attribute include-user-login="true": it just gets the "userLogin" object f

Re: Possible auth issue in the createPartyAndUserLogin service

2007-01-26 Thread David E. Jones
On Jan 25, 2007, at 7:41 AM, Jacopo Cappellato wrote: Hi all, could you have a look at the attached simple patch? It fixes an authorization problem under some special situations (switching from anonymous user to authenticated one...); however the issue is that, when the "createUserLogin"

Re: Possible auth issue in the createPartyAndUserLogin service

2007-01-25 Thread Jacques Le Roux
Sent: Thursday, January 25, 2007 3:41 PM Subject: Possible auth issue in the createPartyAndUserLogin service > Hi all, > > could you have a look at the attached simple patch? It fixes an > authorization problem under some special situations (switching from > anonymous user to authentic

Re: Possible auth issue in the createPartyAndUserLogin service

2007-01-25 Thread Andrew Sykes
Jacopo, I run into something like this recently, it started me thinking, that perhaps it would be useful to have an attribute along the lines of run- as-system="true/false" Would be interested to hear peoples thoughts, even if only for my own didactic purposes! - Andrew On Thu, 2007-01-25 at 09

Possible auth issue in the createPartyAndUserLogin service

2007-01-25 Thread Jacopo Cappellato
Hi all, could you have a look at the attached simple patch? It fixes an authorization problem under some special situations (switching from anonymous user to authenticated one...); however the issue is that, when the "createUserLogin" is called, if the attribute include-user-login is not set