Hi Sascha,
I can't confirm you if that this issue also occurred in the branch!
But, I can confirm that this issue occur in trunk.
As Marco said in last previous email you you can replicate this issue on the
trunk:
1. removing the following directory "framework\sql\build\gen-src\javacc"
2.
Hi Sascha,
you mean that it's fixed on the trunk?
Becouse I still have the same problem on the trunk (release 1089027).
Regards,
Felice.
2011/3/10 Sascha Rodekamp
> Hi Erwan,
> it is fixed, Seem that there was the javacc.jar corrupted during the commit
> last night. I think that's regarded to
Hi Erwan,
it is fixed, Seem that there was the javacc.jar corrupted during the commit
last night. I think that's regarded to this *** wlan connection here in the
hotel :-) Whatever it works now ;-)
Cheers
Sascha
2011/3/10 Erwan de FERRIERES
> Le 10/03/2011 15:27, mrisal...@libero.it a écrit :
Le 10/03/2011 15:27, mrisal...@libero.it a écrit :
Hi erwan,
is it probably due to the upgrade I have done in the trunk of javacc.jar
(version 5.0).
Did you try to remove the following directory:
- framework\sql\build\gen-src\javacc
- framework\base\build\gen-src\javacc
execute an ant clean /
Hi erwan,
is it probably due to the upgrade I have done in the trunk of javacc.jar
(version 5.0).
Did you try to remove the following directory:
- framework\sql\build\gen-src\javacc
- framework\base\build\gen-src\javacc
execute an ant clean / ant build.
If it's not working something has been n
completed
and everything can be corrected/improved !!!
Thanks for the suggestions
Marco
Messaggio originale
Da: adrian.c...@sandglass-software.com
Data: 08/02/2011 14.59
A:
Ogg: Re: R: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
You
>>> and everything can be corrected/improved !!!
>>> Thanks for the suggestions
>>> Marco
>>>> Messaggio originale
>>>> Da: adrian.c...@sandglass-software.com
>>>> Data: 08/02/2011 14.59
>>>> A:
>>>>
ove the private method that is not been
used.
Please keep in mind that is a very huge job to me and it's still not
completed
and everything can be corrected/improved !!!
Thanks for the suggestions
Marco
Messaggio originale
Da: adrian.c...@sandglass-software.com
Data: 08/02/2011 14.5
aggio originale
Da: adrian.c...@sandglass-software.com
Data: 08/02/2011 14.59
A:
Ogg: Re: R: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
You fix an unused method/variable by removing it. But leave the warning
in the unit tests - some
Hi Scott,
agreed I will try to reduce at minimum the use of FIXME in case of unused
variable but sometimes it's not easy to understand if it's correct to remove it
or not.
Thanks
Marco
>Messaggio originale
>Da: scott.g...@hotwaxmedia.com
>Data: 08/02/2011 12.57
&
a: adrian.c...@sandglass-software.com
>Data: 08/02/2011 14.59
>A:
>Ogg: Re: R: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
>
>You fix an unused method/variable by removing it. But leave the warning
>in the unit tests - sometimes thos
You fix an unused method/variable by removing it. But leave the warning
in the unit tests - sometimes those are unavoidable.
-Adrian
On 2/8/2011 3:52 AM, mrisal...@libero.it wrote:
What I have to do it in this case leave the compilation warning or remove it
putting a //FIXME ?
I would like to
I still continue to do it when stumble upon one/some. Fortunately there are
less and less.
I agree that not all of them are useful...
Jacques
Scott Gray wrote:
To me it seems like a wasted effort, what do we gain by removing warnings and
adding FIXMEs? It seems like all we get are
unneeded c
To me it seems like a wasted effort, what do we gain by removing warnings and
adding FIXMEs? It seems like all we get are unneeded comments and a few more
chunks to review.
But please don't take my comments as criticism, I appreciate the effort you're
putting in and have spent many hours doing
What I have to do it in this case leave the compilation warning or remove it
putting a //FIXME ?
I would like to before to remove all the compilation warning and then we could
work on the //FIXME later.
What did you think of it ?
Thanks
Marco
>Messaggio originale
>Da: jacques.le.r...@
OK, I will follow.
Did I have to change the commit message for this bug correction ?
Please consider also that a massive work like that can cause same error.
Probably if in the future all the committer do not commit classes that are not
i18n this massive work no more occurs.
Thanks
Marco
>---
I agree with you, which maximum value (100/300) long lines will would like to
use in OFBiz ?
There is a standard rules to be follow (I still have not checked into the
committer rules)
There was already some long lines splitted into the SagePayPaymentService.java
and how we could change ?
For e
Ok, I will check it as soon as I could do it.
Thanks a lot Jacopo to take a look at it.
Marco
>Messaggio originale
>Da: jacopo.cappell...@hotwaxmedia.com
>Data: 14/01/2011 8.18
>A:
>Ogg: Re: buildbot failure in ASF Buildbot on ofbiz-trunk
>
>Hi Marco,
>
>The following change in the orig
Yes, Jacques I'm still working to remove "fail-message" tag from applications
and specialpurpose components.
If you want to help me to remove it from framework components I will
appreciate it.
Thanks
Marco
>Messaggio originale
>Da: jacques.ler...@9business.fr
>Data: 22/12/2010 11.43
>A:
19 matches
Mail list logo
