Re: Tabs to 4 spaces

2009-01-23 Thread Jacques Le Roux
Done, rev. 737003 Jacques From: "Jacques Le Roux" If nobody disagree I will do that tomorrow. It will be a massive no functionnal change. Jacques From: "Jacques Le Roux" I will eventually do that later when the BigDecimal branch will have been merged Jacques From: "Jacques Le Roux" If

Re: Tabs to 4 spaces

2009-01-23 Thread Jacques Le Roux
From: "David E Jones" Trying to use this literally, the interpretation is: indent with 4 spaces, and don't ever use tabs. It says: "Four spaces should be used as the unit of indentation. The exact construction of the indentation (spaces vs. tabs) is unspecified. Tabs must be set exactly eve

Re: Tabs to 4 spaces

2009-01-23 Thread David E Jones
Trying to use this literally, the interpretation is: indent with 4 spaces, and don't ever use tabs. It says: "Four spaces should be used as the unit of indentation. The exact construction of the indentation (spaces vs. tabs) is unspecified. Tabs must be set exactly every 8 spaces (not 4).

Re: Tabs to 4 spaces

2009-01-23 Thread Jeroen van der Wal
I totally agree to follow a convention but the first line in the convention says "The exact construction of the indentation (spaces vs. tabs) is unspecified.". So there's no need to replace tabs into spaces according to the convention. -Jeroen On Fri, Jan 23, 2009 at 10:34 AM, Jacques Le Roux < j

Re: Tabs to 4 spaces

2009-01-23 Thread Jacques Le Roux
Actually it's just a matter of convention and we chose this one http://java.sun.com/docs/codeconv/html/CodeConventions.doc3.html#313 The intention is to get rid of most of all these comments and changes we have to do as commiters... Patch ahead : 800 KB, 14574 lines (not the bigger I did, chan

Re: Tabs to 4 spaces

2009-01-23 Thread Jeroen van der Wal
Sorry for my late response, I've been away from a pc for a couple of days. We've had debates about tabs versus spaces several times and this quote reflects my opinion: "The debate over whether to use tab characters or spaces for indenting code is probably as old as Fortran. In fact, the arguing ov

Re: Tabs to 4 spaces

2009-01-22 Thread Jacques Le Roux
Yes Bilgin, that's true indeed. I will let them like that... Thanks Jacques From: "Bilgin Ibryam" Does it worth to replace tabs in third party javascript files? Probably the new versions of these files will be full of tabs, again. Bilgin On Jan 22, 2009, at 9:08 AM, Jacques Le Roux wrote:

Re: Tabs to 4 spaces

2009-01-22 Thread Bilgin Ibryam
Does it worth to replace tabs in third party javascript files? Probably the new versions of these files will be full of tabs, again. Bilgin On Jan 22, 2009, at 9:08 AM, Jacques Le Roux wrote: If nobody disagree I will do that tomorrow. It will be a massive no functionnal change. Jacques F

Re: Tabs to 4 spaces

2009-01-21 Thread Jacques Le Roux
If nobody disagree I will do that tomorrow. It will be a massive no functionnal change. Jacques From: "Jacques Le Roux" I will eventually do that later when the BigDecimal branch will have been merged Jacques From: "Jacques Le Roux" If nobody complains, I will replace *all* tabs by 4 spac

Re: Tabs to 4 spaces

2009-01-01 Thread Jacques Le Roux
I will eventually do that later when the BigDecimal branch will have been merged Jacques From: "Jacques Le Roux" If nobody complains, I will replace *all* tabs by 4 spaces in some days. It will be one sole big patch without any other changes Jacques From: "Stephen Rufle" +1 :) Jacques Le

Re: Tabs to 4 spaces

2008-12-29 Thread Jacques Le Roux
If nobody complains, I will replace *all* tabs by 4 spaces in some days. It will be one sole big patch without any other changes Jacques From: "Stephen Rufle" +1 :) Jacques Le Roux wrote: Currently there are 2351 tabs in Java files. We could easily replace all of them by 4 spaces. What do

Re: Tabs to 4 spaces

2008-12-28 Thread Stephen Rufle
+1 :) Jacques Le Roux wrote: > Currently there are 2351 tabs in Java files. We could easily replace all of > them by 4 spaces. What do you think ? > > Maybe we could do the same in XML files, there are 32 786 tabs in them... > > In FreeMarker files : only 563 tabs, in Groovy only 668 > > JavaScri