Re: svn commit: r1818378 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apac he/ofbiz/accounting/tax/TaxAuthorityServices.java

2017-12-16 Thread Taher Alkhateeb
ed refactoring commit, but stopped and >> decided >> to rather discuss this in the related Jira. >> >> BTW automatically cutting lines at some narrow width does not make sense >> most of >> the time. >> See EntityQuery cases for instance, are they not easier

Re: svn commit: r1818378 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apac he/ofbiz/accounting/tax/TaxAuthorityServices.java

2017-12-16 Thread Jacques Le Roux
tted, as I did here? Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/src/main /java/org/apache/ofbiz/accounting/tax/TaxAuthorityServices.java Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/src/main /java/org/apache/ofbiz/accounting/tax/TaxAuthorityServices.

Re: svn commit: r1818378 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/tax/TaxAuthorityServices.java

2017-12-16 Thread Taher Alkhateeb
, rightly formatted, as I did here? Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/src/main /java/org/apache/ofbiz/accounting/tax/TaxAuthorityServices.java Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/src/main /java/org/apache/ofbiz/accounting/tax/TaxAuthorityServ

Re: Implementing GST tax in Ofbiz - CGST , SGST , IGST

2017-10-13 Thread Vaibhav Jain
%. The ability to have different tax rates for different Product Category already exists so it shall be best to bank upon it . (as you have already done it in the example you gave). >> >> As we know GST in India is based on ORIG_LOCATION and DEST_LOCATION >> and is currently

Fwd: Implementing GST tax in Ofbiz - CGST , SGST , IGST

2017-10-11 Thread Vaibhav Jain
Moving discussion to DEV list == Hello Rajesh/Everyone, GST(India) can be implemented in OFBiz as follow: After GST tax will apply on the basis of HSN code of product not on the product directly. So we can associate HSN code with tax slab

[jira] [Assigned] (OFBIZ-4850) When Use Add Tax button on invoice summary, duplicate existed tax line

2016-08-01 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-4850: Assignee: Nicolas Malin > When Use Add Tax button on invoice summary, duplicate exis

[jira] [Assigned] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-08-01 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-7801: Assignee: Nicolas Malin > Duplicate invoice tax by using "Add Tax

[jira] [Commented] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-08-01 Thread Nicolas Malin (JIRA)
d my old OFBIZ-4850. > Duplicate invoice tax by using "Add Tax" button. > > > Key: OFBIZ-7801 > URL: https://issues.apache.org/jira/browse/OFBIZ-7801 > Project:

[jira] [Commented] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-08-01 Thread Jacques Le Roux (JIRA)
Hopefully [~soledad] will have a better idea than us > Duplicate invoice tax by using "Add Tax" button. > > > Key: OFBIZ-7801 > URL: https://issues.apache.org/jira/browse/OFBIZ-7801 >

[jira] [Comment Edited] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-07-31 Thread Chula Lathong (JIRA)
this patch by referring to the patch in OFBIZ-4850. But I relate this issue with OFBIZ-4850 because, I see that they are similar issues. Are there anything I should edit? Thank you. > Duplicate invoice tax by using "Add

[jira] [Commented] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-07-31 Thread Chula Lathong (JIRA)
this patch by referring to the patch in OFBIZ-4850. But I relate this issue with OFBIZ-4850 because, I see that they are similar issues. Are there anything I should edit? Thank you. > Duplicate invoice tax by using "Add

[jira] [Commented] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-07-31 Thread Chula Lathong (JIRA)
this patch by referring to the patch in OFBIZ-4850. But I relate this issue with OFBIZ-4850 because, I see that they are similar issues. Are there anything I should edit? Thank you. > Duplicate invoice tax by using "Add

[jira] [Issue Comment Deleted] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-07-31 Thread Chula Lathong (JIRA)
patch in OFBIZ-4850. But I relate this issue with OFBIZ-4850 because, I see that they are similar issues. Are there anything I should edit? Thank you.) > Duplicate invoice tax by using "Add Tax" button. > > >

[jira] [Commented] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-07-31 Thread Jacques Le Roux (JIRA)
with OFBIZ-4850, but the patches seem quite different at 1st glance. Is the patch here complementary or does it supercede the one in OFBIZ-4850? Thanks! > Duplicate invoice tax by using "Add Tax" button. > > >

[jira] [Reopened] (OFBIZ-372) Itemize tax in POS receipts

2016-07-30 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-372: --- > Itemize tax in POS receipts > --- > > Ke

[jira] [Updated] (OFBIZ-372) Itemize tax in POS receipts

2016-07-30 Thread Jacques Le Roux (JIRA)
useful in webpos did not chedk details, feel free to close again if useless > Itemize tax in POS receipts > --- > > Key: OFBIZ-372 > URL: https://issues.apache.org/jira/browse/OFBIZ-372 > Project: OFBiz >

[jira] [Commented] (OFBIZ-6578) POS not calculating Tax While doing return

2016-07-30 Thread Jacques Le Roux (JIRA)
uess it's also OK > POS not calculating Tax While doing return > -- > > Key: OFBIZ-6578 > URL: https://issues.apache.org/jira/browse/OFBIZ-6578 > Project: OFBiz > Issue T

[jira] [Closed] (OFBIZ-6578) POS not calculating Tax While doing return

2016-07-30 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6578. -- Resolution: Not A Problem Seems that's not a problem > POS not calculating Tax Whi

[jira] [Closed] (OFBIZ-372) Itemize tax in POS receipts

2016-07-30 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-372. - Resolution: Unresolved This was POS specific, closing again > Itemize tax in POS recei

[jira] [Reopened] (OFBIZ-6578) POS not calculating Tax While doing return

2016-07-30 Thread Jacques Le Roux (JIRA)
ing Tax While doing return > -- > > Key: OFBIZ-6578 > URL: https://issues.apache.org/jira/browse/OFBIZ-6578 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/p

[jira] [Reopened] (OFBIZ-372) Itemize tax in POS receipts

2016-07-30 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-372: --- Reopen recently closed POS issue to later change the component to webpos > Itemize tax in

[jira] [Commented] (OFBIZ-7442) Error in adding Party tax authority

2016-07-30 Thread Pierre Smits (JIRA)
adding Party tax authority > --- > > Key: OFBIZ-7442 > URL: https://issues.apache.org/jira/browse/OFBIZ-7442 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Ver

[jira] [Resolved] (OFBIZ-7442) Error in adding Party tax authority

2016-07-30 Thread Mridul Pathak (JIRA)
14.12 Release Branch 15.12 Thanks [~arvind.singh], you patch with some corrections is in trunk r1754591, 15.12 r1754592, 14.12 r1754593, 13.07 r1754594. Thanks [~padma.rawat] for reporting the issue and [~pfm.smits] for your input. > Error in adding Party tax author

[jira] [Closed] (OFBIZ-7442) Error in adding Party tax authority

2016-07-30 Thread Mridul Pathak (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak closed OFBIZ-7442. > Error in adding Party tax authority > --- > >

[jira] [Updated] (OFBIZ-7442) Error in adding Party tax authority

2016-07-29 Thread Mridul Pathak (JIRA)
Release Branch 15.12 > Error in adding Party tax authority > --- > > Key: OFBIZ-7442 > URL: https://issues.apache.org/jira/browse/OFBIZ-7442 > Project: OFBiz > Issue Type: Bug >

[jira] [Assigned] (OFBIZ-7442) Error in adding Party tax authority

2016-07-29 Thread Mridul Pathak (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak reassigned OFBIZ-7442: Assignee: Mridul Pathak (was: Arvind Singh Tomar) > Error in adding Party tax author

[jira] [Closed] (OFBIZ-6578) POS not calculating Tax While doing return

2016-07-28 Thread Jacques Le Roux (JIRA)
as unresolved > POS not calculating Tax While doing return > -- > > Key: OFBIZ-6578 > URL: https://issues.apache.org/jira/browse/OFBIZ-6578 > Project: OFBiz > Issue Type: Bug

[jira] [Closed] (OFBIZ-372) Itemize tax in POS receipts

2016-07-28 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-372. - Resolution: Unresolved The pos component is in Attic, closing as unresolved > Itemize tax in

[jira] [Created] (OFBIZ-7936) Move 3rd party tax integrations from order application to sepcialpurpose

2016-07-28 Thread Mridul Pathak (JIRA)
Mridul Pathak created OFBIZ-7936: Summary: Move 3rd party tax integrations from order application to sepcialpurpose Key: OFBIZ-7936 URL: https://issues.apache.org/jira/browse/OFBIZ-7936 Project

[jira] [Created] (OFBIZ-7934) Add tax to billed hours

2016-07-28 Thread Montalbano Florian (JIRA)
Montalbano Florian created OFBIZ-7934: - Summary: Add tax to billed hours Key: OFBIZ-7934 URL: https://issues.apache.org/jira/browse/OFBIZ-7934 Project: OFBiz Issue Type: Improvement

[jira] [Commented] (OFBIZ-7442) Error in adding Party tax authority

2016-07-16 Thread Arvind Singh Tomar (JIRA)
tion [~pfm.smits] A lookup with proper role related parties is a good option but in that case too, we will need server side check for this error. Parties with Tax authority role work based on geo-location and to check that we need to add service level code. > Error in adding Party tax au

[jira] [Commented] (OFBIZ-7442) Error in adding Party tax authority

2016-07-16 Thread Pierre Smits (JIRA)
do a lookup to the wrong group of companies, all in stead of just parties with the proper role. > Error in adding Party tax authority > --- > > Key: OFBIZ-7442 > URL: https://issues.apache.org/jir

[jira] [Updated] (OFBIZ-7442) Error in adding Party tax authority

2016-07-16 Thread Arvind Singh Tomar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvind Singh Tomar updated OFBIZ-7442: -- Attachment: OFBIZ-7442_trunk.patch > Error in adding Party tax author

[jira] [Updated] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-07-14 Thread Chula Lathong (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chula Lathong updated OFBIZ-7801: - Attachment: OFBIZ-7801.patch > Duplicate invoice tax by using "Add Tax

[jira] [Updated] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-07-14 Thread Chula Lathong (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chula Lathong updated OFBIZ-7801: - Attachment: (was: OFBIZ-7801.patch) > Duplicate invoice tax by using "Add Tax

[jira] [Updated] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-07-14 Thread Chula Lathong (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chula Lathong updated OFBIZ-7801: - Attachment: OFBIZ-7801.patch > Duplicate invoice tax by using "Add Tax

[jira] [Updated] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-07-14 Thread Chula Lathong (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chula Lathong updated OFBIZ-7801: - Attachment: (was: fixAddTaxBug.patch) > Duplicate invoice tax by using "Add Tax

[jira] [Updated] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-07-14 Thread Chula Lathong (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chula Lathong updated OFBIZ-7801: - Attachment: fixAddTaxBug.patch > Duplicate invoice tax by using "Add Tax

[jira] [Created] (OFBIZ-7801) Duplicate invoice tax by using "Add Tax" button.

2016-07-14 Thread Chula Lathong (JIRA)
Chula Lathong created OFBIZ-7801: Summary: Duplicate invoice tax by using "Add Tax" button. Key: OFBIZ-7801 URL: https://issues.apache.org/jira/browse/OFBIZ-7801 Project: OFBiz

[jira] [Resolved] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-07-04 Thread Divesh Dutta (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divesh Dutta resolved OFBIZ-6576. - Resolution: Fixed > Pricing error in Variant Products when setup with VAT-Tax and price set

[jira] [Closed] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-07-04 Thread Divesh Dutta (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divesh Dutta closed OFBIZ-6576. --- > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual P

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-07-04 Thread Divesh Dutta (JIRA)
tup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-07-04 Thread Divesh Dutta (JIRA)
and thanks [~paul_foxworthy] for reporting this issue . Its committed in revision number 1751362 in trunk. release 14.12 - 1751363 release 15.12 - 1751364 > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtu

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-27 Thread Jacques Le Roux (JIRA)
) (was: 14.12.01) > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 >

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-24 Thread Divesh Dutta (JIRA)
rate ticket for this problem . > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: htt

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-24 Thread Divesh Dutta (JIRA)
t in terms of business definitions of VAT_TAX and SALES_TAX. My comment was may be confusing, sorry for that. When I say that they are different I say in terms of how system will handle them in terms of Sales. In terms of sales, revenue is generated on product sales and sales tax is recorded

[jira] [Issue Comment Deleted] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-24 Thread Divesh Dutta (JIRA)
of VAT_TAX and SALES_TAX. My comment was may be confusing, sorry for that. When I say that they are different I say in terms of how system will handle them in terms of Sales. In terms of sales, revenue is generated on product sales and sales tax is recorded as liability that needs to be

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-24 Thread Divesh Dutta (JIRA)
t in terms of business definitions of VAT_TAX and SALES_TAX. My comment was may be confusing, sorry for that. When I say that they are different I say in terms of how system will handle them in terms of Sales. In terms of sales, revenue is generated on product sales and sales tax is recorded

[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-23 Thread Peter Arnold (JIRA)
2Oz 1CLP1,690 CLP0 CLP2,011.1 Adjustment: VAT Tax (not added to totals) CLP321.1 DA-DA01 - DecoArt Americana Snow White Titanium 2Oz 1CLP1,690 CLP0 CLP1,690 Adjustment: VAT Tax (not a

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-23 Thread Peter Arnold (JIRA)
auls explanation of the difference between Sales Tax and VAT TAX. Sales tax is applied as a percentage of the sales amount. VAT is as the name says (Value Added Tax) only applied as a percentage on the added value. For example: You buy something for 1USD and sell it for 2USD. The added value is calcul

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-23 Thread Peter Arnold (JIRA)
CLP2,011.1 Adjustment: VAT Tax (not added to totals) CLP321.1 DA-DA01 - DecoArt Americana Snow White Titanium 2Oz 1CLP1,690 CLP0 CLP1,690 Adjustment: VAT Tax (not added to totals)

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Jacques Le Roux (JIRA)
t :D > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Ankush Upadhyay (JIRA)
heck improvements. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Ankush Upadhyay (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay updated OFBIZ-6576: --- Attachment: OFBIZ-6576.patch > Pricing error in Variant Products when setup with VAT-Tax

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Ankush Upadhyay (JIRA)
ith VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz >

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Divesh Dutta (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divesh Dutta updated OFBIZ-6576: Priority: Major (was: Minor) > Pricing error in Variant Products when setup with VAT-Tax and pr

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Divesh Dutta (JIRA)
more minor thing, we are already discussing in community about directly checking null or not null for GenericValue instead of using isNotEmpty method of GenericValue . So in this patch, please change it accordingly and then we should be good, > Pricing error in Variant Products when setup with

[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Divesh Dutta (JIRA)
3 AM: -- Hi [~paul_foxworthy] , I agree that SALES_TAX and VAT_TAX are same , they are both taxes levied by tax authority on a sale. I guess we can remove the if and else statements in code for SALES_TAX or VAT_TAX. Also I think Sales tax can also be put on Purchase order, when you want to

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Jacques Le Roux (JIRA)
sh's patch! > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.a

[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Jacques Le Roux (JIRA)
: {code} taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX"); {code} Therewith Sales tax is added later on to the Variant Product. By temporary replacing in above mentioned code line "SALES_TAX" by "VAT_TAX" the issue seems to be resolved. However th

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Ankush Upadhyay (JIRA)
and suggestion, I have updated patch with suggested improvements. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > >

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Ankush Upadhyay (JIRA)
ith VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz >

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Ankush Upadhyay (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay updated OFBIZ-6576: --- Attachment: OFBIZ-6576.patch > Pricing error in Variant Products when setup with VAT-Tax

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Ankush Upadhyay (JIRA)
ith VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz >

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Ankush Upadhyay (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay updated OFBIZ-6576: --- Attachment: OFBIZ-6576.patch > Pricing error in Variant Products when setup with VAT-Tax

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Divesh Dutta (JIRA)
_TAX and VAT_TAX are same , they are both taxes levied by tax authority on a sale. I guess we can remove the if and else statements in code for SALES_TAX or VAT_TAX. Also I think Sales tax also be put on Purchase order, when you want to put approximate tax which supplier will take from you.

[jira] [Assigned] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Divesh Dutta (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divesh Dutta reassigned OFBIZ-6576: --- Assignee: Divesh Dutta > Pricing error in Variant Products when setup with VAT-Tax and pr

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Divesh Dutta (JIRA)
gt; Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.a

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-21 Thread Paul Foxworthy (JIRA)
they are both taxes levied by a tax authority on a sale. the key difference is VAT applies to purchases as well, and your tax liability is reduced by the tax you have paid on purchases. In contrast, sales tax only applies to sales. Cheers Paul > Pricing error in Variant Products when setup w

[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-21 Thread Ankush Upadhyay (JIRA)
an't create sales tax adjustment anymore in system. Please review the changes and let me know if anything else needs to be taken care under this. was (Author: ankush.upadhyay): Thanks [~Peter Arnold] for reporting the issue and research notes. I have also noticed the same issue and about to

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-21 Thread Ankush Upadhyay (JIRA)
o be taken care under this. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: htt

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-21 Thread Ankush Upadhyay (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay updated OFBIZ-6576: --- Attachment: OFBIZ-6576.patch > Pricing error in Variant Products when setup with VAT-Tax

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-21 Thread Peter Arnold (JIRA)
w in TaxAuthorityServices.java: _ Since for a variant product the "productPrice" and "taxInPrice" is set only on the corresponding virtual product, the Else part of below code becomes active and does the following: taxAdjValue.set("orderAdjustmentTypeId", "SA

[jira] [Updated] (OFBIZ-7442) Error in adding Party tax authority

2016-06-20 Thread Arvind Singh Tomar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvind Singh Tomar updated OFBIZ-7442: -- Sprint: Community Day 2 - 2016 > Error in adding Party tax author

[jira] [Updated] (OFBIZ-7436) Client Side validation missing on Create New Tax Authority Form

2016-06-20 Thread Deepak Dixit (JIRA)
ion missing on Create New Tax Authority Form > --- > > Key: OFBIZ-7436 > URL: https://issues.apache.org/jira/browse/OFBIZ-7436 > Project: OFBiz > Issue Type: Sub-task

[jira] [Updated] (OFBIZ-7437) Client side validation required in Tax Infos (Add Party Tax Authority Info)

2016-06-20 Thread Deepak Dixit (JIRA)
ion required in Tax Infos (Add Party Tax Authority Info) > --- > > Key: OFBIZ-7437 > URL: https://issues.apache.org/jira/browse/OFBIZ-7437 > Project: OFBiz >

[jira] [Updated] (OFBIZ-7436) Client Side validation missing on Create New Tax Authority Form

2016-06-20 Thread Ankit Joshi (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi updated OFBIZ-7436: --- Sprint: Community Day 2 - 2016 > Client Side validation missing on Create New Tax Authority F

[jira] [Assigned] (OFBIZ-7442) Error in adding Party tax authority

2016-06-18 Thread Arvind Singh Tomar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvind Singh Tomar reassigned OFBIZ-7442: - Assignee: Arvind Singh Tomar > Error in adding Party tax author

[jira] [Updated] (OFBIZ-7442) Error in adding Party tax authority

2016-06-18 Thread Padmavati Rawat (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Padmavati Rawat updated OFBIZ-7442: --- Attachment: Tax_Authority_Party.png > Error in adding Party tax author

[jira] [Created] (OFBIZ-7442) Error in adding Party tax authority

2016-06-18 Thread Padmavati Rawat (JIRA)
Padmavati Rawat created OFBIZ-7442: -- Summary: Error in adding Party tax authority Key: OFBIZ-7442 URL: https://issues.apache.org/jira/browse/OFBIZ-7442 Project: OFBiz Issue Type: Bug

[jira] [Updated] (OFBIZ-7437) Client side validation required in Tax Infos (Add Party Tax Authority Info)

2016-06-18 Thread Arvind Singh Tomar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvind Singh Tomar updated OFBIZ-7437: -- Attachment: OFBIZ-7437_trunk.patch > Client side validation required in Tax Infos (

[jira] [Updated] (OFBIZ-7437) Client side validation required in Tax Infos (Add Party Tax Authority Info)

2016-06-18 Thread Padmavati Rawat (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Padmavati Rawat updated OFBIZ-7437: --- Attachment: Required_validation_missing.png > Client side validation required in Tax In

[jira] [Updated] (OFBIZ-7437) Client side validation required in Tax Infos (Add Party Tax Authority Info)

2016-06-18 Thread Padmavati Rawat (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Padmavati Rawat updated OFBIZ-7437: --- Summary: Client side validation required in Tax Infos (Add Party Tax Authority Info) (was

[jira] [Updated] (OFBIZ-7437) Client side validation required in Tax Infos (

2016-06-18 Thread Padmavati Rawat (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Padmavati Rawat updated OFBIZ-7437: --- Summary: Client side validation required in Tax Infos ( (was: Client side validation

[jira] [Assigned] (OFBIZ-7437) Client side validation required in Tax Infos

2016-06-18 Thread Arvind Singh Tomar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvind Singh Tomar reassigned OFBIZ-7437: - Assignee: Arvind Singh Tomar > Client side validation required in Tax In

[jira] [Updated] (OFBIZ-7436) Client Side validation missing on Create New Tax Authority Form

2016-06-18 Thread Ankit Joshi (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi updated OFBIZ-7436: --- Assignee: (was: Ankit Joshi) > Client Side validation missing on Create New Tax Authority F

[jira] [Created] (OFBIZ-7437) Client side validation required in Tax Infos

2016-06-18 Thread Padmavati Rawat (JIRA)
Padmavati Rawat created OFBIZ-7437: -- Summary: Client side validation required in Tax Infos Key: OFBIZ-7437 URL: https://issues.apache.org/jira/browse/OFBIZ-7437 Project: OFBiz Issue Type

[jira] [Updated] (OFBIZ-7436) Client Side validation missing on Create New Tax Authority Form

2016-06-18 Thread Ankit Joshi (JIRA)
ent Side validation missing on Create New Tax Authority Form > --- > > Key: OFBIZ-7436 > URL: https://issues.apache.org/jira/browse/OFBIZ-7436 > Project: OFBiz > Is

[jira] [Created] (OFBIZ-7436) Client Side validation missing on Create New Tax Authority Form

2016-06-18 Thread Ankit Joshi (JIRA)
Ankit Joshi created OFBIZ-7436: -- Summary: Client Side validation missing on Create New Tax Authority Form Key: OFBIZ-7436 URL: https://issues.apache.org/jira/browse/OFBIZ-7436 Project: OFBiz

[jira] [Closed] (OFBIZ-7306) Delete Customer Tax Auth Info link is not working - Security Error

2016-06-13 Thread Pranay Pandey (JIRA)
] > Delete Customer Tax Auth Info link is not working - Security Error > -- > > Key: OFBIZ-7306 > URL: https://issues.apache.org/jira/browse/OFBIZ-7306 > Project: OFBiz >

[jira] [Commented] (OFBIZ-7306) Delete Customer Tax Auth Info link is not working - Security Error

2016-06-13 Thread Jacques Le Roux (JIRA)
cate of OFBIZ-4106, please check, thanks > Delete Customer Tax Auth Info link is not working - Security Error > -- > > Key: OFBIZ-7306 > URL: https://issues.apache.org/jir

[jira] [Assigned] (OFBIZ-7306) Delete Customer Tax Auth Info link is not working - Security Error

2016-06-10 Thread Pranay Pandey (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey reassigned OFBIZ-7306: Assignee: Pranay Pandey (was: Mohammed Rehan Khan) > Delete Customer Tax Auth Info l

[jira] [Created] (OFBIZ-7306) Delete Customer Tax Auth Info link is not working - Security Error

2016-06-10 Thread Mohammed Rehan Khan (JIRA)
Mohammed Rehan Khan created OFBIZ-7306: -- Summary: Delete Customer Tax Auth Info link is not working - Security Error Key: OFBIZ-7306 URL: https://issues.apache.org/jira/browse/OFBIZ-7306 Project

[jira] [Closed] (OFBIZ-7123) After updating/deleting any type of order adjustment need to recalc Sales Tax

2016-05-30 Thread Arun Patidar (JIRA)
14.12.01 Thanks Rohit for your contribution and patch. Changes has been committed into Trunk at rev: 1746228 15.12 at rev: 1746229 14.12 at rev: 1746230 13.07 at rev: 1746231 > After updating/deleting any type of order adjustment need to recalc Sales

[jira] [Commented] (OFBIZ-7123) After updating/deleting any type of order adjustment need to recalc Sales Tax

2016-05-30 Thread Rohit Koushal (JIRA)
o me. > After updating/deleting any type of order adjustment need to recalc Sales Tax > - > > Key: OFBIZ-7123 > URL: https://issues.apache.org/jira/browse/OFBIZ-7123 >

[jira] [Updated] (OFBIZ-7123) After updating/deleting any type of order adjustment need to recalc Sales Tax

2016-05-30 Thread Arun Patidar (JIRA)
patch and attached a modified patch. Please verify it and let me know if it works for you. > After updating/deleting any type of order adjustment need to recalc Sales Tax > - > > Key

[jira] [Updated] (OFBIZ-7123) After updating/deleting any type of order adjustment need to recalc Sales Tax

2016-05-30 Thread Rohit Koushal (JIRA)
and let me know if any other changes are required. > After updating/deleting any type of order adjustment need to recalc Sales Tax > - > > Key: OFBIZ-7123 > URL: https://is

[jira] [Created] (OFBIZ-7123) After updating/deleting any type of order adjustment need to recalc Sales Tax

2016-05-25 Thread Arun Patidar (JIRA)
Arun Patidar created OFBIZ-7123: --- Summary: After updating/deleting any type of order adjustment need to recalc Sales Tax Key: OFBIZ-7123 URL: https://issues.apache.org/jira/browse/OFBIZ-7123 Project

[jira] [Updated] (OFBIZ-5935) Sales tax adjustments manually added to purchase orders cause creation of another adjustment undoing the first

2016-05-20 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-5935: --- Fix Version/s: 13.07.04 Backported in R13.07 at r1744671 > Sales tax adjustments manua

[jira] [Commented] (OFBIZ-5935) Sales tax adjustments manually added to purchase orders cause creation of another adjustment undoing the first

2016-05-20 Thread Paul Foxworthy (JIRA)
that tax on a purchase order is an estimate, and once you receive an invoice from the supplier, it may be different. That doesn't mean the tax should be ignored. 1. You may be sending payment with the purchase order, so you need the tax amount at that time. 2. The estimated tax is useful

  1   2   3   4   5   >