+ 1
Regards
Vikas
On Thu, Jan 27, 2011 at 4:51 AM, Scott Gray wrote:
> The problem is that when you mix code changes with formatting changes
> reviewers then have inspect every chunk closely in order to figure out what
> (if anything) changed in those lines.
>
> I can't force you to do anything
The problem is that when you mix code changes with formatting changes reviewers
then have inspect every chunk closely in order to figure out what (if anything)
changed in those lines.
I can't force you to do anything but if you want your code reviewed properly
then I'd really recommend splittin
Hi Scott,
we discuss on the dev mailing list that when we change something in the code
and we found long lines stripped we could replace it with long lines.
In this case It was what I would like to do it but I forgot to do it, probably
in this case there was a tab and I have simply replaced it w
Hi Marco,
Could please try and avoid including formatting changes in with actual code
changes? It makes review much more difficult.
Many thanks
Scott
HotWax Media
http://www.hotwaxmedia.com
On 26/01/2011, at 10:00 AM, mrisal...@apache.org wrote:
> Author: mrisaliti
> Date: Tue Jan 25 21:00:0
