Re: svn commit: r1351778 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

2012-06-23 Thread Jacques Le Roux
From: "Jacques Le Roux" From: "Jacopo Cappellato" On Jun 20, 2012, at 10:12 AM, Jacques Le Roux wrote: I slept on it and here is what I will do. When using DeltaManager, I remember crossing issues with session serialisation at logout (due to Java Objects in session and, as I said, also dis

Re: svn commit: r1351778 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

2012-06-20 Thread Jacques Le Roux
From: "Jacopo Cappellato" On Jun 20, 2012, at 10:12 AM, Jacques Le Roux wrote: I slept on it and here is what I will do. When using DeltaManager, I remember crossing issues with session serialisation at logout (due to Java Objects in session and, as I said, also dispatcher, security and auth

Re: svn commit: r1351778 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

2012-06-20 Thread Jacopo Cappellato
On Jun 20, 2012, at 10:12 AM, Jacques Le Roux wrote: > I slept on it and here is what I will do. > > When using DeltaManager, I remember crossing issues with session > serialisation at logout (due to Java Objects in session and, as I said, also > dispatcher, security and authz object, though I

Re: svn commit: r1351778 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

2012-06-20 Thread Jacques Le Roux
I slept on it and here is what I will do. When using DeltaManager, I remember crossing issues with session serialisation at logout (due to Java Objects in session and, as I said, also dispatcher, security and authz object, though I don't clearly remember for the last 3). Now that I think about

Re: svn commit: r1351778 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

2012-06-19 Thread Jacopo Cappellato
On Jun 19, 2012, at 10:46 PM, Jacques Le Roux wrote: > Mmm, we could also remove the whole initial commit and all backports. This would be ideal... the whole commit seems to add unwanted complexity just to handle a specific use case that could probably be managed with different approaches,if p

Re: svn commit: r1351778 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

2012-06-19 Thread Jacques Le Roux
Mmm, we could also remove the whole initial commit and all backports. Simply all objects put in session would need then to be serialized... Though it seems I crossed other issues with the dispatcher, security and authz... Jacques From: "Jacques Le Roux" From: "Jacques Le Roux" Ho I see, bi

Re: svn commit: r1351778 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

2012-06-19 Thread Jacques Le Roux
From: "Jacques Le Roux" Ho I see, big mistake actually. I did not thought about the effect of this default value when the manager-class is not set in catalina-container. I think I should have used org.apache.catalina.ha.session.StandardManager as default rather Anyway StandardManager would b

Re: svn commit: r1351778 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

2012-06-19 Thread Jacques Le Roux
Ho I see, big mistake actually. I did not thought about the effect of this default value when the manager-class is not set in catalina-container. I think I should have used org.apache.catalina.ha.session.StandardManager as default rather There should not be other side effects though. Jacques F

Re: svn commit: r1351778 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

2012-06-19 Thread Jacques Le Roux
BTW the reported issue was only in a cluster context or also with a sole server? Jacques From: "Jacques Le Roux" I will also have a look. I explained why I did so at https://issues.apache.org/jira/browse/OFBIZ-4289. Jacques From: Author: jacopoc Date: Tue Jun 19 17:14:14 2012 New Revision

Re: svn commit: r1351778 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

2012-06-19 Thread Jacques Le Roux
I will also have a look. I explained why I did so at https://issues.apache.org/jira/browse/OFBIZ-4289. Jacques From: Author: jacopoc Date: Tue Jun 19 17:14:14 2012 New Revision: 1351778 URL: http://svn.apache.org/viewvc?rev=1351778&view=rev Log: Setting a default value of DeltaManager was ca