Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Hans Bakker
Ok sounds pretty reasonable, let me see what i can do in my free time Regards, Hans On 06/26/2012 12:08 PM, Jacopo Cappellato wrote: Yes, Scott explained very well the concept: ACCOUNTING_CREATE will give grants to create all records in Accounting; PAY_INFO_CREATE will give grants only to

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Jacopo Cappellato
Yes, Scott explained very well the concept: ACCOUNTING_CREATE will give grants to create all records in Accounting; PAY_INFO_CREATE will give grants only to create payments. Jacopo On Jun 26, 2012, at 5:38 AM, Scott Gray wrote: > If I had to guess I would think your proposition would be rever

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Scott Gray
If I had to guess I would think your proposition would be reversed: PAY_INFO should grant limited access to ACCOUNTING functionality. On 26/06/2012, at 12:01 PM, Hans Bakker wrote: > Yes Jacopo, I know all that, but the question is as I wrote: > > The question here is do you really want to allow

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Hans Bakker
Yes Jacopo, I know all that, but the question is as I wrote: The question here is do you really want to allow access for ACCOUNTING_CREATE to have the same access as PAY_INFO_CREATE ? Perhaps the intention here was that, by creating a separate action PAY_INFO the ACCOUNTING_CREATE should not h

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Jacopo Cappellato
Hi Hans, I think that the intended meaning is the following: ACCOUNTING_: global permission to all parts of the Accounting application when performing the ACCOUNTING_ADMIN: global permission to all parts of the Accounting application when performing all the actions So for example: ACCOUNTING

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Hans Bakker
Hi Jacopo, thanks for reviewing this commit, my compliments for your work in this area. The question here is do you really want to allow access for ACCOUNTING_CREATE to have the same access as PAY_INFO_CREATE ? Perhaps the intention here was that, by creating a separate action PAY_INFO the

Re: svn commit: r1353381 - in /ofbiz/trunk: applications/accounting/data/ applications/accounting/script/org/ofbiz/accounting/payment/ applications/accounting/src/org/ofbiz/accounting/payment/ applica

2012-06-25 Thread Jacopo Cappellato
Hi Hans, I understand the issue you are fixing in this commit (and at least another one of last week) but I disagree with the approach. We should never add permission checks on the *_ADMIN permissions: we should instead always use one of the fine grained _CREATE, _UPDATE, _DELETE; the _ADMIN pe