Re: svn commit: r1391037 - in /ofbiz/trunk/framework: common/config/ webapp/src/org/ofbiz/webapp/control/

2012-09-30 Thread Jacques Le Roux
No because we need to take the hand on it. If we define a request of type none the RequestHandler will handle it and will end doing nothing. Also we need to be able to define many external requests in a controller, sometimes for the same request-map. Jacques From: "Scott Gray" Couldn't you ju

Re: svn commit: r1391037 - in /ofbiz/trunk/framework: common/config/ webapp/src/org/ofbiz/webapp/control/

2012-09-30 Thread Scott Gray
Couldn't you just define a default-request in the controller that points to a request uri which does nothing? i.e. no event and a response type of "none" Regards Scott On 28/09/2012, at 7:33 PM, Jacques Le Roux wrote: >> we talking about two servlets mapped to the same path? > > Actually not

Re: svn commit: r1391037 - in /ofbiz/trunk/framework: common/config/ webapp/src/org/ofbiz/webapp/control/

2012-09-30 Thread Jacques Le Roux
I need to create a new file, would we agree about requestHandler.properties? Jacques From: "Adrian Crum" Cool. When can we expect to see that change? -Adrian On 9/28/2012 11:55 AM, Jacques Le Roux wrote: Yes I wondered about that too, I have no problem to change it Jacques From: "Adrian

Re: svn commit: r1391037 - in /ofbiz/trunk/framework: common/config/ webapp/src/org/ofbiz/webapp/control/

2012-09-30 Thread madppiper
ofbiz defaults that are defined by the controller. -- View this message in context: http://ofbiz.135035.n4.nabble.com/Re-svn-commit-r1391037-in-ofbiz-trunk-framework-common-config-webapp-src-org-ofbiz-webapp-control-tp4636510p4636545.html Sent from the OFBiz - Dev mailing list archive at

Re: svn commit: r1391037 - in /ofbiz/trunk/framework: common/config/ webapp/src/org/ofbiz/webapp/control/

2012-09-29 Thread Adrian Crum
Cool. When can we expect to see that change? -Adrian On 9/28/2012 11:55 AM, Jacques Le Roux wrote: Yes I wondered about that too, I have no problem to change it Jacques From: "Adrian Crum" Can we put the property in the webapp component? It seems to me it belongs in the same component as t

Re: svn commit: r1391037 - in /ofbiz/trunk/framework: common/config/ webapp/src/org/ofbiz/webapp/control/

2012-09-28 Thread Jacques Le Roux
Yes I wondered about that too, I have no problem to change it Jacques From: "Adrian Crum" Can we put the property in the webapp component? It seems to me it belongs in the same component as the code it is configuring. -Adrian On 9/28/2012 8:08 AM, Jacques Le Roux wrote: Indeed with this c

Re: svn commit: r1391037 - in /ofbiz/trunk/framework: common/config/ webapp/src/org/ofbiz/webapp/control/

2012-09-28 Thread Jacques Le Roux
we talking about two servlets mapped to the same path? Actually not the same than control which is /control/* The external one is /* There is a proper filter for external mapping They use both 1 It's a bit like CatalogUrlServlet in eCommerce web.xml Not directly related but we also use Tuc

Re: svn commit: r1391037 - in /ofbiz/trunk/framework: common/config/ webapp/src/org/ofbiz/webapp/control/

2012-09-28 Thread Adrian Crum
Can we put the property in the webapp component? It seems to me it belongs in the same component as the code it is configuring. -Adrian On 9/28/2012 8:08 AM, Jacques Le Roux wrote: Indeed with this change you can't have that. If you used throwRequestHandlerExceptionOnMissingLocalRequest=Y You

Re: svn commit: r1391037 - in /ofbiz/trunk/framework: common/config/ webapp/src/org/ofbiz/webapp/control/

2012-09-28 Thread Jacques Le Roux
Indeed with this change you can't have that. If you used throwRequestHandlerExceptionOnMissingLocalRequest=Y You will have the "Going to external page: " + request.getPathInfo() message in log and then a blank screen if you don't handle the request with another specific servlet Of course if yo

Re: svn commit: r1391037 - in /ofbiz/trunk/framework: common/config/ webapp/src/org/ofbiz/webapp/control/

2012-09-27 Thread Scott Gray
I'm equally confused and the jira hasn't helped much. Could someone define an "external request in controllers" for me? Typically if you want flexible request handling on the control path you use the element to point to a uri that will handle the request within an event. I'm not sure I under

Re: svn commit: r1391037 - in /ofbiz/trunk/framework: common/config/ webapp/src/org/ofbiz/webapp/control/

2012-09-27 Thread Adrian Crum
I'm confused. I want to have external requests and I want to throw exceptions when I have missing controller entries. How does this change accommodate that? -Adrian On 9/27/2012 3:49 PM, jler...@apache.org wrote: Author: jleroux Date: Thu Sep 27 14:49:20 2012 New Revision: 1391037 URL: http