Re: svn commit: r1420019 - /ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml

2012-12-12 Thread Adam Heath
On 12/12/2012 04:40 PM, Jacques Le Roux wrote: >> Ok, then I disagree. So what if using yuicompressor on birt causes >> birt to break. That's birt's problem, or yuicompressor's problem. If >> it works fine with ofbiz files(or ofbiz files can be changed to make >> it work), then why not use it?

Re: svn commit: r1420019 - /ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml

2012-12-12 Thread Jacques Le Roux
From: "Adam Heath" > On 12/12/2012 01:34 PM, Jacques Le Roux wrote: >> Adam Heath wrote: >>> On 12/11/2012 08:25 PM, Adrian Crum wrote: The tool used to minify CSS and JS files was removed in rev 1416358. Then the visual theme was partially updated to not use the minify tool. But th

Re: svn commit: r1420019 - /ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml

2012-12-12 Thread Adam Heath
On 12/12/2012 01:34 PM, Jacques Le Roux wrote: > Adam Heath wrote: >> On 12/11/2012 08:25 PM, Adrian Crum wrote: >>> The tool used to minify CSS and JS files was removed in rev 1416358. >>> Then the visual theme was partially updated to not use the minify >>> tool. But that broke the theme, because

Re: svn commit: r1420019 - /ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml

2012-12-12 Thread Jacques Le Roux
Adam Heath wrote: > On 12/11/2012 08:25 PM, Adrian Crum wrote: >> The tool used to minify CSS and JS files was removed in rev 1416358. >> Then the visual theme was partially updated to not use the minify >> tool. But that broke the theme, because the original commit to minify >> the Flat Grey theme

Re: svn commit: r1420019 - /ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml

2012-12-12 Thread Adam Heath
On 12/11/2012 08:25 PM, Adrian Crum wrote: > The tool used to minify CSS and JS files was removed in rev 1416358. > Then the visual theme was partially updated to not use the minify > tool. But that broke the theme, because the original commit to minify > the Flat Grey theme was not completely reve

Re: svn commit: r1420019 - /ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml

2012-12-11 Thread Adrian Crum
Adam, The tool used to minify CSS and JS files was removed in rev 1416358. Then the visual theme was partially updated to not use the minify tool. But that broke the theme, because the original commit to minify the Flat Grey theme was not completely reverted. This commit was necessary to comp

Re: svn commit: r1420019 - /ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml

2012-12-11 Thread Adam Heath
Er, no. Please revert. The correct fix is to update build.xml to minimise these files. On 12/11/2012 01:31 AM, jler...@apache.org wrote: > Author: jleroux > Date: Tue Dec 11 07:31:40 2012 > New Revision: 1420019 > > URL: http://svn.apache.org/viewvc?rev=1420019&view=rev > Log: > Fixes "Flatgrey