Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

Yes thanks Pierre, just found it in svn annotations, then understood your answer :/ Jacques Le 20/03/2017 à 11:22, Pierre Smits a écrit : Hey Jacques, This appears to be the related issue: OFBIZ-7848 Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & ser

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

Hey Jacques, This appears to be the related issue: OFBIZ-7848 Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Mon, Mar 20, 2017 at 11:19 AM, Jacques Le Roux < jacques.le.r...@les7arts.

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

What is the situation here, please? Is there a Jira? Should I take care of that? Thanks Jacques Le 01/09/2016 à 15:28, Harsh Vijaywargiya a écrit : Thanks Jacques, Sounds good. I will take care of this suggestion in coming commits. Thanks & Regards, Harsh On Wednesday 31 August 2016 04:51 P

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

Thanks Jacques, Sounds good. I will take care of this suggestion in coming commits. Thanks & Regards, Harsh On Wednesday 31 August 2016 04:51 PM, Jacques Le Roux wrote: OK I checked, the commented out lines were from pre Apache Era. So indeed it was not an easy decision. For public void

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

OK I checked, the commented out lines were from pre Apache Era. So indeed it was not an easy decision. For public void print(List arr, BigDecimal quantity, int depth, boolean excludeWIPs) { I believe the lines were commented out because it's a recursive method. I still believe we should n

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

Le 30/08/2016 à 08:29, Jacopo Cappellato a écrit : Highlighting code that could be improved rather than fixing it is a good way to help potential contributors. However, and I think this is the reason for Scott's remark, you should not have addressed your review/request to individual committer/con

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

On Tue, Aug 30, 2016 at 7:19 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Mmm, then who should fix it? > This is an opportunity for anyone reading your message to contribute. > Of course I could have fixed it myself, but I thought that by providing an > advice I'd help more. H

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

Mmm, then who should fix it? Of course I could have fixed it myself, but I thought that by providing an advice I'd help more. As we say "If you give a man a *fish*, you have fed him for a day. If you teach a man to *fish*, you have fed him for a lifetime." Jacques Le 29/08/2016 à 23:41, Sco

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

Keep in mind though that dealing with silent exceptions wasn't in the scope of the commit. Code reviews are great but we shouldn't expect committers to fix issues they didn't introduce. On 29 August 2016 at 21:04, Jacques Le Roux wrote: > Hi Harsh, > > Please refer to what is usually done for t

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

Hi Harsh, Please refer to what is usually done for that, eg in a service } catch (GenericEntityException e) { Debug.logWarning(e, module); Map messageMap = UtilMisc.toMap("errMessage", e.getMessage()); errMsg = UtilProperties.getMessage("CommonUiLabe

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

Thanks Jacques for review comment. I think in such case it could be better to uncomment such log statements from Exception block, right? or we should leave it as is? Thanks & Regards, Harsh On Saturday 27 August 2016 06:19 PM, Jacques Le Roux wrote: Hi Ashish, Harsh, Please don't let swallo

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

Hi Ashish, Harsh, Please don't let swallowed exceptions in code, there were 2 opportunities here ;) Thanks Le 27/08/2016 à 13:27, ash...@apache.org a écrit : Author: ashish Date: Sat Aug 27 11:27:47 2016 New Revision: 1757991 URL: http://svn.apache.org/viewvc?rev=1757991&view=rev Log: Appli