Re: svn commit: r787890 - in /ofbiz/trunk/applications/marketing: config/MarketingUiLabels.xml script/org/ofbiz/sfa/lead/LeadServices.xml

2009-06-24 Thread Adam Heath
Anil Patel wrote: > Adam, > The service is returning id of two parties created in in the service. I > don't see anything bad about it. Can you please explain why is it not good? > > Also in this modification I have changed variable name used in method, > partyId out parameter was there before my t

Re: svn commit: r787890 - in /ofbiz/trunk/applications/marketing: config/MarketingUiLabels.xml script/org/ofbiz/sfa/lead/LeadServices.xml

2009-06-24 Thread Rishi Solanki
Hi, As the createLead service is creating PartyRelationship record on the basis of some parameters conditions so it should return the both partyId only, and the code committed is improved code to make it more sensible so that the partyId is now in whole service identified by the leadContactPartyId,

Re: svn commit: r787890 - in /ofbiz/trunk/applications/marketing: config/MarketingUiLabels.xml script/org/ofbiz/sfa/lead/LeadServices.xml

2009-06-23 Thread Anil Patel
Adam, The service is returning id of two parties created in in the service. I don't see anything bad about it. Can you please explain why is it not good? Also in this modification I have changed variable name used in method, partyId out parameter was there before my this commit. Regards Anil Pat

Re: svn commit: r787890 - in /ofbiz/trunk/applications/marketing: config/MarketingUiLabels.xml script/org/ofbiz/sfa/lead/LeadServices.xml

2009-06-23 Thread Anil Patel
Adam, The service is returning id of two parties created in in the service. I don't see anything bad about it. Can you please explain why is it not good? Also in this modification I have changed variable name used in method, partyId out parameter was there before my this commit. Regards

Re: svn commit: r787890 - in /ofbiz/trunk/applications/marketing: config/MarketingUiLabels.xml script/org/ofbiz/sfa/lead/LeadServices.xml

2009-06-23 Thread Adam Heath
apa...@apache.org wrote: > Author: apatel > Date: Wed Jun 24 02:48:28 2009 > New Revision: 787890 > > URL: http://svn.apache.org/viewvc?rev=787890&view=rev > Log: > Minor code clean up in createLead service. Convert lead now expires > relationship instead of deleting it. > > Modified: > ofbi