Re: tenant handling in XMLRPC

2018-08-09 Thread Rajesh Mallah
Thanks Taher. regds mallah. On Thu, Aug 9, 2018 at 3:30 PM, Taher Alkhateeb wrote: > Hi Rajesh, > > We usually implement our work using JIRA [1]. So I recommend you apply > your patch against the latest version of trunk over there and then ask > for it to be committed. > > [1] https://issues.a

Re: tenant handling in XMLRPC

2018-08-09 Thread Taher Alkhateeb
Hi Rajesh, We usually implement our work using JIRA [1]. So I recommend you apply your patch against the latest version of trunk over there and then ask for it to be committed. [1] https://issues.apache.org/jira/browse/OFBIZ On Tue, Aug 7, 2018 at 10:06 PM, Rajesh Mallah wrote: > > Hello Every

Re: tenant handling in XMLRPC

2018-08-07 Thread Rajesh Mallah
Hello Everyone / Mr Scott , I have been able to churn out a patch finally. The request level dispatcher is being stored in a member variable of a class derived from XmlRpcHttpRequestConfigImpl . in the execute method of ServiceRpcHandler the dispatcher is being extracted from the config. This

Re: tenant handling in XMLRPC

2018-08-06 Thread Rajesh Mallah
Hi , I was giving this problem another shot but need help. The original problem is that , it is not possible to direct XML / RPC requests to specific tenants in a multi-tenant environment. This problem is significant as it forces us to have multiple instances of ofbiz running which are not util

Re: tenant handling in XMLRPC

2018-03-16 Thread Rajesh Mallah
oops dunno how it's garbled. posting again: https://github.com/apache/ofbiz/blob/7ba7f3c2e16df6c8db0d8114e124957199cea1ff/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/SOAPEventHandler.java#L81 https://github.com/apache/ofbiz/blob/7ba7f3c2e16df6c8db0d8114e124957199cea1ff/framework/w

Re: tenant handling in XMLRPC

2018-03-16 Thread Rajesh Mallah
References: SOAPEventHandler.java https://github.com/apache/ofbiz/blob/7ba7f3c2e16df6c8db0d8114e124957199cea1ff/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/SOAPEventHandler.java#L81 XmlRpcEventHandler.java: https://github.com/apache/ofbiz/blob/7ba7f3c2e16df6c8db0d

Re: tenant handling in XMLRPC

2018-03-16 Thread Rajesh Mallah
Hi Scott / Gurus! , in SOAPEventHandler dispatcher and delegator is being got from HttpServletRequest request. However in XmlRpcHttpServer the request is being eventually handled via a callback (handler) of class ServiceRpcHandler . I am not sure how the HttpServletRequest can be passed till e

Re: tenant handling in XMLRPC

2018-03-16 Thread Rajesh Mallah
> > The EventHandler objects are > singletons shared among all incoming requests so we don't want to store > request-specific objects in fields that are accessed by all requests or the > results will get pretty unpredictable for concurrent requests across > multiple tenants. > Agreed and trying to

Re: tenant handling in XMLRPC

2018-03-15 Thread Scott Gray
You're completely right Rajesh, sorry, I jumped the gun without having a proper look in my reply. Your fix looks correct except that we need to move dispatcher/delegator to local variables rather than instance fields. The EventHandler objects are singletons shared among all incoming requests so w

Re: tenant handling in XMLRPC

2018-03-15 Thread Rajesh Mallah
Hi Scott , I could get it to work by setting dispatcher and delegator only. I referred SOAPEventHandler.java which handles tenants fine. I could not see userLogin handling tenantId as suggested by you, can you please see the below and tell if it is correct. Do we have test coverage to see if doe

Re: tenant handling in XMLRPC

2018-03-15 Thread Rajesh Mallah
Hey Thanks so much for taking the time and even suggesting a to solution. BTW i saw that the SOAP handler does it well. I would definitely try. regds mallah. On Thu, Mar 15, 2018 at 9:51 PM, Scott Gray wrote: > Hi Rajesh, > > It looks like the XmlRpcEventHandler class doesn't support this but

Re: tenant handling in XMLRPC

2018-03-15 Thread Scott Gray
Hi Rajesh, It looks like the XmlRpcEventHandler class doesn't support this but it could easily be modified to do so. I'd suggest filing a ticket, and perhaps even providing a patch :-) The tenantId just needs to be derived from the url and then passed into the userLogin service in the OfbizRpcAu

tenant handling in XMLRPC

2018-03-15 Thread Rajesh Mallah
Hello All , Is it possible to direct the webservice call to a particular tenant using XMLRPC? I am referring to https://cwiki.apache.org/confluence/display/OFBIZ/Using+XMLRPC+as+an+alternative+to+SOAP consider the snippet === XmlRpcClient