Re: [ovs-dev] dpdk-pci option in OVS

On 10/20/2016 07:16 AM, Vivek Soni wrote: Dear All, I want to use dpdk-pci option while adding a dpdk port to OVS. I found some reference at below link. But the GIT master branch does not have these changes. http://openvswitch.org/pipermail/dev/2016-July/074146.html Can somebody help how to u

[ovs-dev] dpdk-pci option in OVS

Dear All, I want to use dpdk-pci option while adding a dpdk port to OVS. I found some reference at below link. But the GIT master branch does not have these changes. http://openvswitch.org/pipermail/dev/2016-July/074146.html Can somebody help how to use this option with the latest ovs code ? R

Re: [ovs-dev] [PATCH 01/15] doc: Convert CodingStyle to rST

On Tue, Oct 18, 2016 at 4:03 PM, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > --- > CONTRIBUTING.md | 4 +- > CodingStyle.md | 578 - > CodingStyle.rst | 642 ++ > + > Makefi

Re: [ovs-dev] [PATCH] dpif-netdev: Fix windows build.

Thanks, pushed to master On 19/10/2016 14:51, "Sairam Venugopal" wrote: >Acked-by: Sairam Venugopal > > >On 10/19/16, 1:50 PM, "Daniele Di Proietto" wrote: > >>OVS_ALIGNED_VAR(...) should be at the beginning of a definition, as >>the example in include/openvswitch/compiler.h shows. >> >>Fix

Re: [ovs-dev] [PATCH] dpif-netdev: Fix windows build.

Acked-by: Sairam Venugopal On 10/19/16, 1:50 PM, "Daniele Di Proietto" wrote: >OVS_ALIGNED_VAR(...) should be at the beginning of a definition, as >the example in include/openvswitch/compiler.h shows. > >Fixes: 38ee0814978c ("dpif-netdev: Cache align netdev_flow_keys.") >Reported-by: Joe Strin

Re: [ovs-dev] [PATCH] dpif-netdev: Fix windows build.

Acked-by: Alin Gabriel Serdean > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di > Proietto > Sent: Wednesday, October 19, 2016 11:50 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH] dpif-netdev: Fix windows build. > > OVS_ALIGNED_VAR(

Re: [ovs-dev] [PATCH v3 07/12] dpif-netdev: Cache align netdev_flow_keys.

On Wed, Oct 19, 2016 at 01:42:50PM -0700, Jarno Rajahalme wrote: > > > On Oct 19, 2016, at 10:01 AM, Joe Stringer wrote: > > > > On 14 October 2016 at 07:37, Bhanuprakash Bodireddy > > wrote: > >> Aligning the 'keys' array seems to have positive performance impact. > >> > >> Signed-off-by: Bha

[ovs-dev] [PATCH] dpif-netdev: Fix windows build.

OVS_ALIGNED_VAR(...) should be at the beginning of a definition, as the example in include/openvswitch/compiler.h shows. Fixes: 38ee0814978c ("dpif-netdev: Cache align netdev_flow_keys.") Reported-by: Joe Stringer Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 2 +- 1 file changed,

Re: [ovs-dev] [PATCH v3 07/12] dpif-netdev: Cache align netdev_flow_keys.

2016-10-19 13:42 GMT-07:00 Jarno Rajahalme : > > > On Oct 19, 2016, at 10:01 AM, Joe Stringer wrote: > > > > On 14 October 2016 at 07:37, Bhanuprakash Bodireddy > > wrote: > >> Aligning the 'keys' array seems to have positive performance impact. > >> > >> Signed-off-by: Bhanuprakash Bodireddy >

Re: [ovs-dev] [PATCH v3 07/12] dpif-netdev: Cache align netdev_flow_keys.

> On Oct 19, 2016, at 10:01 AM, Joe Stringer wrote: > > On 14 October 2016 at 07:37, Bhanuprakash Bodireddy > wrote: >> Aligning the 'keys' array seems to have positive performance impact. >> >> Signed-off-by: Bhanuprakash Bodireddy >> Co-authored-by: Antonio Fischetti >> Signed-off-by: Anto

Re: [ovs-dev] [PATCH] Makefile.am: Add DocumentationStyle.rst to distribution.

> On Oct 19, 2016, at 7:25 AM, Russell Bryant wrote: > > > > On Tue, Oct 18, 2016 at 7:59 PM, Jarno Rajahalme > wrote: > Compile fails otherwise. > > Signed-off-by: Jarno Rajahalme mailto:ja...@ovn.org>> > --- > Makefile.am | 1 + > 1 file changed, 1 insertion(+) > >

Re: [ovs-dev] [PATCH] ovn-test: Fix 'test-ovn composition' crash

On Tue, Oct 11, 2016 at 12:33:22PM -0700, Andy Zhou wrote: > Without this fix, the added test will core dump. > > Signed-off-by: Andy Zhou Thanks! Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/de

Re: [ovs-dev] [PATCH] fedora: do not restart the service on a pkg upgrade

On Tue, Oct 18, 2016 at 1:04 PM, Flavio Leitner wrote: > There is no reliable way to restore the previous networking > state after a service restart. Many things like firewall > configuration, traffic shaping, stacked devices, custom setups > are completely out of OVS control. > > The OVS might b

Re: [ovs-dev] [PATCH net-next v2 0/2] openvswitch: remove unused code

From: Jiri Benc Date: Wed, 19 Oct 2016 11:26:35 +0200 > Removed unused functions and unnecessary EXPORT_SYMBOLs from openvswitch. Series applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 15/15] ovsdb-idl: Check internal graph in OVSDB tests.

On Mon, Oct 17, 2016 at 01:44:03PM -0700, Andy Zhou wrote: > On Wed, Oct 5, 2016 at 8:16 PM, Ben Pfaff wrote: > > > Some upcoming tests will add extra trickiness to the IDL internal graph. > > This worries me, because the IDL doesn't have any checks for its graph > > consistency. This commit add

Re: [ovs-dev] [PATCH] tnl-ports: fix missing netdev_close

On Fri, Oct 14, 2016 at 7:12 AM, Thadeu Lima de Souza Cascardo wrote: > There were leaks on netdev_close references. Whenever an address was removed > from an interface, it was possible that a race would make the netlink message > be > processed and no address be found on the interface, causing i

Re: [ovs-dev] [PATCH net-next v2 1/2] openvswitch: remove unused functions

On Wed, Oct 19, 2016 at 2:26 AM, Jiri Benc wrote: > ovs_vport_deferred_free is not used anywhere. It's the only caller of > free_vport_rcu thus this one can be removed, too. > > Signed-off-by: Jiri Benc Acked-by: Pravin B Shelar ___ dev mailing list d

Re: [ovs-dev] [PATCH net-next v2 2/2] openvswitch: remove unnecessary EXPORT_SYMBOLs

On Wed, Oct 19, 2016 at 2:26 AM, Jiri Benc wrote: > Some symbols exported to other modules are really used only by > openvswitch.ko. Remove the exports. > > Tested by loading all 4 openvswitch modules, nothing breaks. > > Signed-off-by: Jiri Benc Acked-by: Pravin B Shelar __

[ovs-dev] [PATCH] datapath: compat: tunnel: Check if device is UP.

On upstream kernel datapath OVS make use of networking devices where networking stack does check if device is UP. following patch adds same check in case of compat tunneling implementation. This check also fixes kernel crash in case vxlan device was brought down by user. CPU: 4 PID: 12988 Comm: ha

[ovs-dev] [PATCH v12 rebased 1/3] userspace: add support for pop_eth and push_eth actions

From: Lorand Jakab These actions will allow L2->L3 and L3->L2 switching, and are supposed to be added to flows installed in the datapath transparently by ovs-vswitchd. Signed-off-by: Lorand Jakab Signed-off-by: Simon Horman Signed-off-by: Jiri Benc --- v12 [Simon Horman] * Rebase * Provide c

[ovs-dev] [PATCH v12 rebased 3/3] userspace: add non-tap (l3) support to GRE vports

From: Simon Horman Add support for layer 3 GRE vports (non-tap aka non-VTEP). This makes use of a vport mode configuration for the existing (tap/VTEP) GRE vports. In order to differentiate packets for two different types of GRE vports a new flow key attribute, OVS_KEY_ATTR_NEXT_BASE_LAYER, is u

[ovs-dev] [PATCH v12 rebased 2/3] userspace: add layer 3 flow and switching support

From: Lorand Jakab This commit relaxes the assumption that all packets have an Ethernet header, and adds support for layer 3 flows. For each packet received on the Linux kernel datapath the l2 and l3 members of struct ofpbuf are intialized appropriately, and some functions now expect this (notab

[ovs-dev] [PATCH v12 rebased 0/3] userspace: Support for layer 3 encapsulated packets

This is a rebase of Simon's submission from July on top of the current master. It is not intended to be applied yet but to help testing of the kernel part. The rebase was straightforward, the differences are: * Accomodated changes made by aff49b8c66be ("meta-flow: Clean up masking with prerequi

Re: [ovs-dev] [PATCH v3 07/12] dpif-netdev: Cache align netdev_flow_keys.

On 14 October 2016 at 07:37, Bhanuprakash Bodireddy wrote: > Aligning the 'keys' array seems to have positive performance impact. > > Signed-off-by: Bhanuprakash Bodireddy > Co-authored-by: Antonio Fischetti > Signed-off-by: Antonio Fischetti > Acked-by: Daniele Di Proietto It looks like the

Re: [ovs-dev] [PATCH net-next v12 0/9] openvswitch: support for layer 3 encapsulated packets

On Tue, 18 Oct 2016 22:11:21 -0700, Pravin Shelar wrote: > I have not finished the review yet, but most of patches looks good to > me. Can you send userspace patches against latest master so that I can > try the patches with tunnel setup? Will do in a few minutes. Thanks for the review, Jiri __

Re: [ovs-dev] [PATCH net-next v12 9/9] openvswitch: use ipgre tunnel rather than gretap tunnel

On Tue, 18 Oct 2016 22:14:06 -0700, Pravin Shelar wrote: > This is OVS tunnel compatibility code. We are not suppose to add new > features to compat code. Just provide a way to configure such device > over rtnl. Makes sense. Please consider this a test-only patch for now. I won't include it in v13

Re: [ovs-dev] [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

On Tue, 18 Oct 2016 22:13:45 -0700, Pravin Shelar wrote: > On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > > - skb_reset_network_header(skb); > > + skb->protocol = parse_ethertype(skb); > > I am not sure about changing skb->protocol here. > By changing this skb loosing inf

Re: [ovs-dev] OVS 2.6.1 release?

> On Oct 19, 2016, at 5:55 PM, Thadeu Lima de Souza Cascardo > wrote: > >> On Tue, Oct 18, 2016 at 05:35:27PM +0200, Justin Pettit wrote: >> On Oct 18, 2016, at 5:31 PM, Russell Bryant wrote: > On Tue, Oct 18, 2016 at 4:54 AM, Justin Pettit wrote: >> On Oct 17, 2016, at 5:

Re: [ovs-dev] OVS 2.6.1 release?

On Tue, Oct 18, 2016 at 05:35:27PM +0200, Justin Pettit wrote: > > > On Oct 18, 2016, at 5:31 PM, Russell Bryant wrote: > > > >> On Tue, Oct 18, 2016 at 4:54 AM, Justin Pettit wrote: > >> > On Oct 17, 2016, at 5:54 PM, Ben Pfaff wrote: > >> > > >> >> On Mon, Oct 17, 2016 at 09:14:33AM -0400, R

Re: [ovs-dev] [PATCH] ovn: fix build on FreeBSD

On Wed, Oct 19, 2016 at 01:32:57PM -0200, Thadeu Lima de Souza Cascardo wrote: > The missing include was needed for struct in6_addr. > > Otherwise, this build failure would occur. > > In file included from ovn/lib/actions.c:23: > ovn/lib/ovn-dhcp.h:163:21: error: field has incomplete type 'struct

[ovs-dev] [PATCH] ovn: fix build on FreeBSD

The missing include was needed for struct in6_addr. Otherwise, this build failure would occur. In file included from ovn/lib/actions.c:23: ovn/lib/ovn-dhcp.h:163:21: error: field has incomplete type 'struct in6_addr' Signed-off-by: Thadeu Lima de Souza Cascardo --- Needed for 2.6 branch as wel

Re: [ovs-dev] [PATCH ovs RFC 0/9] Introducing HW offload support for openvswitch

On 12/10/2016 23:36, Pravin Shelar wrote: Sorry for jumping in a bit late. I have couple of high level comments below. On Thu, Oct 6, 2016 at 10:10 AM, Rony Efraim wrote: From: Joe Stringer [mailto:j...@ovn.org] Sent: Thursday, October 06, 2016 5:06 AM Subject: Re: [ovs-dev] [PATCH ovs RF

[ovs-dev] build failure with DPDK on Ubuntu 16.04 with GCC 5.4

Hi, I met an issue when building OVS with DPDK on Ubuntu 16.04, the commit ID is as below, also I'm using DPDK R16.11 RC1 commit ID: commit fed622dfd90ffc754808ecb464d7e62e77f0da58. We can pass build on Fedora 23 but can't pass build on Ubuntu 16.04, kernel: 4.4, gcc: 5.4. Could anyone help che

Re: [ovs-dev] packets getting dropped in vhostuser port

There seem to be some version dependency between the two. dpdk-16.04 with ovs2.6 is not possible as ovs is referencing some newer dpdk code. i tried the reverse, dpdk16.07 and ovs2.5.9, but getting the following error (rpm based build) + cd dpdk + make config T=x86_64-atm-linuxapp-gcc make[1]: **

Re: [ovs-dev] [PATCH] doc: fix bad link to dpdk advance installation guide

On Wed, Oct 19, 2016 at 5:30 AM, Stephen Finucane wrote: > On 2016-10-18 22:23, Mauricio Vasquez B wrote: > >> The link was pointing to a wrong place after the file was converted to >> rst. >> >> Fixes: 167703d664fc ("doc: Convert INSTALL.DPDK to rST") >> >> Signed-off-by: Mauricio Vasquez B >>

Re: [ovs-dev] [PATCH] Makefile.am: Add DocumentationStyle.rst to distribution.

On Tue, Oct 18, 2016 at 7:59 PM, Jarno Rajahalme wrote: > Compile fails otherwise. > > Signed-off-by: Jarno Rajahalme > --- > Makefile.am | 1 + > 1 file changed, 1 insertion(+) > Sorry about that. I went ahead and applied this to unbreak master. -- Russell Bryant __

Re: [ovs-dev] packets getting dropped in vhostuser port

One suggestion, could you keep dpdk as dpdk-16.04, only ovs upgrade, then see if the case still happen. Or you can keep only dpdk changed but no OVS change. We need to narrow down the issue. From my knowledge, qemu-2.4.1 is fine for the case. -Original Message- From: dev [mailto:dev-bo

[ovs-dev] Ovenvswitch with 802.3ax (Multi-Chassis Link Aggregation Protocol)

Hello, I don’t know where I can ask my question, so I did it here. In our infrastructure we would like to build VXLAN tunnel between our datacenters and we use Openvswitch for that. The main issue we are now facing is the High Availability. We’ve already try a solution with keepalived to do ac

[ovs-dev] packets getting dropped in vhostuser port

Hi, In a PHY-VM-PHY setup, i was using dpdk16.04 + OVS 2.5.90 + qemu 2.4.1, everything was working fine. When i upgraded to dpdk 16.07 + ovs 2.6 (branch-2.6) without any change to the setup/configuration; now all the packets(1200B) are getting dropped at vhostuser ports. Though, i am able to send

Re: [ovs-dev] [PATCH RFC v1] ovn: add SLAAC support for IPv6

On Wed, Jul 27, 2016 at 11:04:55PM -0700, Ben Pfaff wrote: > The commit message here is so detailed that I can't figure out what the > actual goal is. What is SLAAC and how does it benefit the user or > administrator? I apologies for necro-posting, but Router Advertisement in not only about addres

Re: [ovs-dev] [PATCH] doc: fix bad link to dpdk advance installation guide

On 2016-10-18 22:23, Mauricio Vasquez B wrote: The link was pointing to a wrong place after the file was converted to rst. Fixes: 167703d664fc ("doc: Convert INSTALL.DPDK to rST") Signed-off-by: Mauricio Vasquez B I don't know the custom on the OVS dev mailing list, but... Reviewed-by: Ste

[ovs-dev] [PATCH net-next v2 2/2] openvswitch: remove unnecessary EXPORT_SYMBOLs

Some symbols exported to other modules are really used only by openvswitch.ko. Remove the exports. Tested by loading all 4 openvswitch modules, nothing breaks. Signed-off-by: Jiri Benc --- v2: ovs_vport_deferred_free is completely removed by the first patch --- net/openvswitch/datapath.c |

[ovs-dev] [PATCH net-next v2 0/2] openvswitch: remove unused code

Removed unused functions and unnecessary EXPORT_SYMBOLs from openvswitch. Jiri Benc (2): openvswitch: remove unused functions openvswitch: remove unnecessary EXPORT_SYMBOLs net/openvswitch/datapath.c | 2 -- net/openvswitch/vport-netdev.c | 1 - net/openvswitch/vport.c| 17

[ovs-dev] [PATCH net-next v2 1/2] openvswitch: remove unused functions

ovs_vport_deferred_free is not used anywhere. It's the only caller of free_vport_rcu thus this one can be removed, too. Signed-off-by: Jiri Benc --- new in v2 --- net/openvswitch/vport.c | 16 net/openvswitch/vport.h | 1 - 2 files changed, 17 deletions(-) diff --git a/net/ope

Re: [ovs-dev] [PATCH net-next] openvswitch: remove unnecessary EXPORT_SYMBOLs

On Tue, 18 Oct 2016 12:48:33 -0700, Pravin Shelar wrote: > ovs_vport_deferred_free() is not used anywhere. can you remove it? Good point. Will do. Jiri ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] OVS 2.6.1 release?

> On Oct 19, 2016, at 7:14 AM, Pravin Shelar wrote: > >> On Tue, Oct 18, 2016 at 8:35 AM, Justin Pettit wrote: >> On Oct 18, 2016, at 5:31 PM, Russell Bryant wrote: > On Tue, Oct 18, 2016 at 4:54 AM, Justin Pettit wrote: >> On Oct 17, 2016, at 5:54 PM, Ben Pfaff wrote: >>

[ovs-dev] ZMPKWVWDKZICH

Message could not be delivered ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 01/12] dpcls: Use 32 packet batches for lookups.

Thanks Jarno for spotting this, will do the suggested change. Antonio > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jarno > Rajahalme > Sent: Tuesday, October 18, 2016 6:26 PM > To: Bodireddy, Bhanuprakash > Cc: dev@openvswitch.org > Subject: Re: [ovs