Re: [ovs-dev] [PATCH 2/3] rstp: fix memory leak reported by valgrind

2016-01-11 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 01:38:42PM -0800, William Tu wrote: > test case: 1650 RSTP Single bridge, call stacks > hmap_insert_at (hmap.h:235) > rstp_port_set_port_number__ (rstp.c:744) > rstp_add_port (rstp.c:1164) > new_bridge (test-rstp.c:123) > test_rstp_main (test-rstp.c:514)

Re: [ovs-dev] [PATCH 2/3] rstp: fix memory leak reported by valgrind

2016-01-07 Thread Daniele Venturino
Maybe we could destroy the hmap with the mutex still locked. Anyway, looks good to me. Acked-by: Daniele Venturino > > Il giorno 05 gen 2016, alle ore 22:38, William Tu ha > scritto: > > test case: 1650 RSTP

[ovs-dev] [PATCH 2/3] rstp: fix memory leak reported by valgrind

2016-01-05 Thread William Tu
test case: 1650 RSTP Single bridge, call stacks hmap_insert_at (hmap.h:235) rstp_port_set_port_number__ (rstp.c:744) rstp_add_port (rstp.c:1164) new_bridge (test-rstp.c:123) test_rstp_main (test-rstp.c:514) ovstest_wrapper_test_rstp_main__ (test-rstp.c:714)