[GitHub] [orc] belugabehr commented on pull request #714: ORC-812: Simplify getClosestBufferSize in Writer

2021-06-09 Thread GitBox
belugabehr commented on pull request #714: URL: https://github.com/apache/orc/pull/714#issuecomment-857703731 Hey @pgaref You'll have to pull out pen-and-paper and play with it :) `<< 1` simply doubles the value. We're not interested in doubling, we're interesting in finding the nex

[GitHub] [orc] belugabehr commented on pull request #714: ORC-812: Simplify getClosestBufferSize in Writer

2021-06-09 Thread GitBox
belugabehr commented on pull request #714: URL: https://github.com/apache/orc/pull/714#issuecomment-857690375 @pgaref Also, for a sanity check, I ran this locally: ```java public static int bs(int bs) { final int kb4 = 4 * 1024; final int kb256 = 256 * 1024;

[GitHub] [orc] belugabehr commented on pull request #714: ORC-812: Simplify getClosestBufferSize in Writer

2021-06-08 Thread GitBox
belugabehr commented on pull request #714: URL: https://github.com/apache/orc/pull/714#issuecomment-857135876 @pgaref This is already covered by `TestOrcWideTable`. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t