Re: apr_table_compress

2003-08-19 Thread Geoffrey Young
Joe Schaefer wrote: Geoffrey Young <[EMAIL PROTECTED]> writes: [...] +=item * compress() + + overlap($table, $flags); + +Compress the data in C<$table>. better: Converts multi-valued keys in C<$table> to single-valued keys. ok + +param C<$table>: The table to add the data to. + ^^^

Re: apr_table_compress

2003-08-19 Thread Geoffrey Young
Ah, of course, now I remember why I did that, thanks ;). Should we pass two arguments? the perl function and the C function? modperl_apr_func_not_implemented(timeout_get, apr_socket_timeout_get, 2.0.40, 0.9.0); I'd probably stick with one or the other, but not both. --Geoff --

Re: apr_table_compress

2003-08-19 Thread Joe Schaefer
Geoffrey Young <[EMAIL PROTECTED]> writes: [...] > +=item * compress() > + > + overlap($table, $flags); > + > +Compress the data in C<$table>. better: Converts multi-valued keys in C<$table> to single-valued keys. > + > +param C<$table>: The table to add the data to. > +

Re: apr_table_compress

2003-08-19 Thread Stas Bekman
Geoffrey Young wrote: Ah, of course, now I remember why I did that, thanks ;). Should we pass two arguments? the perl function and the C function? modperl_apr_func_not_implemented(timeout_get, apr_socket_timeout_get, 2.0.40, 0.9.0); I'd probably stick with one or the other, but not both. repo

Re: APR/AP => MP sync

2003-08-19 Thread Stas Bekman
Geoffrey Young wrote: we really ought to pin down exactly how far back we are going to support httpd/apr. since we're not 2.0 yet, we should probably just pick a version to support going forward. for instance, I'm not sure it makes sense to support 2.0.40 anymore - the back-compat stuff is st

Re: apr_table_compress

2003-08-19 Thread Geoffrey Young
I'd suggest to change the argument to modperl_apr_func_not_implemented to be the httpd version and the apr version, so we can have: #define modperl_apr_func_not_implemented(func, httpd_ver, apr_ver) \ { \ dTHX; \ Perl_croak(aTHX_ #func "() requires httpd/" #httpd_ver "and apr/" #ver "or higher")

Re: apr_table_compress

2003-08-19 Thread Geoffrey Young
-modperl_apr_func_not_implemented(timeout_get, 0.9.0); + modperl_apr_func_not_implemented(timeout_get, 2.0.40, 0.9.0); return APR_ENOTIMPL; } +modperl_apr_func_not_implemented(apr_socket_timeout_get, 2.0.40, 0.9.0); yeah, I thought about that. the reason I kept it the way it was is bec

Re: APR/AP => MP sync

2003-08-19 Thread Geoffrey Young
Stas Bekman wrote: Geoff, So as discussed earlier we need to verify which methods have changed. I think Doug has some tools to do that in util/build. However it could be easier to look up all the deprecated functions, which will also tell their replacements. I've already coded some of the ch

Re: mod_perl 1.99_09 core dumps

2003-08-19 Thread Stas Bekman
Thanks for your patience Hans-Ruodi. Now we have a loop closed, you get the same backtrace you did back in June: http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=105615118503625&w=2 Philippe reported that he knows what the bug is: http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=10564491852

Re: [mp2] bugs in ...

2003-08-19 Thread Stas Bekman
Sreeji K Das wrote: Just wanted to make sure this too is in the TODO: 1) Recursive sections: http://www.gossamer-threads.com/archive/mod_perl_C1/dev_F4/%5BMP2_-_BUG_%5D_Issue_handing_Apache_config._error_messages_P70501/ and http://mathforum.org/epigone/modperl/dartrimpcil 2) PassEnv/SetEnv pro

Re: apr_table_compress

2003-08-19 Thread Stas Bekman
Geoffrey Young wrote: -modperl_apr_func_not_implemented(timeout_get, 0.9.0); + modperl_apr_func_not_implemented(timeout_get, 2.0.40, 0.9.0); return APR_ENOTIMPL; } +modperl_apr_func_not_implemented(apr_socket_timeout_get, 2.0.40, 0.9.0); yeah, I thought about that. the reason I kept

Re: [PATCH mp1.28] Clean up file uploaded by test suite

2003-08-19 Thread Stas Bekman
Steve Hay wrote: Stas Bekman wrote: Steve Hay wrote: [...] I can't find in the CGI.pm manpage It's right after the bit that you quoted :-) Lines 4439-4442 in the CGI.pm of 2.97. , where it says that the filehandle should be closed, even on windows. Perhaps ask Lincoln? Sorry, I don't und

Re: apr_table_compress

2003-08-19 Thread Stas Bekman
Geoffrey Young wrote: I'd suggest to change the argument to modperl_apr_func_not_implemented to be the httpd version and the apr version, so we can have: #define modperl_apr_func_not_implemented(func, httpd_ver, apr_ver) \ { \ dTHX; \ Perl_croak(aTHX_ #func "() requires httpd/" #httpd_ver "and a

Re: [PATCH mp1.28] Clean up file uploaded by test suite

2003-08-19 Thread Steve Hay
Stas Bekman wrote: Steve Hay wrote: [...] I can't find in the CGI.pm manpage It's right after the bit that you quoted :-) Lines 4439-4442 in the CGI.pm of 2.97. , where it says that the filehandle should be closed, even on windows. Perhaps ask Lincoln? Sorry, I don't understand. I said:

Re: [PATCH mp1.28] Clean up file uploaded by test suite

2003-08-19 Thread Stas Bekman
Steve Hay wrote: [...] I can't find in the CGI.pm manpage It's right after the bit that you quoted :-) Lines 4439-4442 in the CGI.pm of 2.97. , where it says that the filehandle should be closed, even on windows. Perhaps ask Lincoln? Sorry, I don't understand. I said: I can't find in the C

RE: mod_perl 1.99_09 core dumps

2003-08-19 Thread Hans-Ruodi Burch (EA/EAS)
Hi Stas > > [EMAIL PROTECTED] gdb -core /home/tms/mod_perl-1.99_09/t/core > > GNU gdb 5.0 > > Copyright 2000 Free Software Foundation, Inc. > > GDB is free software, covered by the GNU General Public License, and you are > > welcome to change it and/or distribute copies of it under certain condit

Re: [PATCH mp1.28] Clean up file uploaded by test suite

2003-08-19 Thread Steve Hay
Stas Bekman wrote: Steve Hay wrote: Stas Bekman wrote: Steve Hay wrote: Hi, After running the test suite with mp1.28 on Windows I find that I have a temporary file left behind in my temp dir (in my case, C:\Temp). This happens because the filehandle is left open. The attached patch closes