Re: [mp1 Patch] Apache::Test support

2003-08-22 Thread Stas Bekman
Philippe M. Chiasson wrote: this patch allow's mod_perl's Makefile.PL to detect if Apache::Test is installed and switch over to if for it's tests. It means apxs/dso builds can now make tests like everything else. I suspect this would also kinda work under win32 (possibly with small tweaks). If

[mp1 Patch] Apache::Test support

2003-08-22 Thread Philippe M. Chiasson
this patch allow's mod_perl's Makefile.PL to detect if Apache::Test is installed and switch over to if for it's tests. It means apxs/dso builds can now make tests like everything else. I suspect this would also kinda work under win32 (possibly with small tweaks). If Apache::Test isn't found, i

cleaning up the logging interface

2003-08-22 Thread Stas Bekman
Currently we have quite a mess with various ways one can do logging in mp2. This thread started to tackle this issue, but we really have to decide what we support and what not and cut the unwanted methods early. http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=102456650614151&w=2 ___

Re: [patch] fixing the %ENV setting logic, breaking 'SetHandler modperl'a bit

2003-08-22 Thread Stas Bekman
Anybody? This was first posted 6 months ago. I'm reposting with an updated patch. The current modperl-2.0 cvs has two problems with setting %ENV: 1. If PerlOptions +SetupEnv is not set, it sets the env too late (only for the 'perl-script' response handlers). pre-response handlers don't get the

Re: MPM name

2003-08-22 Thread Stas Bekman
Kermit Tensmeyer wrote: quick followup fresh virgin install yeilds the same error try again with the current cvs without MP_APXS, it should work. Slowly getting there, but it's pure perl, patches are very welcome adding MP_APXS to .makepl_args.mod_perl2 resolves -that- issue. It doesn't make s

Re: ModPerl2/Apache2 - Error handling return codes -RegistryCooker.pm:"Argument""isn'tnumeric ...& bottom of web page say:OK the server encounteredaninternal.....

2003-08-22 Thread Stas Bekman
Adolph Torres wrote: Hello Stan, Nice mesg'g: A RegistryCooker.pm edit took and the server started fine - yet when I'm executing a cookie script (noted below) I'm gettting the "Dude, your just killed $r!(/var/www/sec/cooky)" Same with the other .pl's. Thanks Adolph, now it's time for y

Re: ModPerl2/Apache2 - Error handling return codes -RegistryCooker.pm:"Argument""isn't numeric ...& bottom of web page say:OK the server encounteredaninternal.....

2003-08-22 Thread Adolph Torres
Hello Stan,   Nice mesg'g:  A RegistryCooker.pm edit took and the server started fine - yet when I'm executing  a cookie script (noted below) I'm gettting the "Dude, your just killed $r!(/var/www/sec/cooky)"   Same with the other .pl's.   Best Regards,Adolph Torres[EMAIL PROTECTED]   cooky.pl

Re: minimum supported httpd version

2003-08-22 Thread Geoffrey Young
just for clarity, the problem was in removing these lines if ($count > 10) { $filter->seen_eos(1); } which, according to the comments, should be unnecessary in 2.0.46. go ahead and commit the rest ok. I'll commit the patch as it and will correct the filter macro in

Re: minimum supported httpd version

2003-08-22 Thread Stas Bekman
# this is not needed in newer Apache versions, however older -# versions (2.0.40) will repeatedly call this filter, waiting +# versions (2.0.46) will repeatedly call this filter, waiting # for EOS which will never come from this filter so, after # several

Re: minimum supported httpd version

2003-08-22 Thread Stas Bekman
but the problem doesn't happen with 2.0.46, only in 2.0.40. why s/2.0.40/2.0.46/? well, if it's not reproducable then we'll remove that comment and code alltogether. if it is reproducable, then it affects 2.0.46 :) got it reproduced, needed to comment out the endless looping protection.

Re: minimum supported httpd version

2003-08-22 Thread Geoffrey Young
Stas Bekman wrote: Geoffrey Young wrote: yeah, that's a consideration. I've cleaned up the code to remove all back-compat stuff for versions prior to 2.0.46. I'll let it run through my nightly builds and see how it went tomorrow. everything looks ok, with the exception of t/filter/TestFi

Re: minimum supported httpd version

2003-08-22 Thread Stas Bekman
Geoffrey Young wrote: yeah, that's a consideration. I've cleaned up the code to remove all back-compat stuff for versions prior to 2.0.46. I'll let it run through my nightly builds and see how it went tomorrow. everything looks ok, with the exception of t/filter/TestFilter/in_str_consume.pm

Re: ModPerl2/Apache2 - Error handling return codes -RegistryCooker.pm:"Argument""isn't numeric ...& bottom of web page say:OK the server encounteredaninternal.....

2003-08-22 Thread Stas Bekman
Adolph Torres wrote: Fri Aug 22 10:37:59 PDT 2003 Hello again, Here is the result of those edits on this system. And I'm more than willing to continue working this if you would like - but had to back it out as you'll see below. Adolph Torres [EMAIL PROTECTED] ---

Re: ModPerl2/Apache2 - Error handling return codes -RegistryCooker.pm:"Argument"" isn't numeric ...& bottom of web page say:OK the server encounteredaninternal .....

2003-08-22 Thread Adolph Torres
Fri Aug 22 10:37:59 PDT 2003Hello again,Here is the result of those edits on this system.  And I'm more than willing to continue working this if you would like - but had to back it out as you'll see below. Adolph Torres[EMAIL PROTECTED]

Re: minimum supported httpd version

2003-08-22 Thread Geoffrey Young
yeah, that's a consideration. I've cleaned up the code to remove all back-compat stuff for versions prior to 2.0.46. I'll let it run through my nightly builds and see how it went tomorrow. everything looks ok, with the exception of t/filter/TestFilter/in_str_consume.pm, which hangs even thoug

Re: mp2 make test errors with current CVS on NetBSD 1.6.1/i386/perl5.8.0

2003-08-22 Thread Stas Bekman
Doesn't the doc at http://perl.apache.org/bugs/ mention the need to send the relevant chunks of the t/logs/error_log file? !!! error running tests (please examine t/logs/error_log) *** Error code 1 Stop. make: stopped in /data/src/modperl-2.0 __

Re: ModPerl2/Apache2 - Error handling return codes -RegistryCooker.pm:"Argument"" isn't numeric ...& bottom of web page say:OK the server encounteredaninternal .....

2003-08-22 Thread Stas Bekman
I'd still like to resolve this issue, here is the minimalistic registry script that reproduces the problem: local (*in) = @_; $in = 5; this gets wrapped as: sub handler { local (*in) = @_; $in = 5; } and then called as: handler($r); so the above code corrupts the guts $r, while keeping it