heh, revistited... it never was about current_callback. my bad :)
Stas Bekman wrote:
After enabling 'PerlSwitches -w' a few new "Use of uninitialized
variable" warnings have popped up. One of them was due to this
child_exit() handler:
sub ModPerl::Test::exit_handler {
my($p, $s) = @_;
After enabling 'PerlSwitches -w' a few new "Use of uninitialized variable"
warnings have popped up. One of them was due to this child_exit() handler:
sub ModPerl::Test::exit_handler {
my($p, $s) = @_;
$s->log->info("Child process pid=$$ is exiting");
}
which didn't return a value. It actu
Geoffrey Young wrote:
should be just a matter of setting PerlSwitches -w in the test suite
(though who knows what that will start doing :)
Yup, it reveals a few more issues with undef. I'm looking at it.
I'll commit that change a bit later.
ok, I'll leave it to you, then.
I meant the -w chan
Randy Kobes wrote:
also we should probably add IPC::Run3 to lib/Bundle/Apache2.pm.
OK ... I also seem to remember that it would be better,
within Apache::TestSmoke, to do a
eval {require IPC::Run3; }
and die if not there, rather than
use IPC::Run3;
Should I do that?
You are right, I re
should be just a matter of setting PerlSwitches -w in the test suite
(though who knows what that will start doing :)
Yup, it reveals a few more issues with undef. I'm looking at it.
I'll commit that change a bit later.
ok, I'll leave it to you, then.
the only thing I would suggest is to rever
On Thu, 9 Oct 2003, Stas Bekman wrote:
> works fine on linux, +1 to commit sans 'print $log', and
> probably it'd be a good idea to add a comment to why:
>
> Win32::Process::Create($obj,
> $httpd,
> "$cmd $one_process",
>
Geoffrey Young wrote:
What I meant is this:
if (count != 1) {
status = OK;
}
else {
SV* status_sv = POPs;
if (status_sv == &PL_sv_undef) {
/* ModPerl::Util::exit returns undef */
status = OK;
}
Geoffrey Young wrote:
have you reversed the POPs change?
of course
Here is the original report:
http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=106505218031357&w=2
yes, you did leave out the configuration information :)
oops, I was sure that what was important is 'use warnings' in the t
here are some tests so that no matter which way the issue is resolved, we at
least know things are working properly.
--Geoff
[EMAIL PROTECTED] wrote:
geoff 2003/10/09 11:40:31
Added: t/response/TestModperl status.pm
t/modperl status.t
Log:
add tests for handler
What I meant is this:
if (count != 1) {
status = OK;
}
else {
SV* status_sv = POPs;
if (status_sv == &PL_sv_undef) {
/* ModPerl::Util::exit returns undef */
status = OK;
}
else {
Geoffrey Young wrote:
no, I was talking about the change I did to fix the undef-on-exit
problem (i.e. replacing POPi with POPs)
ok. I didn't see how to fix the undef warning with POPi, though, since
it's undocumented what POPi returns when the stack is undef, and whether
it will always comp
have you reversed the POPs change?
of course
Here is the original report:
http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=106505218031357&w=2
yes, you did leave out the configuration information :)
it turns out the user told us exactly what the reproducability problem is -
PerlSwitches -w
Geoffrey Young wrote:
indeed. can you post the script? I'll take a look at it too and see
if I can figure out a way to reproduce it as well.
package CGItest;
sorry, I wasn't able to reproduce the warning with that script. maybe
it's something else?
have you reversed the POPs change? Here
Steve Hay wrote:
I notice that running tests via nmake test, t/TEST or t/SMOKE leaves a
httpd.pid file behind in t/logs after the server has stopped. Is this
supposed to happen? I thought Apache normally deleted the httpd.pid
file when it is stopped.
That's not under Apache-Test's control, it'
indeed. can you post the script? I'll take a look at it too and see
if I can figure out a way to reproduce it as well.
package CGItest;
sorry, I wasn't able to reproduce the warning with that script. maybe it's
something else?
no, I was talking about the change I did to fix the undef-on-
Steve Hay wrote:
Steve Hay wrote:
Randy Kobes wrote:
That's right - I think it was in the way the server was
started in Apache::TestServer. Here's a diff that seems
to work, using IPC::Run3; I've tested it both with t/SMOKE
and t/TEST, on Win32. Note that I left the "print $log;"
statements in th
Randy Kobes wrote:
On Wed, 8 Oct 2003, Stas Bekman wrote:
Stas Bekman wrote:
... You should be able then to reproduce
this outside Apache-Test, just doing:
httpd > /dev/null &
and then trying to run requests on it, should reproduce the problem.
It's probably should be reproducable by a simple a
So, for now, users have to resort to
using this syntax (note the extra space):
The following patch fixes this little problem:
whee!
:)
--Geoff
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL
I notice that running tests via nmake test, t/TEST or t/SMOKE leaves a
httpd.pid file behind in t/logs after the server has stopped. Is this
supposed to happen? I thought Apache normally deleted the httpd.pid
file when it is stopped.
I also find that if there is such a httpd.pid file in place
Steve Hay wrote:
Randy Kobes wrote:
That's right - I think it was in the way the server was
started in Apache::TestServer. Here's a diff that seems
to work, using IPC::Run3; I've tested it both with t/SMOKE
and t/TEST, on Win32. Note that I left the "print $log;"
statements in there, just to see
Randy Kobes wrote:
That's right - I think it was in the way the server was
started in Apache::TestServer. Here's a diff that seems
to work, using IPC::Run3; I've tested it both with t/SMOKE
and t/TEST, on Win32. Note that I left the "print $log;"
statements in there, just to see the progress while
On Wed, 8 Oct 2003, Stas Bekman wrote:
> Stas Bekman wrote:
> > ... You should be able then to reproduce
> > this outside Apache-Test, just doing:
> >
> > httpd > /dev/null &
> >
> > and then trying to run requests on it, should reproduce the problem.
>
> It's probably should be reproducable by a
22 matches
Mail list logo
