Re: [Patch] Support for argument-less blocks

2003-10-10 Thread Stas Bekman
Philippe M. Chiasson wrote: With apache-1.3, mod_perl users were able to do: some code in httpd-2.0, the configuration parser doesn't like container directives with no arguments (Syntax error on line nn of httpd.conf: directive missing closing '>'). So, for now, users have to resort to using

Re: current_callback return status revisited

2003-10-10 Thread Geoffrey Young
Stas Bekman wrote: Geoffrey Young wrote: So something like this? [...] looks remarkably similar to something I proposed, so sure (with comments, of course :) Hmm, I did say that: yes, I know. I was just kidding :) --Geoff

Re: current_callback return status revisited

2003-10-10 Thread Stas Bekman
Geoffrey Young wrote: So something like this? [...] looks remarkably similar to something I proposed, so sure (with comments, of course :) Hmm, I did say that: So here is the version which seems to be cool, same as your original patch, plus returning 500 if it's not IV/PV/undef. glad to finally h

Re: [PATCH mp2] quotemeta directory in regex

2003-10-10 Thread Stas Bekman
Steve Hay wrote: Attached a little patch to stop this happening when running "perl t/TEST ...": = C:\Temp\modperl-2.0>perl t/TEST modperl\post_utf8 *** server localhost:8529 shutdown C:\apache2/bin/Apache.exe -d C:/Temp/modperl-2.0/t -f C:/Temp/modperl-2.0/t/conf/httpd.conf -DAPACHE2 -DPERL_

Re: current_callback return status revisited

2003-10-10 Thread Geoffrey Young
> So something like this? if (SvIOK(status_sv)) { status = SvIVX(status_sv); } else if (status_sv == &PL_sv_undef) { status = OK; } else if (SvPOK(status_sv)) { status = SvIVx(status_sv);

Re: current_callback return status revisited

2003-10-10 Thread Stas Bekman
Geoffrey Young wrote: heh, revistited... it never was about current_callback. my bad :) Stas Bekman wrote: After enabling 'PerlSwitches -w' a few new "Use of uninitialized variable" warnings have popped up. One of them was due to this child_exit() handler: sub ModPerl::Test::exit_handler {

should directive handlers return status?

2003-10-10 Thread Stas Bekman
I was hunting those 'Uninitialized...' warnings and had to break at Perl_report_uninit in order to figure out where they come from, since there was no other way to figure out whose fault it was. So the next warning I found was coming from one of the directive handlers with: if (count == 1)

Re: Testing and smoking leave a PID file behind

2003-10-10 Thread Randy Kobes
On Fri, 10 Oct 2003, Steve Hay wrote: [ ... ] > I don't know how to do the "graceful" stop, though. What > we want is a bit like trying TERM then KILL on Unix, but > that doesn't work on Win32 -- see the entry for kill() in > the perlport manpage! Win32::Process doesn't have any > "graceful" kil

Re: early perl startup in vhost on win32

2003-10-10 Thread Steve Hay
Steve Hay wrote: It seems to fall over at line 19 of the new t/htdocs/vhost/startup.pl -- the line "PerlModule TestVhost::basic" in $conf. I tried adding "use TestVhost::basic" before the "$s->add_config([split /\n/, $conf]);" call, but that made no difference. I don't know if this is useful t

Re: early perl startup in vhost on win32

2003-10-10 Thread Steve Hay
[picking up this thread as requested by Stas deep in the bowels of the t/SMOKE thread!...] Stas Bekman wrote: Randy Kobes wrote: In the light of recent changes in pools, does this make any difference to the early startup in a vhost issue? Here is the patch again: http://marc.theaimsgroup.com/?

[PATCH mp2] quotemeta directory in regex

2003-10-10 Thread Steve Hay
Attached a little patch to stop this happening when running "perl t/TEST ...": = C:\Temp\modperl-2.0>perl t/TEST modperl\post_utf8 *** server localhost:8529 shutdown C:\apache2/bin/Apache.exe -d C:/Temp/modperl-2.0/t -f C:/Temp/modperl-2.0/t/conf/httpd.conf -DAPACHE2 -DPERL_USEITHREADS using

Re: Testing and smoking leave a PID file behind

2003-10-10 Thread Steve Hay
Steve Hay wrote: Stas Bekman wrote: Steve Hay wrote: I notice that running tests via nmake test, t/TEST or t/SMOKE leaves a httpd.pid file behind in t/logs after the server has stopped. Is this supposed to happen? I thought Apache normally deleted the httpd.pid file when it is stopped. Th

Re: Testing and smoking leave a PID file behind

2003-10-10 Thread Steve Hay
Stas Bekman wrote: Steve Hay wrote: I notice that running tests via nmake test, t/TEST or t/SMOKE leaves a httpd.pid file behind in t/logs after the server has stopped. Is this supposed to happen? I thought Apache normally deleted the httpd.pid file when it is stopped. That's not under Apa