Geoffrey Young wrote:
but I kinda thought the delayed eval made it a bit
neater - that's the added value :)
Delayed eval? I fail to see where the delay is coming from? You run
eval {} in generate_script,
don't take delay too literally. it was just a bad choice of words on my
part - we bot
Sorry about that; I hadn't realized they went to just one
address. At the time I thought it better to do the mod_perl
and Apache-Test commits together, as the changes addressed
the same issue. I'll separate them in the future, though.
no worries. I just recently discovered this behavior, and I'm
but I kinda thought the delayed eval made it a bit
neater - that's the added value :)
Delayed eval? I fail to see where the delay is coming from? You run eval
{} in generate_script,
don't take delay too literally. it was just a bad choice of words on my
part - we both know what the code is d
Geoffrey Young wrote:
Cool.
Though I'm not sure about the CODEREF part. bugreport is a just a
function to run if 'make test' fails. Though you hardcoded it to be a
function to print something. Since eval of that CODEREF happens during
generate_script() you could just do it and pass that return
Cool.
Though I'm not sure about the CODEREF part. bugreport is a just a
function to run if 'make test' fails. Though you hardcoded it to be a
function to print something. Since eval of that CODEREF happens during
generate_script() you could just do it and pass that return value to
bugreport.
Geoffrey Young wrote:
the attached patch makes it possible to use -bugreport with the
Apache::TestRun(Perl)->generate_script() form
You do: eval { $report->() } but don't check for [EMAIL PROTECTED] Better just drop eval {}
and let it fail.
sorry, I meant to include examples. with this patch,
Geoffrey Young wrote:
http://search.cpan.org/~phoenix/Taint-0.09/Taint.pm
is the one I'm familar with - pure perl and different than the one
from dan.
Ah, that's cool. But as I said that 0.09 fails a bunch of tests for me.
I get the same failures. I'm not a Test::Harness expert, but it look
On Fri, 7 Nov 2003, Stas Bekman wrote:
> Geoffrey Young wrote:
[ ... ]
> > just as a general note, if you noticed, this commit had
> > multiple targets - both the modperl-2.0 and httpd-test
> > repositories - however the commit email went to only one
> > address: [EMAIL PROTECTED]
> >
> > I've see
