Re: [mp2] Possible problem revealed by t/perl/ithreads.t?

2004-02-10 Thread Stas Bekman
Steve Hay wrote: Recent problems with threads and memory pools on Win32 led to a couple of patches being produced by Jan Dubois to help reproduce the problems in non-Win32 land. Specifically, one excellent patch was intended to reproduce any "free to wrong pool" errors: http://www.xray.mpe.mpg.

Re: [mp2 Patch] -Wall -Werrror fixes

2004-02-10 Thread Stas Bekman
Philippe M. Chiasson wrote: Caught a few little problems caught by gcc -Wall -Werror this morning. Good catches, philippe. But plugging these holes with "random" values is ain't right. There is a logic bug that needs to be fixed if we have these issues. Index: src/modules/perl/modperl_const.c ===

Re: new %ENV population behavior

2004-02-10 Thread Stas Bekman
Great work, Geoff. But too big to swallow at once, may be will absorb it with time, but your descriptions sounds reasonable to me. I think you'd like to adjust/extend the docs while it's hot in your head ;) I've just a few comments below: Index: src/modules/perl/mod_perl.c =

Re: [mp2 patch] ModPerl/EazyLife.pm (was Re: [mp2] killing the ghost Apache:: usage?)

2004-02-10 Thread Boris Zentner
Hi Stas, Am Mittwoch, 11. Februar 2004 02:16 schrieb Stas Bekman: > > Now my error message is > > > > Can't locate auto/Apache/Request/PageKit/headers_in.al > > > > So I think Apache::Request use a kind of ->can to check for a method > > before it forwards it. This makes the EazyLife option usele

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in

2004-02-10 Thread Stas Bekman
[EMAIL PROTECTED] wrote: gozer 2004/02/10 09:45:22 [...] +open my $fh, ">$file" || die $!; nice try of adding 'die' without adding it ;) % perl -MO=Deparse,-p -e 'open my $fh, ">$file" || die $!;' open(my $fh, (">$file" || die($!))); which is equal to: open my $fh, ">$file"; but you

Re: [mp2 patch] ModPerl/EazyLife.pm (was Re: [mp2] killing the ghost Apache:: usage?)

2004-02-10 Thread Stas Bekman
Boris Zentner wrote: Hi Stas, I tried it and unfortunely it did not work for me. I downloaded the CVS version of modperl-2 and installed your patch. Thanks for testing it, Boris. As next step I removed all MP2 use directives. #use Apache::RequestRec (); #use Apache::RequestIO (); #use Apache::S

Re: cvs commit: modperl-2.0/todo release

2004-02-10 Thread Stas Bekman
Geoffrey Young wrote: -- PerlModule, PerlRequire, Perl{Set,Add}Var in .htaccess is missing +- PerlModule, PerlRequire, in .htaccess is missing + http://marc.theaimsgroup.com/?t=10537008871&r=1&w=2 Owner: geoff Why Perl{Set,Add}Var aren't on the list any longer? um, because they'

Re: [Patch mp2] Was : mp2 acl support?

2004-02-10 Thread Philippe M. Chiasson
On Tue, 2004-02-10 at 03:28 -0500, Andres Salomon wrote: > Philippe M. Chiasson wrote: > [...] > > | > | Could someone running the ModPerl-Registry tests on Win32 or something > | similarly non-POSIX with this ACL patch ? > | > [...] > > Shouldn't this also touch the -r test a few lines earlier,

Re: cvs commit: modperl-2.0 Changes

2004-02-10 Thread Geoffrey Young
> Good catch, Geoff! How about this: > > Index: src/modules/perl/modperl_mgv.c > === > RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_mgv.c,v > retrieving revision 1.32 > diff -u -r1.32 modperl_mgv.c > --- src/modules/perl/

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-10 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 17:58 -0800, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > >>>What's the advantage of using A::TC::writefile instead ? > >> > >>It doesn't cleanup the files and doesn't log what it does. I see no reason why > >>would you want to delete it. t_write_file is for the test

Re: [mp2 patch] ModPerl/EazyLife.pm (was Re: [mp2] killing the ghost Apache:: usage?)

2004-02-10 Thread Boris Zentner
Hi Stas, I tried it and unfortunely it did not work for me. I downloaded the CVS version of modperl-2 and installed your patch. As next step I removed all MP2 use directives. #use Apache::RequestRec (); #use Apache::RequestIO (); #use Apache::ServerUtil (); #use Apache::RequestUtil (); #use Ap

Re: cvs commit: modperl-2.0/todo release

2004-02-10 Thread Geoffrey Young
>> -- PerlModule, PerlRequire, Perl{Set,Add}Var in .htaccess is missing >> +- PerlModule, PerlRequire, in .htaccess is missing >> + http://marc.theaimsgroup.com/?t=10537008871&r=1&w=2 >> Owner: geoff > > > Why Perl{Set,Add}Var aren't on the list any longer? um, because they'

Re: BUG REPORT: mod_perl2 installation bug on failed apr-ext/uuid.t test

2004-02-10 Thread Stas Bekman
Jeff Beer wrote: [...] But this doesn't: bad_scripts.t make sure that ModPerl-Registry/t/cgi-bin/r_inherited.pl is executable (chmod a+x). If that doesn't help, please post the error message from ModPerl-Registry/t/logs/error_log. t/bad_scriptsNOK 1# Failed test 1 in t/bad_scripts.t at l

Re: cvs commit: modperl-2.0 Changes

2004-02-10 Thread Stas Bekman
Geoffrey Young wrote: -if (modperl_require_module(aTHX_ name, FALSE)) { +if (modperl_require_module(aTHX_ name, logfailure)) { MP_TRACE_h(MP_FUNC, "loaded %s package\n", name); } else { -MP_TRACE_h(MP_FUNC, "fa

Re: [mp2] splitting the test suite into several smaller ones

2004-02-10 Thread Elizabeth Mattijsen
At 08:59 -0800 2/10/04, Stas Bekman wrote: Vivek Khera wrote: For sure, mod_perl could do with a split like this. We have no developer vs. installer separation. All tests are equally important and could detect bugs or environment differences. If we split the tests, we will still have users run th

Re: cvs commit: modperl-2.0 Changes

2004-02-10 Thread Stas Bekman
Geoffrey Young wrote: [...] and in addition may be $r->current_handler, to return the current handler name? 'PerlOuputFilterHandler', 'PerlResponseHandler', etc.? well, if we can do that then I don't see any reason to not stay with current_callback() - it's familiar, and I do kinda like the notio

Re: cvs commit: modperl-2.0/todo release

2004-02-10 Thread Stas Bekman
[EMAIL PROTECTED] wrote: geoff 2004/02/10 07:02:01 Modified:todo release Log: clarify per-dir config issue Revision ChangesPath 1.16 +2 -1 modperl-2.0/todo/release Index: release ===

Re: [mp2] splitting the test suite into several smaller ones

2004-02-10 Thread Stas Bekman
Vivek Khera wrote: On Feb 9, 2004, at 6:20 PM, Stas Bekman wrote: - As the number of tests grows it takes longer to start the test suite. Under threaded mpms it can take a very long time on a loaded machine (10 minutes and more). At the moment we keep on bumping up the I've noticed thi

Re: cvs commit: modperl-2.0 Changes

2004-02-10 Thread Geoffrey Young
> -if (modperl_require_module(aTHX_ name, FALSE)) { > +if (modperl_require_module(aTHX_ name, logfailure)) { >MP_TRACE_h(MP_FUNC, "loaded %s package\n", name); >} >else { > -MP_TRACE_h(MP_FUNC, "faile

Re: [mp2] splitting the test suite into several smaller ones

2004-02-10 Thread Vivek Khera
On Feb 9, 2004, at 6:20 PM, Stas Bekman wrote: - As the number of tests grows it takes longer to start the test suite. Under threaded mpms it can take a very long time on a loaded machine (10 minutes and more). At the moment we keep on bumping up the I've noticed this on lots of CPAN m