Re: [Patch] ap_soak_end_container and argument-less directives

2004-02-11 Thread Geoffrey Young
Philippe M. Chiasson wrote: > As can be seen with this simple config file: > > > > > > > $> httpd -f broken.conf > Syntax error on line 1 of broken.conf: > Expected > but saw with no arguments is a bug in and of itself and ought to be fixed. there was some discussion on this fairly rece

Re: cvs commit: modperl-2.0/todo release

2004-02-11 Thread Stas Bekman
[EMAIL PROTECTED] wrote: geoff 2004/02/11 18:05:29 Modified:.Changes src/modules/perl modperl_cmd.c modperl_config.c modperl_types.h modperl_util.c todo release Added: t/htdocs/merge2 htaccess t/mo

[mp2] refactor perldo in modperl_cmd.c

2004-02-11 Thread Stas Bekman
Doesn't save_item completely copy the original sv away and then restore it on the scope exit? For some reason it doesn't work (fails with 'insecure dependency on eval' error). Index: src/modules/perl/modperl_cmd.c === RCS file: /hom

[Patch] ap_soak_end_container and argument-less directives

2004-02-11 Thread Philippe M. Chiasson
As can be seen with this simple config file: $> httpd -f broken.conf Syntax error on line 1 of broken.conf: Expected > but saw It's only a problem with without argument, i.e. blocks in mod_perl land. It's a bug similar to this other one I found with directive-less directive (http://marc

Re: [Patch mp2] Was : mp2 acl support?

2004-02-11 Thread Stas Bekman
Philippe M. Chiasson wrote: On Wed, 2004-02-11 at 15:15 -0500, Andres Salomon wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Philippe M. Chiasson wrote: [...] | | Can you try this and confirm that it works the way it should for your | setup ? | It looks like there's still an issue with the w

Re: [mp2 Patch] -Wall -Werrror fixes

2004-02-11 Thread Stas Bekman
Philippe M. Chiasson wrote: On Tue, 2004-02-10 at 19:10 -0800, Stas Bekman wrote: Philippe M. Chiasson wrote: Caught a few little problems caught by gcc -Wall -Werror this morning. Good catches, philippe. But plugging these holes with "random" values is ain't right. There is a logic bug that nee

Re: configuration parsing problem httpd-2.0.48/mod_perl 1.99_12

2004-02-11 Thread Philippe M. Chiasson
On Wed, 2004-02-11 at 22:32 +0100, Stefan Traby wrote: > Hi ! > > I tracked down my config-parsing problem so it's easy > to reproduce. Thanks for the tracking down. It seems even something as simple as: LoadModule perl_module modules/mod_perl.so Will cause this problem. It's a bug in http

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in

2004-02-11 Thread Philippe M. Chiasson
On Tue, 2004-02-10 at 17:30 -0800, Stas Bekman wrote: > [EMAIL PROTECTED] wrote: > > gozer 2004/02/10 09:45:22 > [...] > > +open my $fh, ">$file" || die $!; > > nice try of adding 'die' without adding it ;) > > % perl -MO=Deparse,-p -e 'open my $fh, ">$file" || die $!;' > open(my $fh,

Re: [Patch mp2] Was : mp2 acl support?

2004-02-11 Thread Philippe M. Chiasson
On Wed, 2004-02-11 at 15:15 -0500, Andres Salomon wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Philippe M. Chiasson wrote: > [...] > | > | Can you try this and confirm that it works the way it should for your > | setup ? > | > > It looks like there's still an issue with the way fi

Re: [mp2 Patch] -Wall -Werrror fixes

2004-02-11 Thread Philippe M. Chiasson
On Tue, 2004-02-10 at 19:10 -0800, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > Caught a few little problems caught by gcc -Wall -Werror this morning. > > Good catches, philippe. But plugging these holes with "random" values is ain't > right. There is a logic bug that needs to be fixed if

configuration parsing problem httpd-2.0.48/mod_perl 1.99_12

2004-02-11 Thread Stefan Traby
Hi ! I tracked down my config-parsing problem so it's easy to reproduce. Here a complete system-independent httpd.conf: -- ServerName google.com LoadModule perl_module modules/mod_perl.so

Re: compatibility issue on internal_redirect

2004-02-11 Thread Stas Bekman
Stefan Traby wrote: On Wed, Feb 11, 2004 at 10:37:30AM -0800, Stas Bekman wrote: Stefan Traby wrote: Hi ! I do not say that this is a bug, ok? It's just not compatible with old mod_perl :) mod_perl 1.0 doesn't use perlio layers. Cool, and where is the point? :) I was just explaining what's dif

Re: compatibility issue on internal_redirect

2004-02-11 Thread Stefan Traby
On Wed, Feb 11, 2004 at 10:37:30AM -0800, Stas Bekman wrote: > Stefan Traby wrote: > >Hi ! > > > >I do not say that this is a bug, ok? > >It's just not compatible with old mod_perl :) > > mod_perl 1.0 doesn't use perlio layers. Cool, and where is the point? :) > >If STDOUT is crippled mod_perl-1

Re: compatibility issue on internal_redirect

2004-02-11 Thread Stas Bekman
Stefan Traby wrote: Hi ! I do not say that this is a bug, ok? It's just not compatible with old mod_perl :) mod_perl 1.0 doesn't use perlio layers. While porting PApp (http://papp.plan9.de) to mod_perl-1.99_12 I noted that internal_redirect is not compatible with old mod_perl for a special case:

Re: new %ENV population behavior

2004-02-11 Thread Stas Bekman
also why modperl and perl-script have a duplication of the env handling, shouldn't it use the same code (probably moving into the _run handler). well, it's not an exact duplicate - perl-script defaults to +SetupEnv, while modperl does not, which means that the if-logic is slightly different. so

compatibility issue on internal_redirect

2004-02-11 Thread Stefan Traby
Hi ! I do not say that this is a bug, ok? It's just not compatible with old mod_perl :) While porting PApp (http://papp.plan9.de) to mod_perl-1.99_12 I noted that internal_redirect is not compatible with old mod_perl for a special case: If STDOUT is crippled mod_perl-1.99_12 dies, while 1.2x doe

Re: [MP2] Problem in retrieving additional environment variables

2004-02-11 Thread Geoffrey Young
terribly sorry about that - there was nothing in that last email. my finger slipped... --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: new %ENV population behavior

2004-02-11 Thread Geoffrey Young
Stas Bekman wrote: > Great work, Geoff. But too big to swallow at once, may be will absorb it > with time, but your descriptions sounds reasonable to me. yes, it's a lot to take in. it took me a while to do it, too :) >> +#ifdef USE_ITHREADS >> +interp = modperl_interp_select(r, r->co

Re: [MP2] Problem in retrieving additional environment variables

2004-02-11 Thread Geoffrey Young
Stas Bekman wrote: > Geoffrey Young wrote: > >>> But, let's forget for a moment mp1. What's the most intuitive way to >>> handle: >>> >>> $r->subprocess_env(foo => $bar) >>> >>> won't you sort of expect that %ENV will get that entry too? >> >> >> >> well, knowing how apache works it was defini