Philippe M. Chiasson wrote:
Isn't "return;" the more canonical way of returning false ?
Beats me... I know a lot of the mp2 code particular Apache2::Status as I
was just digging in there uses return 0. I really have no preference.
Minor nit, but wouldn't
my @tuples = split /\./, $has_versi
Philip M. Gollucci wrote:
Philip M. Gollucci wrote:
cat .patch
25309
Some notes:
The last time I did this it was 25216.
The version that Stas said works for him was 25292
Unless I am insane, 25309 is NEWER then both.
So I checked directly in the Perforce repository via the web tool.
25309
Stas Bekman wrote:
> Philippe M. Chiasson wrote:
>> Geoffrey Young wrote:
>>
-while (my($key, $file) = each %Apache2::Reload::INCS) {
+foreach my $key (sort { $a cmp $b } keys %Apache2::Reload::INCS) {
+my $file = $Apache2::Reload::INCS{$key};
>
>>> I hate each.
>>
>
Philippe M. Chiasson wrote:
Geoffrey Young wrote:
-while (my($key, $file) = each %Apache2::Reload::INCS) {
+foreach my $key (sort { $a cmp $b } keys %Apache2::Reload::INCS) {
+my $file = $Apache2::Reload::INCS{$key};
I hate each.
each is perfect when iterating over a large
Geoffrey Young wrote:
>>-while (my($key, $file) = each %Apache2::Reload::INCS) {
>>+foreach my $key (sort { $a cmp $b } keys %Apache2::Reload::INCS) {
>>+my $file = $Apache2::Reload::INCS{$key};
>
> I hate each.
each is perfect when iterating over a large hash and not caring about
Philip M. Gollucci wrote:
> Philippe M. Chiasson wrote:
>
>> A better patch might be to first check if we already have that option
>> from Perl,
>> otherwise, try and figure out if it's safe to add it ourselves.
>
> Okay, as requested, I've functionalized this and added a check to make sure
> $cc
Philip M. Gollucci wrote:
> Geoffrey Young wrote:
>
>> shouldn't there be some kind of version requirements on special
>> versions of
>> those modules, then? or do are things broken now but visible, and the
>> patches to the B:: modules fix the brokenness?
>
> Yes, I don't believe most of what
Geoffrey Young wrote:
shouldn't there be some kind of version requirements on special versions of
those modules, then? or do are things broken now but visible, and the
patches to the B:: modules fix the brokenness?
Yes, I don't believe most of what I changed ever worked at least since RC5
witho
Philip M. Gollucci wrote:
> This patch does the following:
>
> o Set some minium version for things I'm finally seeing work.
> o s/Apache2::Peek/Apache::Peek/g this package is both 1.x and 2.x series.
> o moved the defined ness check for $mod_ver before the regex.
> there was at least one modu
> -while (my($key, $file) = each %Apache2::Reload::INCS) {
> +foreach my $key (sort { $a cmp $b } keys %Apache2::Reload::INCS) {
> +my $file = $Apache2::Reload::INCS{$key};
I hate each.
+1
--Geoff
-
To unsubscr
10 matches
Mail list logo
