Re: svn commit: r239724 - /perl/modperl/trunk/lib/Apache2/Build.pm

2005-08-24 Thread Philippe M. Chiasson
Philip M. Gollucci wrote: > Stas Bekman wrote: > >>> +sub cmp_tuples { >>> + >>> +my($a, $b) = @_; >>> + >>> +while (@$a && @$b) { >>> +my $cmp = shift @$a <=> shift @$b; >>> +return $cmp if $cmp; >>> +} >>> + >>> +return @$a <=> @$b; >>> +} >> >> Philip, please avo

Re: svn commit: r239724 - /perl/modperl/trunk/lib/Apache2/Build.pm

2005-08-24 Thread Philip M. Gollucci
Stas Bekman wrote: +sub cmp_tuples { + +my($a, $b) = @_; + +while (@$a && @$b) { +my $cmp = shift @$a <=> shift @$b; +return $cmp if $cmp; +} + +return @$a <=> @$b; +} Philip, please avoid using $a and $b in any code, but sort() callbacks, as they are special

Re: svn commit: r239724 - /perl/modperl/trunk/lib/Apache2/Build.pm

2005-08-24 Thread Stas Bekman
+sub cmp_tuples { + +my($a, $b) = @_; + +while (@$a && @$b) { +my $cmp = shift @$a <=> shift @$b; +return $cmp if $cmp; +} + +return @$a <=> @$b; +} Philip, please avoid using $a and $b in any code, but sort() callbacks, as they are special in perl and may have

Re: Fix for "undefined value" warning in Makefile.PL

2005-08-24 Thread Philip M. Gollucci
Nikolay Ananiev wrote: ok :) Committed. Thanks! -- END What doesn't kill us can only make us stronger. Nothing is impossible. Philip M. Gollucci ([EMAIL PROTECTED]) 301.254.5198 Co

Re: -Wdeclaration-after-statement Final version

2005-08-24 Thread Philippe M. Chiasson
Philip M. Gollucci wrote: > Philip M. Gollucci wrote: > >> Philippe M. Chiasson wrote: >> Ah, I did miss it... read right over it. D'oh! >> > Here is its again with the return 0 left in as most of the code in > Build.pm is return 0 though not all. > Also, using Philippe's cmp_tuples function. Loo

Re: Fix for "undefined value" warning in Makefile.PL

2005-08-24 Thread Nikolay Ananiev
ok :) "Philip M. Gollucci" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Nikolay Ananiev wrote: > > +" LoadModule perl_module modules/$build->{MODPERL_LIB_DSO}", > > + > > +if($build->{MP_APXS}) { > > +warning "", > > +"d