Re: [mp2 patch] accessors for User and Group directives in httpd.conf

2006-01-18 Thread Stas Bekman
Geoffrey Young wrote: +#include "unixd.h" + the only concern I have is this part. mod_rewrite does this #if !defined(OS2) && !defined(WIN32) && !defined(BEOS) && !defined(NETWARE) #include "unixd.h" #define MOD_REWRITE_SET_MUTEX_PERMS /* XXX Apache should define something */ #endif similar

Re: [mp2 patch] accessors for User and Group directives in httpd.conf

2006-01-18 Thread Geoffrey Young
> +#include "unixd.h" > + the only concern I have is this part. mod_rewrite does this #if !defined(OS2) && !defined(WIN32) && !defined(BEOS) && !defined(NETWARE) #include "unixd.h" #define MOD_REWRITE_SET_MUTEX_PERMS /* XXX Apache should define something */ #endif similarly with mod_userdir,

Re: [mp2 patch] accessors for User and Group directives in httpd.conf

2006-01-18 Thread Stas Bekman
>>> Another concern is windows - so if someone can try to build with this >>> patch on windows that would be great. > > >> Patch looks good, at least on Linux/OSX it passes all tests 100%. >> It certainly would be nice to get feedback for win32 platforms before >> checking it in. Otherwise, I thin

Re: [mp2 patch] accessors for User and Group directives in httpd.conf

2006-01-18 Thread Stas Bekman
Stas Bekman wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: I've added accessors to Group and User directives in httpd.conf, so that now you can get that info via: my $user_id = Apache2::ServerUtil->user_id; my $group_id = Apache2::ServerUtil->group_id; the patch is inlined and att

Re: [mp2 patch] accessors for User and Group directives in httpd.conf

2006-01-18 Thread Stas Bekman
Philippe M. Chiasson wrote: Stas Bekman wrote: I've added accessors to Group and User directives in httpd.conf, so that now you can get that info via: my $user_id = Apache2::ServerUtil->user_id; my $group_id = Apache2::ServerUtil->group_id; the patch is inlined and attached (due to long li

Re: [mp2 patch] accessors for User and Group directives in httpd.conf

2006-01-18 Thread Philippe M. Chiasson
Stas Bekman wrote: > I've added accessors to Group and User directives in httpd.conf, so that > now you can get that info via: > > my $user_id = Apache2::ServerUtil->user_id; > my $group_id = Apache2::ServerUtil->group_id; > > the patch is inlined and attached (due to long lines). > > Pleas