Re: apr_table_compress

2003-08-19 Thread Geoffrey Young
Joe Schaefer wrote: Geoffrey Young <[EMAIL PROTECTED]> writes: [...] +=item * compress() + + overlap($table, $flags); + +Compress the data in C<$table>. better: Converts multi-valued keys in C<$table> to single-valued keys. ok + +param C<$table>: The table to add the data to. + ^^^

Re: apr_table_compress

2003-08-19 Thread Geoffrey Young
Ah, of course, now I remember why I did that, thanks ;). Should we pass two arguments? the perl function and the C function? modperl_apr_func_not_implemented(timeout_get, apr_socket_timeout_get, 2.0.40, 0.9.0); I'd probably stick with one or the other, but not both. --Geoff --

Re: apr_table_compress

2003-08-19 Thread Joe Schaefer
Geoffrey Young <[EMAIL PROTECTED]> writes: [...] > +=item * compress() > + > + overlap($table, $flags); > + > +Compress the data in C<$table>. better: Converts multi-valued keys in C<$table> to single-valued keys. > + > +param C<$table>: The table to add the data to. > +

Re: apr_table_compress

2003-08-19 Thread Stas Bekman
Geoffrey Young wrote: Ah, of course, now I remember why I did that, thanks ;). Should we pass two arguments? the perl function and the C function? modperl_apr_func_not_implemented(timeout_get, apr_socket_timeout_get, 2.0.40, 0.9.0); I'd probably stick with one or the other, but not both. repo

Re: apr_table_compress

2003-08-19 Thread Geoffrey Young
ocket_timeout_set(apr_socket_t *sock, apr_interval_time_t t) { -modperl_apr_func_not_implemented(timeout_set, 0.9.0); +modperl_apr_func_not_implemented(timeout_set, 2.0.40, 0.9.0); return APR_ENOTIMPL; } #endif /* pre-APR_0_9_0 (APACHE_2_0_40) */ + +/* pre-APR_0_9_5 (APACHE_2_0_47) + *

Re: apr_table_compress

2003-08-19 Thread Geoffrey Young
-modperl_apr_func_not_implemented(timeout_get, 0.9.0); + modperl_apr_func_not_implemented(timeout_get, 2.0.40, 0.9.0); return APR_ENOTIMPL; } +modperl_apr_func_not_implemented(apr_socket_timeout_get, 2.0.40, 0.9.0); yeah, I thought about that. the reason I kept it the way it was is bec

Re: apr_table_compress

2003-08-19 Thread Stas Bekman
Geoffrey Young wrote: -modperl_apr_func_not_implemented(timeout_get, 0.9.0); + modperl_apr_func_not_implemented(timeout_get, 2.0.40, 0.9.0); return APR_ENOTIMPL; } +modperl_apr_func_not_implemented(apr_socket_timeout_get, 2.0.40, 0.9.0); yeah, I thought about that. the reason I kept

Re: apr_table_compress

2003-08-19 Thread Stas Bekman
modperl_apr_func_not_implemented(timeout_set, 2.0.40, 0.9.0); return APR_ENOTIMPL; } +modperl_apr_func_not_implemented(apr_socket_timeout_set, 2.0.40, 0.9.0); +/* added in APACHE_2_0_47/APR_0_9_4 */ +void apr_table_compress(apr_table_t *t, unsigned flags) +{ +modperl_apr_func_not_

Re: apr_table_compress

2003-08-18 Thread Stas Bekman
Geoffrey Young wrote: [...] modperl_apache_compat.c does exactly that. make sure to mark when it was added so when we bump up the minimal required version we can remove the old workarounds. ap_table_compress first appears in 2.0.47. both 2.0.46 and 2.0.47 claim to have APR 0.9.4, so I guess w

Re: apr_table_compress

2003-08-18 Thread Geoffrey Young
ignored how? 2.0.38 compiles cleanly but then throws a runtime error when I try and use the function (which I guess that is how it always works when you call an undefined C function) Hmm, right, I think WrapXS picks things from the Function.pm and not actually checking the C-source. In that

Re: apr_table_compress

2003-08-18 Thread Stas Bekman
Geoffrey Young wrote: Stas Bekman wrote: Geoffrey Young wrote: hi I've implemented apr_table_compress, which was recently added to the APR table API. the only thing I'm unsure about is what our position is on APR changes - can we rely on the autogeneration code for this (an

Re: apr_table_compress

2003-08-18 Thread Geoffrey Young
Stas Bekman wrote: Geoffrey Young wrote: hi I've implemented apr_table_compress, which was recently added to the APR table API. the only thing I'm unsure about is what our position is on APR changes - can we rely on the autogeneration code for this (and perhaps other recent

Re: apr_table_compress

2003-08-18 Thread Stas Bekman
Geoffrey Young wrote: hi I've implemented apr_table_compress, which was recently added to the APR table API. the only thing I'm unsure about is what our position is on APR changes - can we rely on the autogeneration code for this (and perhaps other recent additions), breaking b

apr_table_compress

2003-08-18 Thread Geoffrey Young
hi I've implemented apr_table_compress, which was recently added to the APR table API. the only thing I'm unsure about is what our position is on APR changes - can we rely on the autogeneration code for this (and perhaps other recent additions), breaking back compat, or do we