Re: Review Request 19836: PIG-3835: Improve performance of union

2014-04-01 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19836/#review39192 --- Ship it! Ship It! - Cheolsoo Park On April 1, 2014, 7:37 p.m., R

Re: Review Request 19836: PIG-3835: Improve performance of union

2014-04-01 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19836/ --- (Updated April 1, 2014, 7:37 p.m.) Review request for pig, Cheolsoo Park and Da

Re: Review Request 19836: PIG-3835: Improve performance of union

2014-04-01 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19836/#review39188 --- Ship it! Sounds good to me. - Cheolsoo Park On April 1, 2014, 6:

Re: Review Request 19836: PIG-3835: Improve performance of union

2014-03-31 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19836/ --- (Updated April 1, 2014, 6:23 a.m.) Review request for pig, Cheolsoo Park and Da

Re: Review Request 19836: PIG-3835: Improve performance of union

2014-03-31 Thread Rohini Palaniswamy
> On March 31, 2014, 5:22 p.m., Cheolsoo Park wrote: > > Hi Rohini, you gave me an aha moment with this patch. It would be nice if > > TEZ-1003 could be fixed before Tez 0.4.0 release. > > > > The approach that you're taking looks great! I had few minor comments while > > reading through your

Re: Review Request 19836: PIG-3835: Improve performance of union

2014-03-31 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19836/#review39048 --- Hi Rohini, you gave me an aha moment with this patch. It would be ni

Review Request 19836: PIG-3835: Improve performance of union

2014-03-31 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19836/ --- Review request for pig, Cheolsoo Park and Daniel Dai. Bugs: PIG-3835 https: