tisonkun commented on code in PR #56:
URL: https://github.com/apache/pulsar-test-infra/pull/56#discussion_r945234643
##
docbot/main.go:
##
@@ -311,6 +311,11 @@ func (a *Action) onPullRequestOpenedOrEdited() error {
// Add missing label
if a.config.GetEnableLabe
Great points, Penghui.
> To optimize, I think we can only let the producer connect to the broker
> and the broker should tell the producer the backlog is exceeded.
In looking at the `CommandProducerSuccess` protobuf message, we
already have the `producer_ready` boolean field. It was added for the
Sent from my iPhone
> On Aug 13, 2022, at 9:35 PM, Michael Marshall wrote:
>
> Thanks for raising this Yunze. The docker image was added to the VOTE
> threads as a convenience for voters/testers. I don't believe we
> established a formal requirement for it, which might explain why it is
> no
michaeljmarshall closed issue #45: Add LICENSE file to root of project directory
URL: https://github.com/apache/pulsar-test-infra/issues/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
michaeljmarshall merged PR #46:
URL: https://github.com/apache/pulsar-test-infra/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
michaeljmarshall commented on PR #46:
URL: https://github.com/apache/pulsar-test-infra/pull/46#issuecomment-1214284523
Thanks for confirming @tisonkun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Good idea. I suggest the naming endings with `Seconds` like
sendDelayOfTwoPhaseDeletionInSeconds,`
reconsumeLaterOfTwoPhaseDeletionInSeconds`.
>private int sendDelaySecondsOfTwoPhaseDeletion = 60;
>private int reconsumeLaterSecondsOfTwoPhaseDeletion = 600;
Yan Zhao 于2022年8月12日周五 10:45写道：
michaeljmarshall commented on issue #58:
URL:
https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1214284219
I agree with moving this to a docker action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Thanks for raising this Yunze. The docker image was added to the VOTE
threads as a convenience for voters/testers. I don't believe we
established a formal requirement for it, which might explain why it is
not in the wiki. It should, however, be listed as an optional step if
we want it to be one.
I
+1. It can help reduce a lot of useless duplication of test cases.
Michael Marshall 于2022年8月11日周四 09:58写道：
> Great suggestion, +1.
>
> - Michael
>
> On Wed, Aug 10, 2022 at 8:38 PM Dave Fisher wrote:
> >
> > Yes, please!
> >
> > Sent from my iPhone
> >
> > > On Aug 10, 2022, at 5:39 PM, PengHui
I agree that the customized one is better. +1 on the customized one.
Jun M 于2022年8月12日周五 10:51写道：
> +1 on the customized one.
>
>
> Cheers
> momo-jun
>
>
--
BR,
Qiang Huang
LGTM. They are very similar.
The OpenJDK provides source-code, and the Temurin JDK provides builds of
the source code.
I would like to point out that they have different licenses.
- The OpenJDK implementation is licensed under the GPL-2.0-only with a
linking exception. [0]
- The Eclipse Temurin™ pr
+1. Flaky tests failures bother contributors a lot. Resolving flak test
failures can greatly improve development efficiency.
PengHui Li 于2022年8月13日周六 10:06写道：
> I thought maybe we can close the flaky test with the Stale label.
> All of them are created very early and have no recurrence within a
[
https://issues.apache.org/jira/browse/PULSAR-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579311#comment-17579311
]
Qiang Huang commented on PULSAR-22:
---
Could you please submit an issue in [https://github
+1 (non-binding)
Haiting Jiang 于2022年8月13日周六 00:27写道：
> Here is the docker images:
>
>
> https://hub.docker.com/layers/271293864/jason918/pulsar/2.7.5/images/sha256-8863429ae891cfdac609455992105427188ccadef98723819c882644084748c9
>
>
> https://hub.docker.com/layers/271294049/jason918/pulsar-all/
+1 (non-binding)
Is 2.8.4 a long term support release?
Yunze Xu 于2022年8月12日周五 16:20写道：
> This is the first release candidate for Apache Pulsar, version 2.8.4.
>
> It fixes the following issues:
>
> https://github.com/apache/pulsar/pulls?q=is%3Amerged+is%3Apr+label%3Arelease%2F2.8.4
>
> *** Pleas
nodece commented on PR #56:
URL: https://github.com/apache/pulsar-test-infra/pull/56#issuecomment-1214186102
Sorry that I forget to review the return value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nodece commented on code in PR #56:
URL: https://github.com/apache/pulsar-test-infra/pull/56#discussion_r945166378
##
docbot/main.go:
##
@@ -420,6 +425,11 @@ func (a *Action) onPullRequestLabeledOrUnlabeled() error {
// Add missing label
if a.config.GetEnableLa
nodece commented on code in PR #56:
URL: https://github.com/apache/pulsar-test-infra/pull/56#discussion_r945166295
##
docbot/main.go:
##
@@ -311,6 +311,11 @@ func (a *Action) onPullRequestOpenedOrEdited() error {
// Add missing label
if a.config.GetEnableLabelM
tisonkun commented on code in PR #56:
URL: https://github.com/apache/pulsar-test-infra/pull/56#discussion_r945165322
##
docbot/main.go:
##
@@ -309,6 +309,11 @@ func (a *Action) onPullRequestOpenedOrEdited() error {
}
}
+ if _, exist := currentLabe
tisonkun commented on code in PR #56:
URL: https://github.com/apache/pulsar-test-infra/pull/56#discussion_r945165238
##
docbot/main.go:
##
@@ -309,6 +309,11 @@ func (a *Action) onPullRequestOpenedOrEdited() error {
}
}
+ if _, exist := currentLabe
nodece commented on code in PR #56:
URL: https://github.com/apache/pulsar-test-infra/pull/56#discussion_r945161884
##
docbot/main.go:
##
@@ -418,6 +423,11 @@ func (a *Action) onPullRequestLabeledOrUnlabeled() error {
}
}
+ if _, exist := currentLa
nodece commented on code in PR #56:
URL: https://github.com/apache/pulsar-test-infra/pull/56#discussion_r945160245
##
docbot/main.go:
##
@@ -309,6 +309,11 @@ func (a *Action) onPullRequestOpenedOrEdited() error {
}
}
+ if _, exist := currentLabels
nodece commented on issue #59:
URL:
https://github.com/apache/pulsar-test-infra/issues/59#issuecomment-1214130678
I noticed the following code. Why are different types distinguished? I think
all four types should be used the same way for labeling.
```
func (a *Action) Run(actionT
nodece commented on issue #59:
URL:
https://github.com/apache/pulsar-test-infra/issues/59#issuecomment-1214126877
> if you can provide concrete reproduce steps, we may investigate the root
cause more accurate.
I'm not sure when happened.
--
This is an automated message from the Ap
nodece commented on issue #59:
URL:
https://github.com/apache/pulsar-test-infra/issues/59#issuecomment-1214126113
This log looks confused.
I have a few questions:
- What are `Issue labels`? Is it equal to `PR labels`?
- Why do the issue labels miss the `doc-label-missing`?
tisonkun commented on issue #59:
URL:
https://github.com/apache/pulsar-test-infra/issues/59#issuecomment-1214097267
Related trace:
https://github.com/apache/pulsar/runs/7816260130?check_suite_focus=true
It seems the content analyze part is correct.
--
This is an automated message
tisonkun commented on issue #59:
URL:
https://github.com/apache/pulsar-test-infra/issues/59#issuecomment-1214075030
cc @maxsxu
@nodece if you can provide concrete reproduce steps, we may investigate the
root cause more accurate.
--
This is an automated message from the Apache Git
nodece opened a new issue, #59:
URL: https://github.com/apache/pulsar-test-infra/issues/59
https://user-images.githubusercontent.com/16235121/184477262-a02197c7-162d-40b5-b4ac-e86d9ffaf2ce.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
tisonkun commented on issue #58:
URL:
https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1213891090
See also https://github.com/tisonkun/pulsar-test-infra/tree/docker-action
for a prototype, the docker image size is 12.9MB.
--
This is an automated message from the Apache
tisonkun opened a new issue, #58:
URL: https://github.com/apache/pulsar-test-infra/issues/58
https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action
I don't know why we use composition and leave the [docbot
workflow](https://github.com/apache/pulsar/blo
tisonkun commented on issue #57:
URL:
https://github.com/apache/pulsar-test-infra/issues/57#issuecomment-1213882471
If we're assuming there're other projects using it, we should publish a tag
and remove it in master.
--
This is an automated message from the Apache Git Service.
To respond
tisonkun opened a new issue, #57:
URL: https://github.com/apache/pulsar-test-infra/issues/57
We've switched to docbot. It should be safe to delete doc-label-check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
33 matches
Mail list logo
