Re: [DISCUSS] Redundant ServiceUrlProvider design and improper use of PIP-121

2023-01-18 Thread Baodi Shi
Hi, Yunze: Obviously, the `ServiceUrlProvider` config is redundant. > Agree. In fact, The client already provides the updateServiceUrl method, which the user can use to implement a dynamic update service URL. As for how the user implements it and how to close his resources, I think it can be lef

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-18 Thread Yunze Xu
I think we can enter the VOTE process now. And I agree with Enrico that in "Alternatives" you should mention the approach of adding a boolean (optional) field to the subscribe request. Thanks, Yunze On Wed, Jan 18, 2023 at 9:52 PM PengHui Li wrote: > > > I see the updated PR adopts this suggesti

[DISCUSS] Redundant ServiceUrlProvider design and improper use of PIP-121

2023-01-18 Thread Yunze Xu
Hi all, Currently we have a `ServiceUrlProvider` interface to configure when constructing a PulsarClient in `ClientBuilder#serviceUrlProvider`. >From the beginning, I thought the `getServiceUrl` method is called each time the service URL is used, e.g. topic metadata lookup. However, the `getServic

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-18 Thread Xiangying Meng
Congratulations Thanks Xiangying On Thu, Jan 19, 2023 at 1:54 PM Zixuan Liu wrote: > Congrats! Bo > > Best, > Zixuan > > ZhangJian He 于2023年1月19日周四 12:33写道: > > > Congratulations > > > > Thanks > > ZhangJian He > > > > > > On Thu, 19 Jan 2023 at 11:47, r...@apache.org > > wrote: > > > > > Con

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-18 Thread Zixuan Liu
Congrats! Bo Best, Zixuan ZhangJian He 于2023年1月19日周四 12:33写道: > Congratulations > > Thanks > ZhangJian He > > > On Thu, 19 Jan 2023 at 11:47, r...@apache.org > wrote: > > > Congratulations!!! > > > > -- > > Thanks > > Xiaolong Ran > > > > Baodi Shi 于2023年1月19日周四 10:08写道: > > > > > Congratula

Re: [ANNOUNCE] New Committer: Baodi Shi

2023-01-18 Thread Zixuan Liu
Congrats! Baodi Best, Zixuan ZhangJian He 于2023年1月19日周四 12:34写道: > Congratulations > > Thanks > ZhangJian He > > > On Thu, 19 Jan 2023 at 11:47, r...@apache.org > wrote: > > > Congratulations!! > > > > -- > > Thanks > > Xiaolong Ran > > > > tison 于2023年1月19日周四 10:07写道: > > > > > Congrats and

Re: [ANNOUNCE] New Committer: Baodi Shi

2023-01-18 Thread ZhangJian He
Congratulations Thanks ZhangJian He On Thu, 19 Jan 2023 at 11:47, r...@apache.org wrote: > Congratulations!! > > -- > Thanks > Xiaolong Ran > > tison 于2023年1月19日周四 10:07写道: > > > Congrats and well deserved! > > > > Welcome onboard, Baodi :) > > > > Best, > > tison. > > > > > > Kai Wang 于2023

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-18 Thread ZhangJian He
Congratulations Thanks ZhangJian He On Thu, 19 Jan 2023 at 11:47, r...@apache.org wrote: > Congratulations!!! > > -- > Thanks > Xiaolong Ran > > Baodi Shi 于2023年1月19日周四 10:08写道: > > > Congratulations ! > > > > Thanks, > > Baodi Shi > > > > > > 在 2023年1月19日 09:56:34 上,Kai Wang 写道: > > > > >

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-18 Thread r...@apache.org
Hello Alexander, thanks your work for this. It seems that all agrees with this PIP, maybe we can enter the VOTE thread to initiate a VOTE process for this PIP. -- Thanks Xiaolong Ran r...@apache.org 于2023年1月19日周四 11:57写道: > +1 > > We can imitate the PulsarClient object, and in the BaseContext i

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-18 Thread r...@apache.org
+1 We can imitate the PulsarClient object, and in the BaseContext interface, add PulsarAdmin and PulsarAdminBuilder as interfaces at the same time. -- Thanks Xiaolong Ran Neng Lu 于2023年1月19日周四 02:28写道: > The proposal makes sense to me. > > The only note I want to add is to make sure the Pulsar

Re: [ANNOUNCE] New Committer: Baodi Shi

2023-01-18 Thread r...@apache.org
Congratulations!! -- Thanks Xiaolong Ran tison 于2023年1月19日周四 10:07写道: > Congrats and well deserved! > > Welcome onboard, Baodi :) > > Best, > tison. > > > Kai Wang 于2023年1月19日周四 09:57写道: > > > Congratulations! > > > > Thanks, > > Kai > > On Jan 18, 2023 at 9:36 PM +0800, dev@pulsar.apache.org,

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-18 Thread r...@apache.org
Congratulations!!! -- Thanks Xiaolong Ran Baodi Shi 于2023年1月19日周四 10:08写道: > Congratulations ! > > Thanks, > Baodi Shi > > > 在 2023年1月19日 09:56:34 上,Kai Wang 写道: > > > Congratulations! > > > > Thanks, > > Kai > > On Jan 18, 2023 at 9:50 PM +0800, PengHui Li , > wrote: > > > > Hi all, > > > >

Re: [DISCUSS] PIP-240 A new API to unload subscriptions

2023-01-18 Thread r...@apache.org
Hello Joe and Enrico: I agree with what you've been emphasizing that we need to fix these issues at the root cause. During the maintenance of the Go SDK, we have encountered many stuck problems since version 0.4.0, some of which belonged to the logic errors handled by the Go SDK itself, and some o

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-18 Thread Baodi Shi
Congratulations ! Thanks, Baodi Shi 在 2023年1月19日 09:56:34 上,Kai Wang 写道: > Congratulations! > > Thanks, > Kai > On Jan 18, 2023 at 9:50 PM +0800, PengHui Li , wrote: > > Hi all, > > > The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong > > (https://github.com/congbobo184)

Re: [ANNOUNCE] New Committer: Baodi Shi

2023-01-18 Thread tison
Congrats and well deserved! Welcome onboard, Baodi :) Best, tison. Kai Wang 于2023年1月19日周四 09:57写道: > Congratulations! > > Thanks, > Kai > On Jan 18, 2023 at 9:36 PM +0800, dev@pulsar.apache.org, wrote: > > > > Congratulations ! >

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-18 Thread Kai Wang
Congratulations! Thanks, Kai On Jan 18, 2023 at 9:50 PM +0800, PengHui Li , wrote: > Hi all, > > The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong > (https://github.com/congbobo184) as a member of the PMC and we are > pleased to announce that he has accepted. > > He is very

Re: [ANNOUNCE] New Committer: Baodi Shi

2023-01-18 Thread Kai Wang
Congratulations! Thanks, Kai On Jan 18, 2023 at 9:36 PM +0800, dev@pulsar.apache.org, wrote: > > Congratulations !

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-18 Thread Neng Lu
The proposal makes sense to me. The only note I want to add is to make sure the PulsarAdmin access in Source and Sink is also controlled by the flag `exposePulsarAdminClientEnabled`. Similar to the following: https://github.com/apache/pulsar/blob/master/pulsar-functions/runtime/src/main/java/or

Re: [DISCUSS] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-01-18 Thread Alexander Preuss
Enrico, >I suggest to put option B into the API changes and move option A to"Alternatives" Thanks for your input, I updated the GitHub issue accordingly. Best, Alexander On Tue, Jan 17, 2023 at 3:17 AM Bonan Hou wrote: > +1 for option b. > > Bonan Hou > > On Tue, Jan 3, 2023 at 10:32 PM Alexan

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-18 Thread houxiaoyu
Congrats!! Hou Xiaoyu Nicolò Boschi 于2023年1月18日周三 22:10写道: > Congrats!! > > Nicolò > > Il giorno mer 18 gen 2023 alle 15:06 Enrico Olivelli > ha scritto: > > > Congrats ! > > > > Enrico > > > > Il giorno mer 18 gen 2023 alle ore 14:50 PengHui Li > > ha scritto: > > > > > > Hi all, > > > > > >

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-18 Thread Nicolò Boschi
Congrats!! Nicolò Il giorno mer 18 gen 2023 alle 15:06 Enrico Olivelli ha scritto: > Congrats ! > > Enrico > > Il giorno mer 18 gen 2023 alle ore 14:50 PengHui Li > ha scritto: > > > > Hi all, > > > > The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong > > (https://github.

Re: [ANNOUNCE] New Committer: Baodi Shi

2023-01-18 Thread Enrico Olivelli
Congratulations ! Enrico Il giorno mer 18 gen 2023 alle ore 14:36 Yunze Xu ha scritto: > > The Project Management Committee (PMC) for Apache Pulsar has invited > Baodi Shi (https://github.com/shibd) to become a committer and we are > pleased to announce that he has accepted. > > Being a committe

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-18 Thread Enrico Olivelli
Congrats ! Enrico Il giorno mer 18 gen 2023 alle ore 14:50 PengHui Li ha scritto: > > Hi all, > > The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong > (https://github.com/congbobo184) as a member of the PMC and we are > pleased to announce that he has accepted. > > He is ve

Re: Facilitate Pulsar shell distribution

2023-01-18 Thread Enrico Olivelli
+1 As written on the GH issue we already have some experience with packing pulsar-shell for homebrew One open point is how to coordinate it with the Apache downloads framework. Apache artifacts should be hosted / downloaded from downloads.apache.org so we have to add some tricks/redirections on

Re: [DISCUSS] PIP-236: Upload AUTO_CONSUME SchemaType to Broker

2023-01-18 Thread PengHui Li
> I see the updated PR adopts this suggestion to set the enum value with 100. But I'm still wondering why not just use the next enum value (21)? What makes AUTO_CONSUME schema different from other schema types like ProtobufNativeSchema (20). Ah, yes, 21 looks good to me. Penghui On Tue, Jan 17,

[ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-18 Thread PengHui Li
Hi all, The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong (https://github.com/congbobo184) as a member of the PMC and we are pleased to announce that he has accepted. He is very active in the community in the past few years and made a lot of great contributions such as tran

[ANNOUNCE] New Committer: Baodi Shi

2023-01-18 Thread Yunze Xu
The Project Management Committee (PMC) for Apache Pulsar has invited Baodi Shi (https://github.com/shibd) to become a committer and we are pleased to announce that he has accepted. Being a committer enables easier contribution to the project since there is no need to go via the patch submission pr

Re: Facilitate Pulsar shell distribution

2023-01-18 Thread Alexander Preuss
Hi Nicolò, Thanks for driving this topic! I think it is a really good idea to improve the distribution. I had a read through the GH issue and I agree, that having the shell available through homebrew would be nice. Best, Alexander On Wed, Jan 18, 2023 at 11:11 AM Nicolò Boschi wrote: > Hi folk

Facilitate Pulsar shell distribution

2023-01-18 Thread Nicolò Boschi
Hi folks, Now that Pulsar 2.11.0 has been released I'd like to discuss possible improvements for Pulsar shell's user experience. Now you either download the tarball or use a docker image, we can improve it. I've opened an issue with some ideas: https://github.com/apache/pulsar/issues/19272 Pleas