Re: Re: [Discuss] PIP-319 Unblock stuck Key_Shared subscription after consumer reconnect

2023-12-01 Thread Rajan Dhabalia
Hi Nikolai, I completely understand your concern and pain. But let's understand ordering semantics for exclusive/fail-over subscription. This subscription makes sure to dispatch new messages which the broker is reading using readPosition must be in order but that doesn't mean the broker will never

Re: [DISCUSS] PIP-320: OpenTelemetry Scaffolding

2023-12-01 Thread Lari Hotari
LGTM. Great work Asaf! -Lari On 2023/11/28 18:14:22 Asaf Mesika wrote: > Hi, > > This is the first sub-PIP for parent PIP-264 > ("Enhanced OTel-based metric > system"). > > This PIPs goal is to introduce OpenTelemetry into Apache Pulsar. When this >

RE: Re: [Discuss] PIP-319 Unblock stuck Key_Shared subscription after consumer reconnect

2023-12-01 Thread Nikolai
Hi Rajan, Thanks for the review! It looks like the root cause of "stuck" keyword is the nature of Key_Shared subscription which must guarantee messages ordering. I understand it is really hard to achieve such guarantees without having separate physical partitions but this feature is very esse